[PATCH 0/7] platform: Remove redundant error messages on IRQ request failure

[PATCH 0/7] platform: Remove redundant error messages on IRQ request failure

[Pan Chuang]

devm_request_threaded_irq() and devm_request_any_context_irq()
automatically log detailed error messages on failure via
the devm_request_result() helper, which prints device
name, IRQ number, handler functions, and error code.

Since devm_request_irq() is a static inline wrapper around
devm_request_threaded_irq(), it also benefits from this
automatic logging.

Remove the now-redundant dev_err() and dev_err_probe() calls
in platform drivers that follow these devm_request_*_irq()
functions, as the core now provides more detailed diagnostic
information on failure.

Pan Chuang (7):
  platform: arm64: Remove redundant dev_err_probe()
  platform/chrome: Remove redundant dev_err()
  platform: cznic: turris-omnia-mcu: Remove redundant dev_err_probe()
  platform: goldfish: pipe: Remove redundant dev_err()
  platform/mellanox: Remove redundant dev_err()
  platform/raspberrypi: Remove redundant dev_err()
  platform/x86: Remove redundant dev_err()/dev_err_probe()

 drivers/platform/arm64/acer-aspire1-ec.c                 | 2 +-
 drivers/platform/arm64/huawei-gaokun-ec.c                | 2 +-
 drivers/platform/arm64/lenovo-thinkpad-t14s.c            | 2 +-
 drivers/platform/arm64/lenovo-yoga-c630.c                | 2 +-
 drivers/platform/chrome/cros_ec.c                        | 5 +----
 drivers/platform/cznic/turris-omnia-mcu-gpio.c           | 2 +-
 drivers/platform/goldfish/goldfish_pipe.c                | 4 +---
 drivers/platform/mellanox/mlxbf-tmfifo.c                 | 1 -
 drivers/platform/mellanox/mlxreg-hotplug.c               | 4 +---
 drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c | 4 +---
 drivers/platform/x86/asus-tf103c-dock.c                  | 2 +-
 drivers/platform/x86/intel/bxtwc_tmu.c                   | 5 +----
 drivers/platform/x86/intel/bytcrc_pwrsrc.c               | 2 +-
 drivers/platform/x86/intel/crystal_cove_charger.c        | 2 +-
 drivers/platform/x86/intel/int0002_vgpio.c               | 4 +---
 drivers/platform/x86/intel/punit_ipc.c                   | 4 +---
 16 files changed, 15 insertions(+), 32 deletions(-)

-- 
2.34.1

[PATCH 2/7] platform/chrome: Remove redundant dev_err()

[Pan Chuang]

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/platform/chrome/cros_ec.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c
index 1da79e3d215b..5d0f5a9187b1 100644
--- a/drivers/platform/chrome/cros_ec.c
+++ b/drivers/platform/chrome/cros_ec.c
@@ -249,11 +249,8 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
 						cros_ec_irq_thread,
 						IRQF_TRIGGER_LOW | IRQF_ONESHOT,
 						"chromeos-ec", ec_dev);
-		if (err) {
-			dev_err(dev, "Failed to request IRQ %d: %d\n",
-				ec_dev->irq, err);
+		if (err)
 			goto exit;
-		}
 	}
 
 	/* Register a platform device for the main EC instance */
-- 
2.34.1

Re: (subset) [PATCH 0/7] platform: Remove redundant error messages on IRQ request failure

[Tzung-Bi Shih]

On Fri, Jul 17, 2026 at 07:20:38PM +0800, Pan Chuang wrote:
> devm_request_threaded_irq() and devm_request_any_context_irq()
> automatically log detailed error messages on failure via
> the devm_request_result() helper, which prints device
> name, IRQ number, handler functions, and error code.
> 
> Since devm_request_irq() is a static inline wrapper around
> devm_request_threaded_irq(), it also benefits from this
> automatic logging.
>
> [...]

Applied to

    https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next

[2/7] platform/chrome: Remove redundant dev_err()
      commit: 17376e7311cdec252b61cb1ecec43be61907781b

Thanks!