* [PATCH v4 00/20] mfd: Use named initializers for arrays of *_device_data
@ 2026-11-10 21:54 Uwe Kleine-König (The Capable Hub)
2026-11-10 21:54 ` [PATCH v4 09/20] mfd: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-11-10 21:54 ` [PATCH v4 15/20] mfd: Use named initializers for platform_device_id array Uwe Kleine-König (The Capable Hub)
0 siblings, 2 replies; 5+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-11-10 21:54 UTC (permalink / raw)
To: Lee Jones
Cc: Florian Fainelli, Broadcom internal kernel review list, Ray Jui,
Scott Branden, mfd, linux-rpi-kernel, linux-arm-kernel,
linux-kernel, Matthias Brugger, AngeloGioacchino Del Regno,
linux-mediatek, Qunqin Zhao, linux-crypto, Benson Leung,
Guenter Roeck, chrome-platform, David Rhodes, Richard Fitzgerald,
Andy Shevchenko, Mika Westerberg, Zha Qipeng, Thomas Richard,
linux-sound, patches, Xu Yilun, Tom Rix, Michael Hennerich,
Chen-Yu Tsai, Marek Vasut, James Ogletree, Fred Treven,
Ben Bright, Support Opensource, Andy Shevchenko, Charles Keepax,
Chanwoo Choi, Krzysztof Kozlowski, André Draszik,
Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
Tony Lindgren, Andreas Werner, Samuel Kayode, Maxime Coquelin,
Alexandre Torgue, linux-renesas-soc, linux-omap, imx, linux-stm32,
Linus Walleij, linux, Nicolas Ferre, Alexandre Belloni,
Claudiu Beznea, Peter Griffin, Alim Akhtar, Tim Harvey,
Neil Armstrong, Sven Peter, Janne Grunau, Neal Gompa,
Mathieu Dubois-Briand, Luca Ceresoli, Saravanan Sekar, Frank Li,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Jonathan Neuschäfer, Matti Vaittinen, Orson Zhai,
Baolin Wang, Chunyan Zhang, Fabrice Gasnier, Jernej Skrabec,
Samuel Holland, Liviu Dudau, Sudeep Holla, Lorenzo Pieralisi,
Geert Uytterhoeven, Magnus Damm, Heiko Stuebner,
linux-samsung-soc, linux-amlogic, asahi, linux-arm-msm,
linux-sunxi, linux-rockchip, Peter Tyser
Hello,
the objective for this series is to prepare mfd for changing
of_device_id and the others to make driver_data a union, see
https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylibre.com/
for the idea behind it.
Changes since v3
(https://lore.kernel.org/cover.1783615311.git.u.kleine-koenig@baylibre.com):
- Rebase to v7.4-rc1
- add various R-b tags
- Fix a bug in patch 3 found by sashiko where I accidentally deleted a
* in sizeof(*pdata).
- Drop patches about spi_device_id that were sent separately initially
and applied in the meantime
These patches are a pain to track and forward port and they are mostly
orthogonal, so I'm happy about a partial application of this series if
only some patches are considered ready.
Best regards
Uwe
Uwe Kleine-König (The Capable Hub) (20):
mfd: bcm2835-pm: Remove member of struct bcm2835_pm that is only used
locally
mfd: bcm2835-pm: Drop unused header
mfd: kempld: Simplify device abstraction
mfd: lp87565: Explicitly set driver data for the generic dt compatible
mfd: mt6360: Drop irrelevant __maybe_unused
mfd: rt4831: Drop irrelevant __maybe_unused
mfd: loongson-se: Drop unused assignment of acpi_device_id driver data
mfd: Drop unused assignment of i2c_device_id driver data
mfd: Drop unused assignment of platform_device_id driver data
mfd: Use named initializers for acpi_device_id arrays
mfd: intel-m10-bmc-pmci: Use named initializers for dfl_device_id
array
mfd: Use named initializers for arrays of i2c_device_id
mfd: twl6030: Use named initializers for of_device_id
mfd: Use PCI_DEVICE* macros to initialize pci_device_id arrays
mfd: Use named initializers for platform_device_id array
mfd: Unify style of acpi_device_id arrays
mfd: Unify style of dmi_system_id arrays
mfd: Unify style of i2c_device_id arrays
mfd: Unify style of of_device_id arrays
mfd: Unify style of pci_device_id arrays
drivers/mfd/88pm800.c | 4 +-
drivers/mfd/88pm805.c | 4 +-
drivers/mfd/88pm860x-core.c | 8 ++--
drivers/mfd/aat2870-core.c | 2 +-
drivers/mfd/ab8500-core.c | 8 ++--
drivers/mfd/ab8500-sysctrl.c | 4 +-
drivers/mfd/ac100.c | 2 +-
drivers/mfd/act8945a.c | 8 ++--
drivers/mfd/adp5520.c | 4 +-
drivers/mfd/altera-a10sr.c | 2 +-
drivers/mfd/altera-sysmgr.c | 2 +-
drivers/mfd/arizona-i2c.c | 14 +++---
drivers/mfd/arizona-spi.c | 2 +-
drivers/mfd/as3711.c | 8 ++--
drivers/mfd/as3722.c | 8 ++--
drivers/mfd/atmel-hlcdc.c | 2 +-
drivers/mfd/atmel-smc.c | 2 +-
drivers/mfd/axp20x-i2c.c | 26 +++++-----
drivers/mfd/axp20x-rsb.c | 2 +-
drivers/mfd/bcm2835-pm.c | 15 ++++--
drivers/mfd/bcm590xx.c | 4 +-
drivers/mfd/bd9571mwv.c | 6 +--
drivers/mfd/bq257xx.c | 8 ++--
drivers/mfd/cgbc-core.c | 2 +-
drivers/mfd/cros_ec_dev.c | 2 +-
drivers/mfd/cs40l50-i2c.c | 6 +--
drivers/mfd/cs40l50-spi.c | 2 +-
drivers/mfd/cs42l43-i2c.c | 10 ++--
drivers/mfd/cs5535-mfd.c | 2 +-
drivers/mfd/da903x.c | 6 +--
drivers/mfd/da9052-i2c.c | 12 ++---
drivers/mfd/da9055-i2c.c | 4 +-
drivers/mfd/da9062-core.c | 4 +-
drivers/mfd/da9063-i2c.c | 11 +++--
drivers/mfd/da9150-core.c | 4 +-
drivers/mfd/db8500-prcmu.c | 4 +-
drivers/mfd/exynos-lpass.c | 2 +-
drivers/mfd/gateworks-gsc.c | 2 +-
drivers/mfd/hi6421-pmic-core.c | 6 +--
drivers/mfd/hi655x-pmic.c | 4 +-
drivers/mfd/intel-lpss-acpi.c | 58 +++++++++++------------
drivers/mfd/intel-m10-bmc-pmci.c | 2 +-
drivers/mfd/intel_pmc_bxt.c | 2 +-
drivers/mfd/intel_quark_i2c_gpio.c | 6 +--
drivers/mfd/intel_soc_pmic_bxtwc.c | 2 +-
drivers/mfd/intel_soc_pmic_chtdc_ti.c | 4 +-
drivers/mfd/intel_soc_pmic_chtwc.c | 2 +-
drivers/mfd/intel_soc_pmic_crc.c | 6 +--
drivers/mfd/intel_soc_pmic_mrfld.c | 4 +-
drivers/mfd/ioc3.c | 4 +-
drivers/mfd/janz-cmodio.c | 14 +++---
drivers/mfd/kempld-core.c | 68 +++++++--------------------
drivers/mfd/khadas-mcu.c | 2 +-
drivers/mfd/lm3533-core.c | 2 +-
drivers/mfd/lochnagar-i2c.c | 2 +-
drivers/mfd/loongson-se.c | 2 +-
drivers/mfd/lp3943.c | 4 +-
drivers/mfd/lp873x.c | 8 ++--
drivers/mfd/lp87565.c | 9 ++--
drivers/mfd/lp8788.c | 2 +-
drivers/mfd/lpc_ich.c | 2 +-
drivers/mfd/macsmc.c | 2 +-
drivers/mfd/madera-core.c | 2 +-
drivers/mfd/madera-i2c.c | 18 +++----
drivers/mfd/max14577.c | 6 +--
drivers/mfd/max7360.c | 2 +-
drivers/mfd/max77541.c | 4 +-
drivers/mfd/max77620.c | 8 ++--
drivers/mfd/max77686.c | 2 +-
drivers/mfd/max77693.c | 4 +-
drivers/mfd/max77714.c | 2 +-
drivers/mfd/max77759.c | 4 +-
drivers/mfd/max77843.c | 8 ++--
drivers/mfd/max8907.c | 6 +--
drivers/mfd/max8925-i2c.c | 6 +--
drivers/mfd/max8997.c | 6 +--
drivers/mfd/max8998.c | 6 +--
drivers/mfd/mc13xxx-spi.c | 6 +--
drivers/mfd/menelaus.c | 2 +-
drivers/mfd/menf21bmc.c | 2 +-
drivers/mfd/mp2629.c | 2 +-
drivers/mfd/mt6360-core.c | 6 +--
drivers/mfd/mt6370.c | 2 +-
drivers/mfd/mt6397-core.c | 4 +-
drivers/mfd/mxs-lradc.c | 4 +-
drivers/mfd/ntxec.c | 4 +-
drivers/mfd/omap-usb-host.c | 4 +-
drivers/mfd/palmas.c | 8 ++--
drivers/mfd/pf1550.c | 2 +-
drivers/mfd/qcom-pm8008.c | 4 +-
drivers/mfd/qcom-pm8xxx.c | 6 +--
drivers/mfd/rave-sp.c | 4 +-
drivers/mfd/rc5t583.c | 4 +-
drivers/mfd/rdc321x-southbridge.c | 2 +-
drivers/mfd/retu-mfd.c | 4 +-
drivers/mfd/rk8xx-i2c.c | 2 +-
drivers/mfd/rk8xx-spi.c | 2 +-
drivers/mfd/rohm-bd71828.c | 4 +-
drivers/mfd/rohm-bd9576.c | 6 +--
drivers/mfd/rsmu_i2c.c | 18 +++----
drivers/mfd/rsmu_spi.c | 2 +-
drivers/mfd/rt4831.c | 6 +--
drivers/mfd/rt5033.c | 4 +-
drivers/mfd/rt5120.c | 2 +-
drivers/mfd/rz-mtu3.c | 2 +-
drivers/mfd/sec-acpm.c | 6 +--
drivers/mfd/sec-i2c.c | 22 ++++-----
drivers/mfd/si476x-i2c.c | 8 ++--
drivers/mfd/simple-mfd-i2c.c | 2 +-
drivers/mfd/sky81452.c | 4 +-
drivers/mfd/sm501.c | 4 +-
drivers/mfd/smpro-core.c | 2 +-
drivers/mfd/sprd-sc27xx-spi.c | 2 +-
drivers/mfd/ssbi.c | 2 +-
drivers/mfd/stm32-lptimer.c | 4 +-
drivers/mfd/stm32-timers.c | 4 +-
drivers/mfd/stmfx.c | 4 +-
drivers/mfd/stmpe-i2c.c | 34 +++++++-------
drivers/mfd/stmpe-spi.c | 14 +++---
drivers/mfd/stpmic1.c | 4 +-
drivers/mfd/stw481x.c | 8 ++--
drivers/mfd/sun6i-prcm.c | 2 +-
drivers/mfd/tc3589x.c | 14 +++---
drivers/mfd/ti-lmu.c | 10 ++--
drivers/mfd/timberdale.c | 2 +-
drivers/mfd/tps6105x.c | 6 +--
drivers/mfd/tps65010.c | 10 ++--
drivers/mfd/tps6507x.c | 6 +--
drivers/mfd/tps65086.c | 4 +-
drivers/mfd/tps65090.c | 6 +--
drivers/mfd/tps65217.c | 6 +--
drivers/mfd/tps65218.c | 8 ++--
drivers/mfd/tps65219.c | 8 ++--
drivers/mfd/tps6586x.c | 6 +--
drivers/mfd/tps65910.c | 12 ++---
drivers/mfd/tps65912-i2c.c | 4 +-
drivers/mfd/tps65912-spi.c | 2 +-
drivers/mfd/tps6594-i2c.c | 12 ++---
drivers/mfd/tps6594-spi.c | 12 ++---
drivers/mfd/tqmx86.c | 2 +-
drivers/mfd/twl-core.c | 22 ++++-----
drivers/mfd/twl4030-audio.c | 4 +-
drivers/mfd/twl4030-power.c | 2 +-
drivers/mfd/twl6030-irq.c | 6 +--
drivers/mfd/twl6040.c | 4 +-
drivers/mfd/upboard-fpga.c | 6 +--
drivers/mfd/vexpress-sysreg.c | 4 +-
drivers/mfd/vx855.c | 2 +-
drivers/mfd/wm831x-core.c | 2 +-
drivers/mfd/wm831x-i2c.c | 14 +++---
drivers/mfd/wm8350-i2c.c | 6 +--
drivers/mfd/wm8400-core.c | 4 +-
drivers/mfd/wm8994-core.c | 8 ++--
include/linux/mfd/bcm2835-pm.h | 9 ----
include/linux/mfd/kempld.h | 12 -----
155 files changed, 478 insertions(+), 520 deletions(-)
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
--
2.56.0.rc1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v4 09/20] mfd: Drop unused assignment of platform_device_id driver data
2026-11-10 21:54 [PATCH v4 00/20] mfd: Use named initializers for arrays of *_device_data Uwe Kleine-König (The Capable Hub)
@ 2026-11-10 21:54 ` Uwe Kleine-König (The Capable Hub)
2026-11-10 23:05 ` Benson Leung
2026-11-10 21:54 ` [PATCH v4 15/20] mfd: Use named initializers for platform_device_id array Uwe Kleine-König (The Capable Hub)
1 sibling, 1 reply; 5+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-11-10 21:54 UTC (permalink / raw)
To: Lee Jones
Cc: Benson Leung, Guenter Roeck, Matthias Brugger,
AngeloGioacchino Del Regno, mfd, chrome-platform, linux-kernel,
linux-arm-kernel, linux-mediatek, Linus Walleij
The drivers explicitly set the .driver_data member of struct
platform_device_id to zero without relying on that value. Drop these
unused assignments
This patch doesn't modify the compiled arrays, only their representation
in source form benefits.
Reviewed-by: Linus Walleij <linusw@kernel.org>
Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
drivers/mfd/cros_ec_dev.c | 2 +-
drivers/mfd/mt6397-core.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index 529a23b804f7..96aac158fd8b 100644
--- a/drivers/mfd/cros_ec_dev.c
+++ b/drivers/mfd/cros_ec_dev.c
@@ -379,7 +379,7 @@ static void ec_device_remove(struct platform_device *pdev)
}
static const struct platform_device_id cros_ec_id[] = {
- { DRV_NAME, 0 },
+ { DRV_NAME },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(platform, cros_ec_id);
diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
index 5d5f816492aa..e74936ac206f 100644
--- a/drivers/mfd/mt6397-core.c
+++ b/drivers/mfd/mt6397-core.c
@@ -435,7 +435,7 @@ static const struct of_device_id mt6397_of_match[] = {
MODULE_DEVICE_TABLE(of, mt6397_of_match);
static const struct platform_device_id mt6397_id[] = {
- { "mt6397", 0 },
+ { "mt6397" },
{ },
};
MODULE_DEVICE_TABLE(platform, mt6397_id);
--
2.56.0.rc1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v4 15/20] mfd: Use named initializers for platform_device_id array
2026-11-10 21:54 [PATCH v4 00/20] mfd: Use named initializers for arrays of *_device_data Uwe Kleine-König (The Capable Hub)
2026-11-10 21:54 ` [PATCH v4 09/20] mfd: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
@ 2026-11-10 21:54 ` Uwe Kleine-König (The Capable Hub)
2026-11-10 23:07 ` Benson Leung
1 sibling, 1 reply; 5+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-11-10 21:54 UTC (permalink / raw)
To: Lee Jones
Cc: Linus Walleij, Benson Leung, Guenter Roeck, Matthias Brugger,
AngeloGioacchino Del Regno, linux-arm-kernel, mfd, linux-kernel,
chrome-platform, linux-mediatek
While being less compact, using named initializers allows to more easily
see which members of the structs are assigned which value without having
to lookup the declaration of the struct. And it's also more robust
against changes to the struct definition.
The mentioned robustness is relevant for a planned change to struct
platform_device_id that replaces .driver_data by an anonymous union.
This patch doesn't modify the compiled arrays, only their representation
in source form benefits.
Also drop a tailing comma after a list terminator to match the common
style for these device-id arrays.
Reviewed-by: Linus Walleij <linusw@kernel.org>
Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
drivers/mfd/ab8500-core.c | 8 ++++----
drivers/mfd/cros_ec_dev.c | 2 +-
drivers/mfd/mt6397-core.c | 4 ++--
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
index d5602b2f4a0e..8638fc8472f7 100644
--- a/drivers/mfd/ab8500-core.c
+++ b/drivers/mfd/ab8500-core.c
@@ -1252,10 +1252,10 @@ static int ab8500_probe(struct platform_device *pdev)
}
static const struct platform_device_id ab8500_id[] = {
- { "ab8500-core", AB8500_VERSION_AB8500 },
- { "ab8505-core", AB8500_VERSION_AB8505 },
- { "ab9540-i2c", AB8500_VERSION_AB9540 },
- { "ab8540-i2c", AB8500_VERSION_AB8540 },
+ { .name = "ab8500-core", .driver_data = AB8500_VERSION_AB8500 },
+ { .name = "ab8505-core", .driver_data = AB8500_VERSION_AB8505 },
+ { .name = "ab9540-i2c", .driver_data = AB8500_VERSION_AB9540 },
+ { .name = "ab8540-i2c", .driver_data = AB8500_VERSION_AB8540 },
{ }
};
diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index 96aac158fd8b..3c7e7f1efd0f 100644
--- a/drivers/mfd/cros_ec_dev.c
+++ b/drivers/mfd/cros_ec_dev.c
@@ -379,7 +379,7 @@ static void ec_device_remove(struct platform_device *pdev)
}
static const struct platform_device_id cros_ec_id[] = {
- { DRV_NAME },
+ { .name = DRV_NAME },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(platform, cros_ec_id);
diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
index e74936ac206f..385121867da5 100644
--- a/drivers/mfd/mt6397-core.c
+++ b/drivers/mfd/mt6397-core.c
@@ -435,8 +435,8 @@ static const struct of_device_id mt6397_of_match[] = {
MODULE_DEVICE_TABLE(of, mt6397_of_match);
static const struct platform_device_id mt6397_id[] = {
- { "mt6397" },
- { },
+ { .name = "mt6397" },
+ { }
};
MODULE_DEVICE_TABLE(platform, mt6397_id);
--
2.56.0.rc1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v4 09/20] mfd: Drop unused assignment of platform_device_id driver data
2026-11-10 21:54 ` [PATCH v4 09/20] mfd: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
@ 2026-11-10 23:05 ` Benson Leung
0 siblings, 0 replies; 5+ messages in thread
From: Benson Leung @ 2026-11-10 23:05 UTC (permalink / raw)
To: Uwe Kleine-König (The Capable Hub)
Cc: Lee Jones, Benson Leung, Guenter Roeck, Matthias Brugger,
AngeloGioacchino Del Regno, mfd, chrome-platform, linux-kernel,
linux-arm-kernel, linux-mediatek, Linus Walleij
[-- Attachment #1: Type: text/plain, Size: 1637 bytes --]
On Tue, Nov 10, 2026 at 10:54:34PM +0100, Uwe Kleine-König (The Capable Hub) wrote:
> The drivers explicitly set the .driver_data member of struct
> platform_device_id to zero without relying on that value. Drop these
> unused assignments
>
> This patch doesn't modify the compiled arrays, only their representation
> in source form benefits.
>
> Reviewed-by: Linus Walleij <linusw@kernel.org>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
> ---
> drivers/mfd/cros_ec_dev.c | 2 +-
> drivers/mfd/mt6397-core.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> index 529a23b804f7..96aac158fd8b 100644
> --- a/drivers/mfd/cros_ec_dev.c
> +++ b/drivers/mfd/cros_ec_dev.c
> @@ -379,7 +379,7 @@ static void ec_device_remove(struct platform_device *pdev)
> }
>
> static const struct platform_device_id cros_ec_id[] = {
> - { DRV_NAME, 0 },
> + { DRV_NAME },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(platform, cros_ec_id);
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index 5d5f816492aa..e74936ac206f 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -435,7 +435,7 @@ static const struct of_device_id mt6397_of_match[] = {
> MODULE_DEVICE_TABLE(of, mt6397_of_match);
>
> static const struct platform_device_id mt6397_id[] = {
> - { "mt6397", 0 },
> + { "mt6397" },
> { },
> };
> MODULE_DEVICE_TABLE(platform, mt6397_id);
> --
> 2.56.0.rc1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4 15/20] mfd: Use named initializers for platform_device_id array
2026-11-10 21:54 ` [PATCH v4 15/20] mfd: Use named initializers for platform_device_id array Uwe Kleine-König (The Capable Hub)
@ 2026-11-10 23:07 ` Benson Leung
0 siblings, 0 replies; 5+ messages in thread
From: Benson Leung @ 2026-11-10 23:07 UTC (permalink / raw)
To: Uwe Kleine-König (The Capable Hub)
Cc: Lee Jones, Linus Walleij, Benson Leung, Guenter Roeck,
Matthias Brugger, AngeloGioacchino Del Regno, linux-arm-kernel,
mfd, linux-kernel, chrome-platform, linux-mediatek
[-- Attachment #1: Type: text/plain, Size: 2893 bytes --]
On Tue, Nov 10, 2026 at 10:54:40PM +0100, Uwe Kleine-König (The Capable Hub) wrote:
> While being less compact, using named initializers allows to more easily
> see which members of the structs are assigned which value without having
> to lookup the declaration of the struct. And it's also more robust
> against changes to the struct definition.
>
> The mentioned robustness is relevant for a planned change to struct
> platform_device_id that replaces .driver_data by an anonymous union.
>
> This patch doesn't modify the compiled arrays, only their representation
> in source form benefits.
>
> Also drop a tailing comma after a list terminator to match the common
> style for these device-id arrays.
>
> Reviewed-by: Linus Walleij <linusw@kernel.org>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
> ---
> drivers/mfd/ab8500-core.c | 8 ++++----
> drivers/mfd/cros_ec_dev.c | 2 +-
> drivers/mfd/mt6397-core.c | 4 ++--
> 3 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
> index d5602b2f4a0e..8638fc8472f7 100644
> --- a/drivers/mfd/ab8500-core.c
> +++ b/drivers/mfd/ab8500-core.c
> @@ -1252,10 +1252,10 @@ static int ab8500_probe(struct platform_device *pdev)
> }
>
> static const struct platform_device_id ab8500_id[] = {
> - { "ab8500-core", AB8500_VERSION_AB8500 },
> - { "ab8505-core", AB8500_VERSION_AB8505 },
> - { "ab9540-i2c", AB8500_VERSION_AB9540 },
> - { "ab8540-i2c", AB8500_VERSION_AB8540 },
> + { .name = "ab8500-core", .driver_data = AB8500_VERSION_AB8500 },
> + { .name = "ab8505-core", .driver_data = AB8500_VERSION_AB8505 },
> + { .name = "ab9540-i2c", .driver_data = AB8500_VERSION_AB9540 },
> + { .name = "ab8540-i2c", .driver_data = AB8500_VERSION_AB8540 },
> { }
> };
>
> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> index 96aac158fd8b..3c7e7f1efd0f 100644
> --- a/drivers/mfd/cros_ec_dev.c
> +++ b/drivers/mfd/cros_ec_dev.c
> @@ -379,7 +379,7 @@ static void ec_device_remove(struct platform_device *pdev)
> }
>
> static const struct platform_device_id cros_ec_id[] = {
> - { DRV_NAME },
> + { .name = DRV_NAME },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(platform, cros_ec_id);
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index e74936ac206f..385121867da5 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -435,8 +435,8 @@ static const struct of_device_id mt6397_of_match[] = {
> MODULE_DEVICE_TABLE(of, mt6397_of_match);
>
> static const struct platform_device_id mt6397_id[] = {
> - { "mt6397" },
> - { },
> + { .name = "mt6397" },
> + { }
> };
> MODULE_DEVICE_TABLE(platform, mt6397_id);
>
> --
> 2.56.0.rc1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-11-10 23:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-10 21:54 [PATCH v4 00/20] mfd: Use named initializers for arrays of *_device_data Uwe Kleine-König (The Capable Hub)
2026-11-10 21:54 ` [PATCH v4 09/20] mfd: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-11-10 23:05 ` Benson Leung
2026-11-10 21:54 ` [PATCH v4 15/20] mfd: Use named initializers for platform_device_id array Uwe Kleine-König (The Capable Hub)
2026-11-10 23:07 ` Benson Leung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox