[isar-cip-core][PATCH 0/2] swupdate-config-wfx: make device identity configurable

[isar-cip-core][PATCH 0/2] swupdate-config-wfx: make device identity configurable

[Alperen Erdogan]

Add WFX_DEVICE_ID variable to allow configuring the wfx suricatta
device identity at build time. Defaults to $(cat /etc/machine-id).

Alperen Erdogan (2):
  swupdate-config-wfx: make device identity configurable
  doc: update wfx documentation for configurable device identity

 doc/README.swupdate.md                                        | 4 ++--
 .../swupdate-config-wfx/files/suricatta_wfx.conf.tmpl         | 2 +-
 ...{swupdate-config-wfx_0.1.bb => swupdate-config-wfx_0.2.bb} | 4 +++-
 3 files changed, 6 insertions(+), 4 deletions(-)
 rename recipes-core/swupdate-config-wfx/{swupdate-config-wfx_0.1.bb => swupdate-config-wfx_0.2.bb} (86%)

--
2.43.0

[isar-cip-core][PATCH 1/2] swupdate-config-wfx: make device identity configurable

[Alperen Erdogan]

Replace hard-coded $(cat /etc/machine-id) with WFX_DEVICE_ID
template variable. Bump recipe version to 0.2.

Signed-off-by: Alperen Erdogan <alperen.erdogan@siemens.com>
---
 .../swupdate-config-wfx/files/suricatta_wfx.conf.tmpl         | 2 +-
 ...{swupdate-config-wfx_0.1.bb => swupdate-config-wfx_0.2.bb} | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)
 rename recipes-core/swupdate-config-wfx/{swupdate-config-wfx_0.1.bb => swupdate-config-wfx_0.2.bb} (86%)

diff --git a/recipes-core/swupdate-config-wfx/files/suricatta_wfx.conf.tmpl b/recipes-core/swupdate-config-wfx/files/suricatta_wfx.conf.tmpl
index f750f3d..ae7fcb5 100644
--- a/recipes-core/swupdate-config-wfx/files/suricatta_wfx.conf.tmpl
+++ b/recipes-core/swupdate-config-wfx/files/suricatta_wfx.conf.tmpl
@@ -1,4 +1,4 @@
 #
 # SPDX-License-Identifier: MIT
 #
-SWUPDATE_SURICATTA_ARGS="--server lua -u ${WFX_URL} -i $(cat /etc/machine-id)"
+SWUPDATE_SURICATTA_ARGS="--server lua -u ${WFX_URL} -i ${WFX_DEVICE_ID}"
diff --git a/recipes-core/swupdate-config-wfx/swupdate-config-wfx_0.1.bb b/recipes-core/swupdate-config-wfx/swupdate-config-wfx_0.2.bb
similarity index 86%
rename from recipes-core/swupdate-config-wfx/swupdate-config-wfx_0.1.bb
rename to recipes-core/swupdate-config-wfx/swupdate-config-wfx_0.2.bb
index c800c84..70a2eb6 100644
--- a/recipes-core/swupdate-config-wfx/swupdate-config-wfx_0.1.bb
+++ b/recipes-core/swupdate-config-wfx/swupdate-config-wfx_0.2.bb
@@ -18,10 +18,12 @@ DEBIAN_PROVIDES := "${PN}"

 PN .= "-${MACHINE}"

+WFX_DEVICE_ID ?= "$(cat /etc/machine-id)"
+
 SRC_URI += "file://suricatta_wfx.conf.tmpl"

 TEMPLATE_FILES += " suricatta_wfx.conf.tmpl"
-TEMPLATE_VARS += " WFX_URL"
+TEMPLATE_VARS += " WFX_URL WFX_DEVICE_ID"

 do_install() {
     install -d ${D}/etc/swupdate/conf.d
--
2.43.0

[isar-cip-core][PATCH 2/2] doc: update wfx documentation for configurable device identity

[Alperen Erdogan]

Update machine-id references to mention WFX_DEVICE_ID.

Signed-off-by: Alperen Erdogan <alperen.erdogan@siemens.com>
---
 doc/README.swupdate.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/README.swupdate.md b/doc/README.swupdate.md
index f308d7e..affb85b 100644
--- a/doc/README.swupdate.md
+++ b/doc/README.swupdate.md
@@ -523,7 +523,7 @@ Now start the image which will contain the RT kernel:
 host$ SWUPDATE_BOOT=y ./start-qemu.sh amd64
 ```

-Check the machine-id in `/etc/machine-id`. SWUpdate is launched with this `id` as the `client-id` and is later used to create `wfx` job for the client:
+By default, SWUpdate uses the machine-id from `/etc/machine-id` as the `client-id` (configurable via `WFX_DEVICE_ID` in the `swupdate-config-wfx` recipe). This `client-id` is later used to create `wfx` job for the client:
 ```
 root@demo cat /etc/machine-id
 049adc79659044f8887c83b3203c84f1
@@ -540,7 +540,7 @@ Create `wfx.workflow.dau.direct` wofkflow:
 host$ curl -L https://raw.githubusercontent.com/siemens/wfx/refs/heads/main/workflow/dau/wfx.workflow.dau.direct.yml | wfxctl workflow create -
 ```

-Create a wfx job that updates the device. Set `client-id` with the `id` from `/etc/machine-id` in qemu:
+Create a wfx job that updates the device. Set `client-id` with the device identity (default: `/etc/machine-id`) from qemu:
 ```
 host$ cat <<EOF | envsubst | wfxctl job create --client-id '049adc79659044f8887c83b3203c84f1' --workflow wfx.workflow.dau.direct -
 {
--
2.43.0

Re: [isar-cip-core][PATCH 0/2] swupdate-config-wfx: make device identity configurable

[Jan Kiszka]

On 20.04.26 10:00, Alperen Erdogan wrote:
> Add WFX_DEVICE_ID variable to allow configuring the wfx suricatta
> device identity at build time. Defaults to $(cat /etc/machine-id).
> 
> Alperen Erdogan (2):
>   swupdate-config-wfx: make device identity configurable
>   doc: update wfx documentation for configurable device identity
> 
>  doc/README.swupdate.md                                        | 4 ++--
>  .../swupdate-config-wfx/files/suricatta_wfx.conf.tmpl         | 2 +-
>  ...{swupdate-config-wfx_0.1.bb => swupdate-config-wfx_0.2.bb} | 4 +++-
>  3 files changed, 6 insertions(+), 4 deletions(-)
>  rename recipes-core/swupdate-config-wfx/{swupdate-config-wfx_0.1.bb => swupdate-config-wfx_0.2.bb} (86%)
> 
> --
> 2.43.0
> 

Looks good to me so far - but would you mind explaining your use case as
well? Do you replace the extraction logic because your target provides
an production device ID differently, or do you pin it to fixed known
value in a development image?

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

Re: [isar-cip-core][PATCH 0/2] swupdate-config-wfx: make device identity configurable

[Fatih Alperen Erdogan]

On Mon, Apr 20, 2026 at 02:11 AM, Jan Kiszka wrote:

>
> On 20.04.26 10:00, Alperen Erdogan wrote:
> > Add WFX_DEVICE_ID variable to allow configuring the wfx suricatta
> > device identity at build time. Defaults to $(cat /etc/machine-id).
> > 
> > Alperen Erdogan (2):
> >   swupdate-config-wfx: make device identity configurable
> >   doc: update wfx documentation for configurable device identity
> > 
> >  doc/README.swupdate.md                                        | 4 ++--
> >  .../swupdate-config-wfx/files/suricatta_wfx.conf.tmpl         | 2 +-
> >  ...{swupdate-config-wfx_0.1.bb => swupdate-config-wfx_0.2.bb} | 4 +++-
> >  3 files changed, 6 insertions(+), 4 deletions(-)
> >  rename recipes-core/swupdate-config-wfx/{swupdate-config-wfx_0.1.bb =>
> swupdate-config-wfx_0.2.bb} (86%)
> > 
> > --
> > 2.43.0
> > 
> 
> Looks good to me so far - but would you mind explaining your use case as
> well? Do you replace the extraction logic because your target provides
> an production device ID differently, or do you pin it to fixed known
> value in a development image?
> 
> Jan
> 
> -- 
> Siemens AG, Foundational Technologies
> Linux Expert Center
>

for this use case, target uses a unique device ID provided by the internal system, so it’s read from a different file path.

Thanks, 

Alperen

Re: [isar-cip-core][PATCH 0/2] swupdate-config-wfx: make device identity configurable

[Jan Kiszka]

On 20.04.26 16:56, Fatih Alperen Erdogan wrote:
> On Mon, Apr 20, 2026 at 02:11 AM, Jan Kiszka wrote:
> 
>>
>> On 20.04.26 10:00, Alperen Erdogan wrote:
>>> Add WFX_DEVICE_ID variable to allow configuring the wfx suricatta
>>> device identity at build time. Defaults to $(cat /etc/machine-id).
>>>
>>> Alperen Erdogan (2):
>>>   swupdate-config-wfx: make device identity configurable
>>>   doc: update wfx documentation for configurable device identity
>>>
>>>  doc/README.swupdate.md                                        | 4 ++--
>>>  .../swupdate-config-wfx/files/suricatta_wfx.conf.tmpl         | 2 +-
>>>  ...{swupdate-config-wfx_0.1.bb => swupdate-config-wfx_0.2.bb} | 4 +++-
>>>  3 files changed, 6 insertions(+), 4 deletions(-)
>>>  rename recipes-core/swupdate-config-wfx/{swupdate-config-wfx_0.1.bb =>
>> swupdate-config-wfx_0.2.bb} (86%)
>>>
>>> --
>>> 2.43.0
>>>
>>
>> Looks good to me so far - but would you mind explaining your use case as
>> well? Do you replace the extraction logic because your target provides
>> an production device ID differently, or do you pin it to fixed known
>> value in a development image?
>>
>> Jan
>>
>> -- 
>> Siemens AG, Foundational Technologies
>> Linux Expert Center
>>
> 
> for this use case, target uses a unique device ID provided by the internal system, so it’s read from a different file path.
> 

OK, that makes sense to me.

Thanks, applied.

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center