Re: [PATCH 6.1.y-cip 19/43] pinctrl: renesas: rzg2l: Add support for RZ/V2H SoC

[Pavel Machek <pavel@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 3092 bytes --]

Hi!

> commit 9bd95ac86e700ab8b1a6c225685e0e5afe426b4e upstream.
> 
> Add pinctrl driver support for RZ/V2H(P) SoC.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Link: https://lore.kernel.org/r/20240530173857.164073-16-prabhakar.mahadev-lad.rj@bp.renesas.com
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> ---
>  drivers/pinctrl/renesas/pinctrl-rzg2l.c | 374 +++++++++++++++++++++++-
>  1 file changed, 371 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> index d42ce90af83ac..8c29c8d3c5743 100644
> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> @@ -1041,14 +1086,104 @@ static int rzg2l_bias_param_to_hw(enum pin_config_param param)
>  	return -EINVAL;
>  }
>  
> +static int rzv2h_hw_to_bias_param(unsigned int bias)
> +{
> +	switch (bias) {
> +	case 0:
> +	case 1:
> +		return PIN_CONFIG_BIAS_DISABLE;
> +	case 2:
> +		return PIN_CONFIG_BIAS_PULL_DOWN;
> +	case 3:
> +		return PIN_CONFIG_BIAS_PULL_UP;
> +	default:
> +		break;
> +	}
> +
> +	return -EINVAL;
> +}
> +
> +static int rzv2h_bias_param_to_hw(enum pin_config_param param)
> +{
> +	switch (param) {
> +	case PIN_CONFIG_BIAS_DISABLE:
> +		return 0;
> +	case PIN_CONFIG_BIAS_PULL_DOWN:
> +		return 2;
> +	case PIN_CONFIG_BIAS_PULL_UP:
> +		return 3;
> +	default:
> +		break;
> +	}
> +
> +	return -EINVAL;
> +}

Again, direct return might be better here.

> +static u8 rzv2h_pin_to_oen_bit(struct rzg2l_pinctrl *pctrl, u32 offset)
> +{
> +	static const char * const pin_names[] = { "ET0_TXC_TXCLK", "ET1_TXC_TXCLK",
> +						  "XSPI0_RESET0N", "XSPI0_CS0N",
> +						  "XSPI0_CKN", "XSPI0_CKP" };
> +	const struct pinctrl_pin_desc *pin_desc = &pctrl->desc.pins[offset];
> +	unsigned int i;
> +
> +	for (i = 0; i < ARRAY_SIZE(pin_names); i++) {
> +		if (!strcmp(pin_desc->name, pin_names[i]))
> +			return i;
> +	}
> +
> +	/* Should not happen. */
> +	return 0;
> +}

Should we have WARN() here?

>  static int rzg2l_pinctrl_pinconf_get(struct pinctrl_dev *pctldev,
>  				     unsigned int _pin,
>  				     unsigned long *config)
>  {
>  	struct rzg2l_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev);
> -	enum pin_config_param param = pinconf_to_config_param(*config);
>  	const struct rzg2l_hwcfg *hwcfg = pctrl->data->hwcfg;
>  	const struct pinctrl_pin_desc *pin = &pctrl->desc.pins[_pin];
> +	u32 param = pinconf_to_config_param(*config);
>  	u64 *pin_data = pin->drv_data;
>  	unsigned int arg = 0;
>  	u32 off;

I wonder what is going on here. param changed types, but I don't see
corresponding change to pinconf_to_config_param() prototype.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]