Re: [PATCH 6.1.y-cip 24/43] pinctrl: renesas: rzg2l: Clarify OEN read/write support

[Pavel Machek <pavel@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 1356 bytes --]

Hi!

> From: Paul Barker <paul.barker.ct@bp.renesas.com>
> 
> commit 07dd08c39eb4b645a0e2f2440a54326b49944705 upstream.
> 
> We currently support OEN read/write for the RZ/G3S SoC but not the
> RZ/G2L SoC family (consisting of RZ/G2L, RZ/G2LC, RZ/G2UL, RZ/V2L &
> RZ/Five). The appropriate functions are renamed to clarify this and to
> match the callback names.
> 
> We should also only set the oen_read and oen_write function pointers for
> the devices which support these operations. This requires us to check
> that these function pointers are valid before calling them.

Usual way to do this would be to introduce dummy functions just
returning errors, and avoiding the check.

> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> @@ -1359,6 +1361,8 @@ static int rzg2l_pinctrl_pinconf_set(struct pinctrl_dev *pctldev,
>  
>  		case PIN_CONFIG_OUTPUT_ENABLE:
>  			arg = pinconf_to_config_argument(_configs[i]);
> +			if (!pctrl->data->oen_write)
> +				return -EOPNOTSUPP;

#define EOPNOTSUPP	122	/* Operation not supported on transport endpoint */

Which is not exactly what is happening here. If userland can see this,
-EINVAL may be better.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]