From: Pavel Machek <pavel@denx.de>
To: Ulrich Hecht <uli@fpond.eu>
Cc: "cip-dev@lists.cip-project.org" <cip-dev@lists.cip-project.org>,
"pavel@denx.de" <pavel@denx.de>,
"nobuhiro1.iwamatsu@toshiba.co.jp"
<nobuhiro1.iwamatsu@toshiba.co.jp>
Subject: Re: Request for reviews for 4.4-st54, 4.4-cip89
Date: Thu, 4 Jul 2024 21:24:56 +0200 [thread overview]
Message-ID: <Zob3CMMN5xTB21pM@duo.ucw.cz> (raw)
In-Reply-To: <729272238.766733.1719933056170@webmail.strato.com>
[-- Attachment #1: Type: text/plain, Size: 1897 bytes --]
Hi!
> Here's the manual backports to review for the next 4.4 release which, as always, can be found in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.4.y-st-rc
>
Thanks for series. This one is a bit crazy, and wrong. Crazy because
it moves code for staging, and wrong because... it turns -ERANGE into
success. It should use 6.1 version of param_set_uint_minmax AFAICT.
+int param_set_uint_minmax(const char *val, const struct kernel_param *kp,
+ unsigned int min, unsigned int max)
+{
+ unsigned int num;
+ int ret;
+
+ if (!val)
+ return -EINVAL;
+ ret = kstrtouint(val, 0, &num);
+ if (ret == -EINVAL || num < min || num > max)
+ return -EINVAL;
+ *((unsigned int *)kp->arg) = num;
+ return 0;
+}
+EXPORT_SYMBOL_GPL(param_set_uint_minmax);
** m | 459de98d7 2a14c9 o | params: lift param_set_uint_minmax to
common code
The reset is okay AFAICT.
a | 62a95de44 30a92c o+ | openvswitch: Set the skbuff pkt_type for proper pmtud support.
a | 85b6bcf9d 52a2f0 o+ | net: usb: smsc95xx: fix changing LED_SEL bit value updated from EEPROM
a | 0049a623d b3dc6e o+ | ipvlan: Dont Use skb->sk in ipvlan_process_v{4,6}_outbound
a | 822ae5a8e f5d4e0 o+ | nilfs2: fix use-after-free of timer for log writer thread
a | f6141cbc2 1cd4bc o+ | vxlan: Fix regression when dropping packets due to invalid src addresses
a | 1ea3de272 1ed447 o | media: v4l2-core: hold videodev_lock until dev reg, finishes
a | 3c9ee8294 dfe6d1 o+ | KVM: arm64: Allow AArch32 PSTATE.M to be restored as System mode
a | 72c5d8e41 25460d o+ | net/9p: fix uninit-value in p9_client_rpc()
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2024-07-04 19:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 15:10 Request for reviews for 4.4-st54, 4.4-cip89 Ulrich Hecht
2024-07-04 19:24 ` Pavel Machek [this message]
2024-07-08 12:58 ` [cip-dev] " Ulrich Hecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zob3CMMN5xTB21pM@duo.ucw.cz \
--to=pavel@denx.de \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=uli@fpond.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox