Re: [PATCH 6.12.y-cip 00/18] Add Support for RZ/G3E ICU

[Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>]

Hi Nobuhiro,

On Mon, Jul 07, 2025 at 05:00:34AM +0000, nobuhiro1.iwamatsu@toshiba.co.jp wrote:
> Hi all,
> 
> > -----Original Message-----
> > From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> > Sent: Friday, July 4, 2025 6:07 PM
> > To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○
> > ＣＰＴ) <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek
> > <pavel@denx.de>
> > Cc: Biju Das <biju.das.jz@bp.renesas.com>; Lad Prabhakar
> > <prabhakar.mahadev-lad.rj@bp.renesas.com>; tomm.merciai@gmail.com
> > Subject: [PATCH 6.12.y-cip 00/18] Add Support for RZ/G3E ICU
> > 
> > Dear All,
> > 
> > This series adds support for the RZ/G3E ICU driver into linux 6.12.y-cip.
> > 
> > The ICU block on the RZ/G3E SoC is almost identical to the one found on the
> > RZ/V2H SoC, with the following differences:
> >  - The TINT register base offset is 0x800 instead of zero.
> >  - The number of supported GPIO interrupts for TINT selection is 141
> >    instead of 86.
> >  - The pin index and TINT selection index are not in the 1:1 map
> >  - The number of TSSR registers is 16 instead of 8
> >  - Each TSSR register can program 2 TINTs instead of 4 TINTs
> > 
> > This series applies on top of [1]
> > 
> > [1]
> > https://patchwork.kernel.org/project/cip-dev/list/?series=978150&state=%2
> > A&archive=both
> > 
> > Thanks & Regards,
> > Tommaso
> > 
> > Biju Das (14):
> >   dt-bindings: interrupt-controller: renesas,rzv2h-icu: Document RZ/G3E
> >     SoC
> >   irqchip/renesas-rzv2h: Fix wrong variable usage in
> >     rzv2h_tint_set_type()
> >   irqchip/renesas-rzv2h: Drop irqchip from struct rzv2h_icu_priv
> >   irqchip/renesas-rzv2h: Simplify rzv2h_icu_init()
> >   irqchip/renesas-rzv2h: Use
> >     devm_reset_control_get_exclusive_deasserted()
> >   irqchip/renesas-rzv2h: Use devm_pm_runtime_enable()
> >   irqchip/renesas-rzv2h: Add struct rzv2h_hw_info with t_offs variable
> >   irqchip/renesas-rzv2h: Add max_tssel to struct rzv2h_hw_info
> >   irqchip/renesas-rzv2h: Add field_width to struct rzv2h_hw_info
> >   irqchip/renesas-rzv2h: Update TSSR_TIEN macro
> >   irqchip/renesas-rzv2h: Update macros ICU_TSSR_TSSEL_{MASK,PREP}
> >   irqchip/renesas-rzv2h: Add RZ/G3E support
> >   irqchip/renesas-rzv2h: Prevent TINT spurious interrupt
> >   arm64: dts: renesas: r9a09g047: Add ICU node
> > 
> > Fabrizio Castro (2):
> >   dt-bindings: interrupt-controller: Add Renesas RZ/V2H(P) Interrupt
> >     Controller
> >   irqchip: Add RZ/V2H(P) Interrupt Control Unit (ICU) driver
> > 
> > Philipp Zabel (2):
> >   reset: replace boolean parameters with flags parameter
> >   reset: Add devres helpers to request pre-deasserted reset controls
> > 
> >  .../renesas,rzv2h-icu.yaml                    | 280 ++++++++
> >  arch/arm64/boot/dts/renesas/r9a09g047.dtsi    |  90 +++
> >  drivers/irqchip/Kconfig                       |   7 +
> >  drivers/irqchip/Makefile                      |   1 +
> >  drivers/irqchip/irq-renesas-rzv2h.c           | 601
> > ++++++++++++++++++
> >  drivers/reset/core.c                          | 119 +++-
> >  drivers/soc/renesas/Kconfig                   |   1 +
> >  include/linux/reset.h                         | 274 ++++++--
> >  8 files changed, 1278 insertions(+), 95 deletions(-)  create mode 100644
> > Documentation/devicetree/bindings/interrupt-controller/renesas,rzv2h-icu.y
> > aml
> >  create mode 100644 drivers/irqchip/irq-renesas-rzv2h.c
> > 
> 
> I reviewed this series, looks good to me. I can apply, if there are no other comments and test was OK.
> Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

Thanks for your work!

Regards,
Tommaso

> 
> Best regards,
>   Nobuhiro
>