Re: [PATCH 6.12.y-cip 05/18] irqchip: Add RZ/V2H(P) Interrupt Control Unit (ICU) driver

[Pavel Machek <pavel@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 1769 bytes --]

Hi!

> From: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> 
> commit 0d7605e75ac2d8620929148f932cde54746c485f upstream.
> 
> Add driver for the Renesas RZ/V2H(P) Interrupt Control Unit (ICU).
> 
> This driver supports the external interrupts NMI, IRQn, and TINTn.
> 

> +++ b/drivers/irqchip/irq-renesas-rzv2h.c
> +static void rzv2h_clear_irq_int(struct rzv2h_icu_priv *priv, unsigned int hwirq)
> +{
> +	unsigned int irq_nr = hwirq - ICU_IRQ_START;
> +	u32 isctr, iitsr, iitsel;
> +	u32 bit = BIT(irq_nr);
> +
> +	isctr = readl_relaxed(priv->base + ICU_ISCTR);
> +	iitsr = readl_relaxed(priv->base + ICU_IITSR);
> +	iitsel = ICU_IITSR_IITSEL_GET(iitsr, irq_nr);
> +
> +	/*
> +	 * When level sensing is used, the interrupt flag gets automatically cleared when the
> +	 * interrupt signal is de-asserted by the source of the interrupt request, therefore clear
> +	 * the interrupt only for edge triggered interrupts.
> +	 */

I'd wrap this at 80 columns.

> +	titsel = ICU_TITSR_TITSEL_GET(titsr, titsel_n);
> +
> +	/*
> +	 * Writing 1 to the corresponding flag from register ICU_TSCTR only has effect if
> +	 * TSTATn = 1b and if it's a rising edge or a falling edge interrupt.
> +	 */

And this.

> +	/*
> +	 * coccicheck complains about a missing put_device call before returning, but it's a false
> +	 * positive. We still need &pdev->dev after successfully returning from this function.
> +	 */
> +	return 0;

cocci -> Cocci... but more seriously people are submitting stable
patches to silence checkers, so this may be worth finding some
workaround.

Best regards,
								Pavel
-- 
In cooperation with DENX Software Engineering GmbH, HRB 165235 Munich,
Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]