Re: [cip-dev] [PATCH 6.12.y-cip 02/23] dt-bindings: pinctrl: renesas: Document RZ/G3L SoC

[Pavel Machek <pavel@nabladev.com>]

[-- Attachment #1: Type: text/plain, Size: 2745 bytes --]

Hi!

> > > -----Original Message-----
> > > From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On
> > > Behalf Of Pavel Machek via lists.cip-project.org
> > > Sent: Wednesday, July 15, 2026 7:12 PM
> > > To: Biju <biju.das.au@gmail.com>
> > > Cc: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○
> > > ＣＰＴ) <nobuhiro.iwamatsu.x90@mail.toshiba>; Pavel Machek
> > > <pavel@nabladev.com>; Biju Das <biju.das.jz@bp.renesas.com>; Lad
> > > Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > Subject: Re: [cip-dev] [PATCH 6.12.y-cip 02/23] dt-bindings: pinctrl: renesas:
> > > Document RZ/G3L SoC
> > >
> > > Hi!
> > >
> > > There seems to be something wrong here:
> > >
> > > > Add documentation for the pin controller found on the Renesas RZ/G3L
> > > > (R9A08G046) SoC. The RZ/G3L PFC is similar to the RZ/G3S SoC but has
> > > > more pins.
> > > ...
> > > > Document renesas,clonech property for controlling clone channel
> > > > control register located on SYSC IP block on RZ/G3L SoC.
> > >
> > > Ok, no mention of deleting constraints for *57.
> > >
> > > > +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.
> > > > +++ yaml
> > > > @@ -154,15 +165,10 @@ allOf:
> > > >        properties:
> > > >          compatible:
> > > >            contains:
> > > > -            const: renesas,r9a09g057-pinctrl
> > > > +            const: renesas,r9a08g046-pinctrl
> > > >      then:
> > > > -      properties:
> > > > -        resets:
> > > > -          maxItems: 2
> > > > -    else:
> > > > -      properties:
> > > > -        resets:
> > > > -          minItems: 3
> > > > +      required:
> > > > +        - renesas,clonech
> > > >
> > > >    - if:
> > > >        properties:
> > >
> > > But now we delete constraints for *57, and add constraints for *46.
> > > That looks wrong?
> > 
> > This is a side effect by backporting.
> > Depending on the order of commits, the contents of the commit log may not match those of the patch.
> 
> The issue is we applied a patch twice in 6.12.y-cip which created duplicate entries
> 
> Patch 1:
> 
> commit 64e2071b58f579b758c83ae3170f2eee5b46fb03
> dt-bindings: pinctrl: renesas: Document RZ/V2H(P) SoC
> 
> Patch 2:
> 
> commit fb73d663b31398aea8528fb231e660c4958b29ff
> dt-bindings: pinctrl: renesas: Document RZ/V2H(P) SoC
> 
> If we need a clean history we need to revert a patch or
> 
> Options:
> 
> 1) Revert offending patch to remove duplicate entry and send new version
> 
> 2) Update the change log while applying.
> 
> Please let me know how you want to proceed.

Aha, ok, I see, thanks for explanation.

Best regards,
								Pavel

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]