From: Pavel Machek <pavel@nabladev.com>
To: nobuhiro.iwamatsu.x90@mail.toshiba
Cc: cip-dev@lists.cip-project.org, pavel@nabladev.com, uli@fpond.eu,
biju.das.jz@bp.renesas.com
Subject: Re: [cip-dev] [PATCH 6.1.y-cip] serial: rsci: Fix symbol namespace of MODULE_IMPORT_NS()
Date: Sat, 22 Aug 2026 10:12:59 +0200 [thread overview]
Message-ID: <aolaC10D2GVjTNMa@duo.ucw.cz> (raw)
In-Reply-To: <1787270513-25812-1-git-send-email-nobuhiro.iwamatsu.x90@mail.toshiba>
[-- Attachment #1: Type: text/plain, Size: 550 bytes --]
Hi!
> In linux-6.1.y, the namespace specified in MODULE_IMPORT_NS() does not
> require a string. This removes the quotes from the namespace name.
This looks okay to me.
Reviewed-by: Pavel Machek <pavel@nabladev.com>
Best regards,
Pavel
> +++ b/drivers/tty/serial/rsci.c
> @@ -15,7 +15,7 @@
> #include "serial_mctrl_gpio.h"
> #include "rsci.h"
>
> -MODULE_IMPORT_NS("SH_SCI");
> +MODULE_IMPORT_NS(SH_SCI);
>
> /* RSCI registers */
> #define RDR 0x00
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2026-08-22 8:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 0:01 [PATCH 6.1.y-cip] serial: rsci: Fix symbol namespace of MODULE_IMPORT_NS() Nobuhiro Iwamatsu
2026-08-22 8:12 ` Pavel Machek [this message]
2026-08-28 2:05 ` [cip-dev] " nobuhiro.iwamatsu.x90
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aolaC10D2GVjTNMa@duo.ucw.cz \
--to=pavel@nabladev.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro.iwamatsu.x90@mail.toshiba \
--cc=uli@fpond.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox