CIP-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 6.1.y-cip] serial: rsci: Fix symbol namespace of MODULE_IMPORT_NS()
@ 2026-08-21  0:01 Nobuhiro Iwamatsu
  2026-08-22  8:12 ` [cip-dev] " Pavel Machek
  0 siblings, 1 reply; 3+ messages in thread
From: Nobuhiro Iwamatsu @ 2026-08-21  0:01 UTC (permalink / raw)
  To: cip-dev; +Cc: pavel, uli, biju.das.jz, Nobuhiro Iwamatsu

In linux-6.1.y, the namespace specified in MODULE_IMPORT_NS() does not
require a string. This removes the quotes from the namespace name.

Fixes: f590c816c238 ("serial: sh-sci: Add support for RZ/G3E RSCI")
Cc: Biju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@mail.toshiba>
---
 drivers/tty/serial/rsci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/rsci.c b/drivers/tty/serial/rsci.c
index 74f931af6d2ad..4a73a8a476027 100644
--- a/drivers/tty/serial/rsci.c
+++ b/drivers/tty/serial/rsci.c
@@ -15,7 +15,7 @@
 #include "serial_mctrl_gpio.h"
 #include "rsci.h"
 
-MODULE_IMPORT_NS("SH_SCI");
+MODULE_IMPORT_NS(SH_SCI);
 
 /* RSCI registers */
 #define RDR	0x00
-- 
2.51.0




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [cip-dev] [PATCH 6.1.y-cip] serial: rsci: Fix symbol namespace of MODULE_IMPORT_NS()
  2026-08-21  0:01 [PATCH 6.1.y-cip] serial: rsci: Fix symbol namespace of MODULE_IMPORT_NS() Nobuhiro Iwamatsu
@ 2026-08-22  8:12 ` Pavel Machek
  2026-08-28  2:05   ` nobuhiro.iwamatsu.x90
  0 siblings, 1 reply; 3+ messages in thread
From: Pavel Machek @ 2026-08-22  8:12 UTC (permalink / raw)
  To: nobuhiro.iwamatsu.x90; +Cc: cip-dev, pavel, uli, biju.das.jz

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

Hi!

> In linux-6.1.y, the namespace specified in MODULE_IMPORT_NS() does not
> require a string. This removes the quotes from the namespace name.

This looks okay to me.

Reviewed-by: Pavel Machek <pavel@nabladev.com>

Best regards,
                                                                Pavel

> +++ b/drivers/tty/serial/rsci.c
> @@ -15,7 +15,7 @@
>  #include "serial_mctrl_gpio.h"
>  #include "rsci.h"
>  
> -MODULE_IMPORT_NS("SH_SCI");
> +MODULE_IMPORT_NS(SH_SCI);
>  
>  /* RSCI registers */
>  #define RDR	0x00


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [cip-dev] [PATCH 6.1.y-cip] serial: rsci: Fix symbol namespace of MODULE_IMPORT_NS()
  2026-08-22  8:12 ` [cip-dev] " Pavel Machek
@ 2026-08-28  2:05   ` nobuhiro.iwamatsu.x90
  0 siblings, 0 replies; 3+ messages in thread
From: nobuhiro.iwamatsu.x90 @ 2026-08-28  2:05 UTC (permalink / raw)
  To: pavel; +Cc: cip-dev, uli, biju.das.jz

Hi all,

> -----Original Message-----
> From: Pavel Machek <pavel@nabladev.com>
> Sent: Saturday, August 22, 2026 5:13 PM
> To: iwamatsu nobuhiro(岩松 信洋 □DITC○CPT)
> <nobuhiro.iwamatsu.x90@mail.toshiba>
> Cc: cip-dev@lists.cip-project.org; pavel@nabladev.com; uli@fpond.eu;
> biju.das.jz@bp.renesas.com
> Subject: Re: [cip-dev] [PATCH 6.1.y-cip] serial: rsci: Fix symbol namespace of
> MODULE_IMPORT_NS()
> 
> Hi!
> 
> > In linux-6.1.y, the namespace specified in MODULE_IMPORT_NS() does not
> > require a string. This removes the quotes from the namespace name.
> 
> This looks okay to me.
> 
> Reviewed-by: Pavel Machek <pavel@nabladev.com>

Thanks, applied.

Best regards,
  Nobuhiro



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-08-28  2:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-21  0:01 [PATCH 6.1.y-cip] serial: rsci: Fix symbol namespace of MODULE_IMPORT_NS() Nobuhiro Iwamatsu
2026-08-22  8:12 ` [cip-dev] " Pavel Machek
2026-08-28  2:05   ` nobuhiro.iwamatsu.x90

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox