From: Pavel Machek <pavel@nabladev.com>
To: nobuhiro.iwamatsu.x90@mail.toshiba
Cc: claudiu.beznea@tuxon.dev, pavel@nabladev.com,
cip-dev@lists.cip-project.org
Subject: Re: [cip-dev] [PATCH 5.10.y-cip v3] PCI: rzg3s-host: Fix compilation warning
Date: Tue, 13 Oct 2026 15:10:45 +0200 [thread overview]
Message-ID: <as4t1cyscqLGSdg6@duo.ucw.cz> (raw)
In-Reply-To: <OS7PR01MB1480829D2B2DA4FCC97978D98CD9E2@OS7PR01MB14808.jpnprd01.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
Hi!
> > From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> >
> > Fix the following compilation warning:
> >
> > pcie_rzg3s_host.c: In function ‘rzg3s_pcie_probe’:
> > ../drivers/pci/controller/pcie-rzg3s-host.c:1558:2: warning: ISO C90 forbids
> > mixed declarations and code [-Wdeclaration-after-statement]
> > 1558 | struct rzg3s_pcie_host *host;
> > | ^~~~~~
> >
> > Fixes: c5249a6594d6 ("PCI: Add Renesas RZ/G3S host controller driver")
> > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> > ---
> >
> > Changes in v3:
> > - fixed it by dropping ';'
> >
> > drivers/pci/controller/pcie-rzg3s-host.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> Looks good to me. I can apply this if there are no other comments.
>
> Reviewed-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@mail.toshiba>
Reviewed-by: Pavel Machek <pavel@nabladev.com>
Thank you,
Pavel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2026-10-13 13:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 14:11 [PATCH 5.10.y-cip v3] PCI: rzg3s-host: Fix compilation warning Claudiu Beznea
2026-10-13 4:52 ` nobuhiro.iwamatsu.x90
2026-10-13 13:10 ` Pavel Machek [this message]
2026-10-14 4:45 ` [cip-dev] " nobuhiro.iwamatsu.x90
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as4t1cyscqLGSdg6@duo.ucw.cz \
--to=pavel@nabladev.com \
--cc=cip-dev@lists.cip-project.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=nobuhiro.iwamatsu.x90@mail.toshiba \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox