[PATCH 5.10.y-cip v3] PCI: rzg3s-host: Fix compilation warning

[PATCH 5.10.y-cip v3] PCI: rzg3s-host: Fix compilation warning

[Claudiu Beznea]

From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

Fix the following compilation warning:

pcie_rzg3s_host.c: In function ‘rzg3s_pcie_probe’:
../drivers/pci/controller/pcie-rzg3s-host.c:1558:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
 1558 |  struct rzg3s_pcie_host *host;
      |  ^~~~~~

Fixes: c5249a6594d6 ("PCI: Add Renesas RZ/G3S host controller driver")
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
---

Changes in v3:
- fixed it by dropping ';'

 drivers/pci/controller/pcie-rzg3s-host.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pcie-rzg3s-host.c b/drivers/pci/controller/pcie-rzg3s-host.c
index 987015e8ec9b..cac42fd8fc4a 100644
--- a/drivers/pci/controller/pcie-rzg3s-host.c
+++ b/drivers/pci/controller/pcie-rzg3s-host.c
@@ -1554,7 +1554,7 @@ static int rzg3s_pcie_probe(struct platform_device *pdev)
 	struct device *dev = &pdev->dev;
 	struct device_node *np = dev->of_node;
 	struct device_node *sysc_np __free(device_node) =
-		of_parse_phandle(np, "renesas,sysc", 0);;
+		of_parse_phandle(np, "renesas,sysc", 0);
 	struct rzg3s_pcie_host *host;
 	int ret;
 
-- 
2.43.0

RE: [PATCH 5.10.y-cip v3] PCI: rzg3s-host: Fix compilation warning

[nobuhiro.iwamatsu.x90]

Hi all,

> -----Original Message-----
> From: Claudiu Beznea <claudiu.beznea@tuxon.dev>
> Sent: Friday, October 2, 2026 11:11 PM
> To: iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○ＣＰＴ)
> <nobuhiro.iwamatsu.x90@mail.toshiba>; pavel@nabladev.com
> Cc: cip-dev@lists.cip-project.org
> Subject: [PATCH 5.10.y-cip v3] PCI: rzg3s-host: Fix compilation warning
> 
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> 
> Fix the following compilation warning:
> 
> pcie_rzg3s_host.c: In function ‘rzg3s_pcie_probe’:
> ../drivers/pci/controller/pcie-rzg3s-host.c:1558:2: warning: ISO C90 forbids
> mixed declarations and code [-Wdeclaration-after-statement]
>  1558 |  struct rzg3s_pcie_host *host;
>       |  ^~~~~~
> 
> Fixes: c5249a6594d6 ("PCI: Add Renesas RZ/G3S host controller driver")
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> ---
> 
> Changes in v3:
> - fixed it by dropping ';'
> 
>  drivers/pci/controller/pcie-rzg3s-host.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Looks good to me. I can apply this if there are no other comments.

Reviewed-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@mail.toshiba>

Best regards,
  Nobuhiro

Re: [cip-dev] [PATCH 5.10.y-cip v3] PCI: rzg3s-host: Fix compilation warning

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 957 bytes --]

Hi!

> > From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> > 
> > Fix the following compilation warning:
> > 
> > pcie_rzg3s_host.c: In function ‘rzg3s_pcie_probe’:
> > ../drivers/pci/controller/pcie-rzg3s-host.c:1558:2: warning: ISO C90 forbids
> > mixed declarations and code [-Wdeclaration-after-statement]
> >  1558 |  struct rzg3s_pcie_host *host;
> >       |  ^~~~~~
> > 
> > Fixes: c5249a6594d6 ("PCI: Add Renesas RZ/G3S host controller driver")
> > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> > ---
> > 
> > Changes in v3:
> > - fixed it by dropping ';'
> > 
> >  drivers/pci/controller/pcie-rzg3s-host.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> Looks good to me. I can apply this if there are no other comments.
> 
> Reviewed-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@mail.toshiba>

Reviewed-by: Pavel Machek <pavel@nabladev.com>

Thank you,
								Pavel

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

RE: [cip-dev] [PATCH 5.10.y-cip v3] PCI: rzg3s-host: Fix compilation warning

[nobuhiro.iwamatsu.x90]

Hi Pavel,

> -----Original Message-----
> From: Pavel Machek <pavel@nabladev.com>
> Sent: Tuesday, October 13, 2026 10:11 PM
> To: iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○ＣＰＴ)
> <nobuhiro.iwamatsu.x90@mail.toshiba>
> Cc: claudiu.beznea@tuxon.dev; pavel@nabladev.com;
> cip-dev@lists.cip-project.org
> Subject: Re: [cip-dev] [PATCH 5.10.y-cip v3] PCI: rzg3s-host: Fix compilation
> warning
> 
> Hi!
> 
> > > From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> > >
> > > Fix the following compilation warning:
> > >
> > > pcie_rzg3s_host.c: In function ‘rzg3s_pcie_probe’:
> > > ../drivers/pci/controller/pcie-rzg3s-host.c:1558:2: warning: ISO C90
> > > forbids mixed declarations and code [-Wdeclaration-after-statement]
> > >  1558 |  struct rzg3s_pcie_host *host;
> > >       |  ^~~~~~
> > >
> > > Fixes: c5249a6594d6 ("PCI: Add Renesas RZ/G3S host controller
> > > driver")
> > > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> > > ---
> > >
> > > Changes in v3:
> > > - fixed it by dropping ';'
> > >
> > >  drivers/pci/controller/pcie-rzg3s-host.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > Looks good to me. I can apply this if there are no other comments.
> >
> > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@mail.toshiba>
> 
> Reviewed-by: Pavel Machek <pavel@nabladev.com>

Thanks, applied.

Best regards,
  Nobuhiro