* Patch review improvements
@ 2026-11-19 11:44 Pavel Machek
0 siblings, 0 replies; only message in thread
From: Pavel Machek @ 2026-11-19 11:44 UTC (permalink / raw)
To: cip-dev
[-- Attachment #1: Type: text/plain, Size: 3089 bytes --]
Hi!
Stable kernels work like this:
There's upstream commit, and there are -stable commits. They reference
the upstream commit in the first line of changelog. If upstream commit
is reviewed in context of 5.10-stable (for example), and diff is same
as in newer -stable kernels, it can be assumed commit is okay for
those kernels, too.
There are "bugfix" and "dependency" commits. Dependencies are often
marked with "Stable-dep-of", and don't seem to follow
stable-kernel-rules.
Commits in -stable have order, and it is useful to review them in
approximately that order, because similar commits are often grouped
together (fixing same bug in 10 drives), and dependencies are often
just before the commit (useful when stable-dep-of is missing).
In past, we could snapshot 5.10-stable, 6.1-stable and 6.12-stable
staging trees in time of 6.12-stable release and get patches to
review. In 2026, we see a patch hitting 6.12-stable, but hitting
5.10-stable after a delay, so that we review 6.12-stable version of a
patch, and only after that corresponding patch hits 5.10-stable tree,
leading to repeated review.
Current scripts I'm using produce output like this:
|e4ee79fcb 1bc953 .: 6.12| comedi: quatech_daqp_cs: Fix sanity check in interrupt handler
|65d5bd36a 1bc953 .: 6.1| comedi: quatech_daqp_cs: Fix sanity check in interrupt handler
|6944f2bfc 1bc953 : 5.10| comedi: quatech_daqp_cs: Fix sanity check in interrupt handler
|d814c51d3 e90d05 .: 6.12| comedi: das6402: Add sanity check to interrupt handler
|0ee3cd2f4 e90d05 .: 6.1| comedi: das6402: Add sanity check to interrupt handler
|a866a62fb e90d05 : 5.10| comedi: das6402: Add sanity check to interrupt handler
|93e91cbf7 8dda63 .: 6.12| comedi: dt2811: Fix sanity check in interrupt handler
|8d212cb9b 8dda63 .: 6.1| comedi: dt2811: Fix sanity check in interrupt handler
|84d53d6f5 8dda63 : 5.10| comedi: dt2811: Fix sanity check in interrupt handler
|bdbd9d5c9 f876cb .: 6.12| comedi: pcm711: Fix sanity check in interrupt handler
|d7383c292 f876cb .: 6.1| comedi: pcm711: Fix sanity check in interrupt handler
|2b1485b47 f876cb : 5.10| comedi: pcm711: Fix sanity check in interrupt handler
... that shows 4 upstream patches hitting 6.12, 6.1 and
5.10. Unfortunately, it is not easy to cooperate on review with system
like that.
Detecting differences in diffs in 5.10 / 6.1 / 6.12 patch is currently
only done manually.
What I'd like to see would be something like this:
f876cb | comedi: pcm711: Fix sanity check in interrupt handler
...patch is queued for 5.10, 6.1, 6.12 stable
...diff is same between 6.12 and mainline, and 5.10 and 6.1
...it does / does not affect -cip kernel configs
...Pavel reviewed 5.10 version
...Ulrich backported patch to 4.19 with/without changes
It is somehow important to be able to view patches in logical order
(current scripts do that only partly). It is important that people
can cooperate on reviews, perhaps by marking "I'll likely be working
on these". I would prefer git-based workflow to something requiring
online web access.
Best regards,
Pavel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-19 11:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 11:44 Patch review improvements Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox