Coccinelle Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: johannes@sipsolutions.net (Johannes Berg)
To: cocci@systeme.lip6.fr
Subject: [Cocci] modifying initializers with spatch?
Date: Thu, 26 Jan 2017 14:32:01 +0100	[thread overview]
Message-ID: <1485437521.14760.5.camel@sipsolutions.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1701261415040.3109@hadrien>


> > @@
> > identifier x;
> > type t;
> > @@
> > ?t x
> > - ={}
> > ?;
> 
> I'm not sure what you are trying to do here.??Remove only the empty
> ones?

I actually tried something more like

@@
@@
identifier x;
type t;
@@
 t x
- ={}
 ;
+memset(&x, 0, sizeof(x));

but that didn't really work either :)

> > I've also not managed to add any memset(&x, 0, sizeof(x)); in the
> > same
> > patch, especially since it should go after all other declarations.
> 
> Here you would want something like:
> 
> f(...) {
> ? when != S
> + memset(...);
> ? S1
> ? ...
> }
> 
> S and S1 should be statements.??If there could be multiple memsets at
> the beginning of a single function, use ++ instead of +.

Ok, so I should combine with the previous one before - do I need the
f(...) or are just the braces enough? This could be in a nested block,
after all.

johannes

  reply	other threads:[~2017-01-26 13:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26 12:28 [Cocci] modifying initializers with spatch? Johannes Berg
2017-01-26 13:17 ` Julia Lawall
2017-01-26 13:32   ` Johannes Berg [this message]
2017-01-26 14:20     ` Julia Lawall
2017-01-26 14:28       ` Johannes Berg
2017-01-26 15:47         ` Julia Lawall
2017-01-26 15:52           ` Johannes Berg
2017-01-26 15:57             ` Julia Lawall
2017-01-27 21:43               ` Johannes Berg
2017-01-27 21:52                 ` Julia Lawall
2017-01-27 22:03                   ` Johannes Berg
2017-01-27 22:09                     ` Julia Lawall
2017-01-27 22:23                       ` Johannes Berg
2017-01-27 23:02                       ` Johannes Berg
2017-01-27 23:20                         ` Johannes Berg
2017-01-28  6:47                           ` Julia Lawall
2017-01-28  8:20                             ` Johannes Berg
2017-01-27  7:09             ` Julia Lawall
2017-01-27  8:55               ` Johannes Berg
2017-01-27 13:11                 ` Julia Lawall
2017-01-27 16:13                   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485437521.14760.5.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox