Coccinelle Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: johannes@sipsolutions.net (Johannes Berg)
To: cocci@systeme.lip6.fr
Subject: [Cocci] modifying array initializers?
Date: Fri, 21 Apr 2017 15:12:23 +0200	[thread overview]
Message-ID: <1492780343.2564.4.camel@sipsolutions.net> (raw)

Hi,

I'm exploring backporting the netlink error reporting stuff from Linux
in backports. I have this:

static __genl_const struct genl_ops nl80211_ops[] = {
????????{
????????????????.cmd = NL80211_CMD_GET_WIPHY,
????????????????.doit = nl80211_get_wiphy,
????????????????.dumpit = nl80211_dump_wiphy,
????????????????.done = nl80211_dump_wiphy_done,
????????????????.policy = nl80211_policy,
????????????????/* can be retrieved by unprivileged users */
????????????????.internal_flags = NL80211_FLAG_NEED_WIPHY |
??????????????????????????????????NL80211_FLAG_NEED_RTNL,
????????},
????????{
????????????????.cmd = NL80211_CMD_SET_WIPHY,
????????????????.doit = nl80211_set_wiphy,
????????????????.policy = nl80211_policy,
????????????????.flags = GENL_UNS_ADMIN_PERM,
????????????????.internal_flags = NL80211_FLAG_NEED_RTNL,
????????},
	[...]
};

and would like to wrap all the .doit calls.

This works for the first instance, but I can't seem to figure out if
it's possible to apply to each one:

@@
identifier fn;
fresh identifier wrap_fn = "_wrap_" ## fn;
@@
+static int wrap_fn(struct sk_buff *skb, struct genl_info *info)
+{
+???????return fn(skb, info);
+}
static struct genl_ops nl80211_ops[] = {
????????{
-???????????????.doit = fn,
+???????????????.doit = wrap_fn,
????????????????...
????????},
????????...
};

Is there a way to loop over all the initializers?

johannes

             reply	other threads:[~2017-04-21 13:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-21 13:12 Johannes Berg [this message]
2017-04-21 14:07 ` [Cocci] modifying array initializers? Julia Lawall
2017-04-21 18:53   ` Johannes Berg
2017-04-21 19:32     ` Julia Lawall
2017-04-21 21:19       ` Johannes Berg
2017-04-21 21:22         ` Julia Lawall
2017-04-21 21:24           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492780343.2564.4.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox