Coccinelle Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: johannes@sipsolutions.net (Johannes Berg)
To: cocci@systeme.lip6.fr
Subject: [Cocci] modifying array initializers?
Date: Fri, 21 Apr 2017 20:53:02 +0200	[thread overview]
Message-ID: <1492800782.19290.1.camel@sipsolutions.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1704211607100.3038@hadrien>

On Fri, 2017-04-21 at 16:07 +0200, Julia Lawall wrote:
> 
> Just add ..., here (note the comma at the end).

I thought I tried that, but maybe not. It doesn't work - at least in my
version - though:

HANDLING: net/wireless/nl80211.c
?????
previous modification:

? <<< static int wrap_fn(struct sk_buff *skb, struct genl_info *info)
? <<< {
? <<< return fn(skb, info);
? <<< }
? <<<?
CONTEXT
According to environment 2:
???rule starting on line 1.wrap_fn -> id _wrap_nl80211_wiphy_netns
???rule starting on line 1.fn -> id nl80211_wiphy_netns

current modification:

? <<< static int wrap_fn(struct sk_buff *skb, struct genl_info *info)
? <<< {
? <<< return fn(skb, info);
? <<< }
? <<<?
CONTEXT
According to environment 2:
???rule starting on line 1.wrap_fn -> id _wrap_nl80211_vendor_cmd
???rule starting on line 1.fn -> id nl80211_vendor_cmd

Fatal error: exception Failure("rule starting on line 1: already tagged
fake token\n")


Sounds like it doesn't like to add multiple things here, let me think
about how to work around that.

johannes

  reply	other threads:[~2017-04-21 18:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-21 13:12 [Cocci] modifying array initializers? Johannes Berg
2017-04-21 14:07 ` Julia Lawall
2017-04-21 18:53   ` Johannes Berg [this message]
2017-04-21 19:32     ` Julia Lawall
2017-04-21 21:19       ` Johannes Berg
2017-04-21 21:22         ` Julia Lawall
2017-04-21 21:24           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492800782.19290.1.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox