[Cocci] [PATCH 1/2] Coccinelle: Make 'report' the default mode

[Cocci] [PATCH 1/2] Coccinelle: Make 'report' the default mode

[Nicolas Palix]

It appears that the 'report' mode is the one always
provided by the semantic patches included in the kernel.
It is thus more natural to select it by default.

The 'chain' mode is however kept and the 'patch' mode
is still the first tried in that case.

Signed-off-by: Nicolas Palix <nicolas.palix@imag.fr>
---

I forgot to sign the previous emails. 

 scripts/coccicheck | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/scripts/coccicheck b/scripts/coccicheck
index 06fcb33..9d8780c 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -44,11 +44,19 @@ fi
 
 if [ "$MODE" = "" ] ; then
     if [ "$ONLINE" = "0" ] ; then
-	echo 'You have not explicitly specified the mode to use. Using default "chain" mode.'
-	echo 'All available modes will be tried (in that order): patch, report, context, org'
+	echo 'You have not explicitly specified the mode to use. Using default "report" mode.'
+	echo 'Available modes are the following: patch, report, context, org'
 	echo 'You can specify the mode with "make coccicheck MODE=<mode>"'
+	echo 'Note however that some modes are not implemented by some semantic patches.'
+    fi
+    MODE="report"
+fi
+
+if [ "$MODE" = "chain" ] ; then
+    if [ "$ONLINE" = "0" ] ; then
+	echo 'You have selected the "chain" mode.'
+	echo 'All available modes will be tried (in that order): patch, report, context, org'
     fi
-    MODE="chain"
 elif [ "$MODE" = "report" -o "$MODE" = "org" ] ; then
     FLAGS="$FLAGS -no_show_diff"
 fi
-- 
1.8.1.2

[Cocci] [PATCH 2/2] Coccinelle: Update the Coccinelle section of MAINTAINERS

[Nicolas Palix]

Add Michal Marek and the misc branch of the kbuild tree
in the Coccinelle section of MAINTAINERS.

Signed-off-by: Nicolas Palix <nicolas.palix@imag.fr>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3d7782b..73b1b3a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2098,7 +2098,9 @@ COCCINELLE/Semantic Patches (SmPL)
 M:	Julia Lawall <Julia.Lawall@lip6.fr>
 M:	Gilles Muller <Gilles.Muller@lip6.fr>
 M:	Nicolas Palix <nicolas.palix@imag.fr>
+M:	Michal Marek <mmarek@suse.cz>
 L:	cocci at systeme.lip6.fr (moderated for non-subscribers)
+T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild.git misc
 W:	http://coccinelle.lip6.fr/
 S:	Supported
 F:	scripts/coccinelle/
-- 
1.8.1.2

[Cocci] [PATCH 1/2] Coccinelle: Make 'report' the default mode

[Michal Marek]

On Thu, Jun 06, 2013 at 11:39:52PM +0200, Nicolas Palix wrote:
> It appears that the 'report' mode is the one always
> provided by the semantic patches included in the kernel.
> It is thus more natural to select it by default.
> 
> The 'chain' mode is however kept and the 'patch' mode
> is still the first tried in that case.
> 
> Signed-off-by: Nicolas Palix <nicolas.palix@imag.fr>

On Thu, Jun 06, 2013 at 11:39:53PM +0200, Nicolas Palix wrote:
> Add Michal Marek and the misc branch of the kbuild tree
> in the Coccinelle section of MAINTAINERS.
> 
> Signed-off-by: Nicolas Palix <nicolas.palix@imag.fr>

I applied both patches to kbuild.git#misc.

Thanks,
Michal

[Cocci] [PATCH 1/2] Coccinelle: Make 'report' the default mode

[Nicolas Palix]

It appears that the 'report' mode is the one always
provided by the semantic patches included in the kernel.
It is thus more natural to select it by default.

The 'chain' mode is however kept and the 'patch' mode
is still the first tried in that case.
---
 scripts/coccicheck | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/scripts/coccicheck b/scripts/coccicheck
index 06fcb33..9d8780c 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -44,11 +44,19 @@ fi
 
 if [ "$MODE" = "" ] ; then
     if [ "$ONLINE" = "0" ] ; then
-	echo 'You have not explicitly specified the mode to use. Using default "chain" mode.'
-	echo 'All available modes will be tried (in that order): patch, report, context, org'
+	echo 'You have not explicitly specified the mode to use. Using default "report" mode.'
+	echo 'Available modes are the following: patch, report, context, org'
 	echo 'You can specify the mode with "make coccicheck MODE=<mode>"'
+	echo 'Note however that some modes are not implemented by some semantic patches.'
+    fi
+    MODE="report"
+fi
+
+if [ "$MODE" = "chain" ] ; then
+    if [ "$ONLINE" = "0" ] ; then
+	echo 'You have selected the "chain" mode.'
+	echo 'All available modes will be tried (in that order): patch, report, context, org'
     fi
-    MODE="chain"
 elif [ "$MODE" = "report" -o "$MODE" = "org" ] ; then
     FLAGS="$FLAGS -no_show_diff"
 fi
-- 
1.8.1.2