[Cocci] parameter list to expression list?

[Cocci] parameter list to expression list?

[Michael Stefaniuc]

Hello,

is there an intrinsic way to get from a parameter list to an expression
list? That would come in handy when forwarding from one function to
another one. At the moment I help myself with a python rule that
transforms the parameter list to an identifier but that feels clumsy.
E.g. in SmPL pseudo code something like this would be nice:

@@
type T;
parameter list P;
expression list E = P;
expression ret;
@@
 T foo(P)
 {
     return
-           ret
+           bar(E)
     ;
 }



thanks
bye
	michael

[Cocci] parameter list to expression list?

[Julia Lawall]

On Mon, 25 Mar 2013, Michael Stefaniuc wrote:

> Hello,
> 
> is there an intrinsic way to get from a parameter list to an expression
> list? That would come in handy when forwarding from one function to
> another one. At the moment I help myself with a python rule that
> transforms the parameter list to an identifier but that feels clumsy.
> E.g. in SmPL pseudo code something like this would be nice:
> 
> @@
> type T;
> parameter list P;
> expression list E = P;
> expression ret;
> @@
>  T foo(P)
>  {
>      return
> -           ret
> +           bar(E)
>      ;
>  }

No, there is nothing. I guess your transformation gets rid of the types in 
the parameter list?  Perhaps what you would liek is a way to just match 
the list of identifier parts?

julia

[Cocci] parameter list to expression list?

[Michael Stefaniuc]

On 03/25/2013 10:27 PM, Julia Lawall wrote:
> On Mon, 25 Mar 2013, Michael Stefaniuc wrote:
> 
>> Hello,
>>
>> is there an intrinsic way to get from a parameter list to an expression
>> list? That would come in handy when forwarding from one function to
>> another one. At the moment I help myself with a python rule that
>> transforms the parameter list to an identifier but that feels clumsy.
>> E.g. in SmPL pseudo code something like this would be nice:
>>
>> @@
>> type T;
>> parameter list P;
>> expression list E = P;
>> expression ret;
>> @@
>>  T foo(P)
>>  {
>>      return
>> -           ret
>> +           bar(E)
>>      ;
>>  }
> 
> No, there is nothing. I guess your transformation gets rid of the types in 
> the parameter list?  Perhaps what you would liek is a way to just match 
> the list of identifier parts?
Yes, something like that.
What I do now is:

@script:python new@
params << get.params;
args;
@@
import re
for p in params.elements:
    coccinelle.args += ", " + re.sub(r".* (\w+)$", r"\1", p)

thanks
bye
        michael

[Cocci] parameter list to expression list?

[Michael Stefaniuc]

Hello Julia,

On 03/27/2013 06:31 PM, Julia Lawall wrote:
> Could you try the attached patch?  The line numbers are almost certain not
> to work out, but maybe it will be able to figure out what to do.
sorry for the late reply. The patch works like a charm.

Thanks!
bye
	michael

> 
> The idea is to do the following:
> 
> @r@
> parameter list P;
> expression list E;
> @@
> 
> main(P at E) {
> + foo(E);
>   return 0;
> }
> 
> julia
> 

[Cocci] parameter list to expression list?

[Julia Lawall]

On Mon, 8 Apr 2013, Michael Stefaniuc wrote:

> Hello Julia,
>
> On 03/27/2013 06:31 PM, Julia Lawall wrote:
> > Could you try the attached patch?  The line numbers are almost certain not
> > to work out, but maybe it will be able to figure out what to do.
> sorry for the late reply. The patch works like a charm.

Great.  It is in rc17.

julia

>
> Thanks!
> bye
> 	michael
>
> >
> > The idea is to do the following:
> >
> > @r@
> > parameter list P;
> > expression list E;
> > @@
> >
> > main(P at E) {
> > + foo(E);
> >   return 0;
> > }
> >
> > julia
> >
>
>