* Re: [cocci] [PATCH 00/21] HID: fix racy force feedback initialization via .input_configured() [not found] <20260803-hid-ff-input-configured-v1-0-1dc9bbacd88c@gmail.com> @ 2026-08-14 12:47 ` Jiri Kosina [not found] ` <20260803-hid-ff-input-configured-v1-2-1dc9bbacd88c@gmail.com> 1 sibling, 0 replies; 7+ messages in thread From: Jiri Kosina @ 2026-08-14 12:47 UTC (permalink / raw) To: Dmitry Torokhov Cc: Benjamin Tissoires, Jonathan Corbet, Shuah Khan, Julia Lawall, Nicolas Palix, Filipe Laíns, Bastien Nocera, linux-input, linux-kernel, linux-doc, cocci On Mon, 3 Aug 2026, Dmitry Torokhov wrote: > When a HID driver calls hid_hw_start() with the HID_CONNECT_HIDINPUT > flag (included in HID_CONNECT_DEFAULT), the HID core immediately registers > the input device with the input subsystem, making it live and accessible to > userspace. > > Historically, many HID drivers initialized force-feedback capabilities (via > input_ff_create_memless() or custom workqueues) in their probe() callback > after calling hid_hw_start(). This introduces a window where userspace can > open the input node and trigger force-feedback ioctls before the driver has > finished preparing its private structures or workqueues, leading to potential > NULL pointer dereferences and race conditions. Hm, this has probably been the case for ages indeed. Thanks for noticing. > To eliminate this anti-pattern across the subsystem, this series: > - Enhances the HID core to automatically handle driver force-feedback > initialization during input device registration. > - Refactors individual HID drivers to perform all force-feedback setup > inside the .input_configured() callback, ensuring the input device is > fully prepared before it is exposed to userspace. > - Adds documentation and a Coccinelle script to prevent future regressions. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Now queued in hid.git#for-7.3/core. Thanks, -- Jiri Kosina SUSE Labs ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20260803-hid-ff-input-configured-v1-2-1dc9bbacd88c@gmail.com>]
* Re: [cocci] [PATCH 02/21] HID: add documentation and Coccinelle script for FF registration race [not found] ` <20260803-hid-ff-input-configured-v1-2-1dc9bbacd88c@gmail.com> @ 2026-08-16 18:52 ` Julia Lawall 2026-08-17 4:03 ` Dmitry Torokhov 2026-08-18 12:04 ` [cocci] " Ricardo Ribalda 1 sibling, 1 reply; 7+ messages in thread From: Julia Lawall @ 2026-08-16 18:52 UTC (permalink / raw) To: Dmitry Torokhov Cc: Jiri Kosina, Benjamin Tissoires, Jonathan Corbet, Shuah Khan, Nicolas Palix, Filipe Laíns, Bastien Nocera, linux-input, linux-kernel, linux-doc, cocci > diff --git a/scripts/coccinelle/hid/ff_race.cocci b/scripts/coccinelle/hid/ff_race.cocci > new file mode 100644 > index 000000000000..479f5d1e3184 > --- /dev/null > +++ b/scripts/coccinelle/hid/ff_race.cocci > @@ -0,0 +1,34 @@ > +/// Detect HID drivers that initialize force-feedback after hid_hw_start() > +/// when HID_CONNECT_HIDINPUT is used. This is a lifecycle violation as > +/// the input device is already registered. > +// > +// Confidence: High > +// Copyright: (C) 2026 Gemini. GPLv2. > + > +virtual report > + > +@r@ > +identifier probe_fn; > +expression hdev, flags; > +position p1, p2; > +@@ > + > +probe_fn(struct hid_device *hdev, ...) { > + <... > + hid_hw_start@p1(hdev, flags) > + ... > + \(input_ff_create\|input_ff_create_memless\)@p2(...) > + ...> > +} This seems unnecessarily costly. The pattern can be just: hid_hw_start@p1(hdev, flags) ... \(input_ff_create\|input_ff_create_memless\)@p2(...) Or does it matter that struct hid_device *hdev is the first parameter of the enclosing function? julia > + > +@script:python depends on report@ > +p1 << r.p1; > +p2 << r.p2; > +flags << r.flags; > +@@ > + > +# Check if flags include HID_CONNECT_HIDINPUT (0x01) or HID_CONNECT_DEFAULT (0x0f) > +# Note: HID_CONNECT_DEFAULT is 0x0f, HID_CONNECT_HIDINPUT is 0x01 > +if "HID_CONNECT_HIDINPUT" in flags or "HID_CONNECT_DEFAULT" in flags: > + msg = "WARNING: force-feedback initialized after hid_hw_start() with HID_CONNECT_HIDINPUT. Input device is already registered at this point. Use .input_configured() instead." > + coccilib.report.print_report(p2[0], msg) > > -- > 2.55.0.629.g250fe7f194-goog > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [cocci] [PATCH 02/21] HID: add documentation and Coccinelle script for FF registration race 2026-08-16 18:52 ` [cocci] [PATCH 02/21] HID: add documentation and Coccinelle script for FF registration race Julia Lawall @ 2026-08-17 4:03 ` Dmitry Torokhov 0 siblings, 0 replies; 7+ messages in thread From: Dmitry Torokhov @ 2026-08-17 4:03 UTC (permalink / raw) To: Julia Lawall Cc: Jiri Kosina, Benjamin Tissoires, Jonathan Corbet, Shuah Khan, Nicolas Palix, Filipe Laíns, Bastien Nocera, linux-input, linux-kernel, linux-doc, cocci On Sun, Aug 16, 2026 at 08:52:51PM +0200, Julia Lawall wrote: > > diff --git a/scripts/coccinelle/hid/ff_race.cocci b/scripts/coccinelle/hid/ff_race.cocci > > new file mode 100644 > > index 000000000000..479f5d1e3184 > > --- /dev/null > > +++ b/scripts/coccinelle/hid/ff_race.cocci > > @@ -0,0 +1,34 @@ > > +/// Detect HID drivers that initialize force-feedback after hid_hw_start() > > +/// when HID_CONNECT_HIDINPUT is used. This is a lifecycle violation as > > +/// the input device is already registered. > > +// > > +// Confidence: High > > +// Copyright: (C) 2026 Gemini. GPLv2. > > + > > +virtual report > > + > > +@r@ > > +identifier probe_fn; > > +expression hdev, flags; > > +position p1, p2; > > +@@ > > + > > +probe_fn(struct hid_device *hdev, ...) { > > + <... > > + hid_hw_start@p1(hdev, flags) > > + ... > > + \(input_ff_create\|input_ff_create_memless\)@p2(...) > > + ...> > > +} > > > This seems unnecessarily costly. The pattern can be just: > > hid_hw_start@p1(hdev, flags) > ... > \(input_ff_create\|input_ff_create_memless\)@p2(...) > > Or does it matter that struct hid_device *hdev is the first parameter > of the enclosing function? > I guess not. I was trying to limit the check to what looks like HID driver probe function, but that would miss similar issues in helpers that use different order or set of arguments. Thanks. -- Dmitry ^ permalink raw reply [flat|nested] 7+ messages in thread
* re: [cocci] HID: add documentation and Coccinelle script for FF registration race [not found] ` <20260803-hid-ff-input-configured-v1-2-1dc9bbacd88c@gmail.com> 2026-08-16 18:52 ` [cocci] [PATCH 02/21] HID: add documentation and Coccinelle script for FF registration race Julia Lawall @ 2026-08-18 12:04 ` Ricardo Ribalda 2026-08-18 12:08 ` Julia Lawall 1 sibling, 1 reply; 7+ messages in thread From: Ricardo Ribalda @ 2026-08-18 12:04 UTC (permalink / raw) To: dmitry.torokhov Cc: Julia.Lawall, bentiss, cocci, corbet, hadess, jikos, lains, linux-doc, linux-input, linux-kernel, nicolas.palix, skhan Hi Dimitry Looks like media-ci is not particularly happy about this patch: https://gitlab.freedesktop.org/linux-media/users/ribalda/-/jobs/108127901 /usr/bin/spatch -D report --no-show-diff --very-quiet --cocci-file /builds/linux-media/users/ribalda/scripts/coccinelle/hid/ff_race.cocci --patch /builds/linux-media/users/ribalda --dir . -I /builds/linux-media/users/ribalda/arch/x86/include -I /builds/linux-media/users/ribalda/arch/x86/include/generated -I /builds/linux-media/users/ribalda/include -I /builds/linux-media/users/ribalda/include -I /builds/linux-media/users/ribalda/arch/x86/include/uapi -I /builds/linux-media/users/ribalda/arch/x86/include/generated/uapi -I /builds/linux-media/users/ribalda/include/uapi -I /builds/linux-media/users/ribalda/include/generated/uapi --include /builds/linux-media/users/ribalda/include/linux/compiler-version.h --include /builds/linux-media/users/ribalda/include/linux/kconfig.h --jobs 16 --chunksize 1 Position variable r.p2 on line 20 must be attached to some other token using @. coccicheck failed The following change fixes the issue for me... but you probably want to double check it, I am not proficient at cocci. diff --git a/scripts/coccinelle/hid/ff_race.cocci b/scripts/coccinelle/hid/ff_race.cocci index 479f5d1e3184..7cf84936db13 100644 --- a/scripts/coccinelle/hid/ff_race.cocci +++ b/scripts/coccinelle/hid/ff_race.cocci @@ -9,7 +9,8 @@ virtual report @r@ identifier probe_fn; -expression hdev, flags; +identifier hdev; +expression flags; position p1, p2; @@ @@ -17,7 +18,7 @@ probe_fn(struct hid_device *hdev, ...) { <... hid_hw_start@p1(hdev, flags) ... - \(input_ff_create\|input_ff_create_memless\)@p2(...) + \(input_ff_create@p2\|input_ff_create_memless@p2\)(...) ...> } Regards! ^ permalink raw reply related [flat|nested] 7+ messages in thread
* re: [cocci] HID: add documentation and Coccinelle script for FF registration race 2026-08-18 12:04 ` [cocci] " Ricardo Ribalda @ 2026-08-18 12:08 ` Julia Lawall 2026-08-27 9:39 ` Ricardo Ribalda 2026-08-27 9:45 ` Ricardo Ribalda 0 siblings, 2 replies; 7+ messages in thread From: Julia Lawall @ 2026-08-18 12:08 UTC (permalink / raw) To: Ricardo Ribalda Cc: dmitry.torokhov, Julia.Lawall, bentiss, cocci, corbet, hadess, jikos, lains, linux-doc, linux-input, linux-kernel, nicolas.palix, skhan On Tue, 18 Aug 2026, Ricardo Ribalda wrote: > Hi Dimitry > > Looks like media-ci is not particularly happy about this patch: > > https://gitlab.freedesktop.org/linux-media/users/ribalda/-/jobs/108127901 > > /usr/bin/spatch -D report --no-show-diff --very-quiet --cocci-file /builds/linux-media/users/ribalda/scripts/coccinelle/hid/ff_race.cocci --patch /builds/linux-media/users/ribalda --dir . -I /builds/linux-media/users/ribalda/arch/x86/include -I /builds/linux-media/users/ribalda/arch/x86/include/generated -I /builds/linux-media/users/ribalda/include -I /builds/linux-media/users/ribalda/include -I /builds/linux-media/users/ribalda/arch/x86/include/uapi -I /builds/linux-media/users/ribalda/arch/x86/include/generated/uapi -I /builds/linux-media/users/ribalda/include/uapi -I /builds/linux-media/users/ribalda/include/generated/uapi --include /builds/linux-media/users/ribalda/include/linux/compiler-version.h --include /builds/linux-media/users/ribalda/include/linux/kconfig.h --jobs 16 --chunksize 1 > Position variable r.p2 on line 20 must be attached to some other token using @. > coccicheck failed > > > The following change fixes the issue for me... but you probably want to double > check it, I am not proficient at cocci. I would also like to improve this, as suggested in a previous mail. Could it be detached from the documentation change? Then I can take this part and fix it up. julia > > diff --git a/scripts/coccinelle/hid/ff_race.cocci b/scripts/coccinelle/hid/ff_race.cocci > index 479f5d1e3184..7cf84936db13 100644 > --- a/scripts/coccinelle/hid/ff_race.cocci > +++ b/scripts/coccinelle/hid/ff_race.cocci > @@ -9,7 +9,8 @@ virtual report > > @r@ > identifier probe_fn; > -expression hdev, flags; > +identifier hdev; > +expression flags; > position p1, p2; > @@ > > @@ -17,7 +18,7 @@ probe_fn(struct hid_device *hdev, ...) { > <... > hid_hw_start@p1(hdev, flags) > ... > - \(input_ff_create\|input_ff_create_memless\)@p2(...) > + \(input_ff_create@p2\|input_ff_create_memless@p2\)(...) > ...> > } > > > Regards! > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [cocci] HID: add documentation and Coccinelle script for FF registration race 2026-08-18 12:08 ` Julia Lawall @ 2026-08-27 9:39 ` Ricardo Ribalda 2026-08-27 9:45 ` Ricardo Ribalda 1 sibling, 0 replies; 7+ messages in thread From: Ricardo Ribalda @ 2026-08-27 9:39 UTC (permalink / raw) To: Julia Lawall Cc: dmitry.torokhov, bentiss, cocci, corbet, hadess, jikos, lains, linux-doc, linux-input, linux-kernel, nicolas.palix, skhan [-- Attachment #1: Type: text/plain, Size: 2588 bytes --] Hi, Just a heads-up that this this patch has landed in Linus tree, not only in -next: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/scripts/coccinelle/hid/ff_race.cocci?id=225c30812857f47cb42bfd945a15f448f58e82cc We should fix it before -rc1 is tagged Regards! On Tue, 18 Aug 2026 at 14:08, Julia Lawall <julia.lawall@inria.fr> wrote: > > > On Tue, 18 Aug 2026, Ricardo Ribalda wrote: > > > Hi Dimitry > > > > Looks like media-ci is not particularly happy about this patch: > > > > > https://gitlab.freedesktop.org/linux-media/users/ribalda/-/jobs/108127901 > > > > /usr/bin/spatch -D report --no-show-diff --very-quiet --cocci-file > /builds/linux-media/users/ribalda/scripts/coccinelle/hid/ff_race.cocci > --patch /builds/linux-media/users/ribalda --dir . -I > /builds/linux-media/users/ribalda/arch/x86/include -I > /builds/linux-media/users/ribalda/arch/x86/include/generated -I > /builds/linux-media/users/ribalda/include -I > /builds/linux-media/users/ribalda/include -I > /builds/linux-media/users/ribalda/arch/x86/include/uapi -I > /builds/linux-media/users/ribalda/arch/x86/include/generated/uapi -I > /builds/linux-media/users/ribalda/include/uapi -I > /builds/linux-media/users/ribalda/include/generated/uapi --include > /builds/linux-media/users/ribalda/include/linux/compiler-version.h > --include /builds/linux-media/users/ribalda/include/linux/kconfig.h --jobs > 16 --chunksize 1 > > Position variable r.p2 on line 20 must be attached to some other token > using @. > > coccicheck failed > > > > > > The following change fixes the issue for me... but you probably want to > double > > check it, I am not proficient at cocci. > > I would also like to improve this, as suggested in a previous mail. > Could it be detached from the documentation change? Then I can take this > part and fix it up. > > julia > > > > > diff --git a/scripts/coccinelle/hid/ff_race.cocci > b/scripts/coccinelle/hid/ff_race.cocci > > index 479f5d1e3184..7cf84936db13 100644 > > --- a/scripts/coccinelle/hid/ff_race.cocci > > +++ b/scripts/coccinelle/hid/ff_race.cocci > > @@ -9,7 +9,8 @@ virtual report > > > > @r@ > > identifier probe_fn; > > -expression hdev, flags; > > +identifier hdev; > > +expression flags; > > position p1, p2; > > @@ > > > > @@ -17,7 +18,7 @@ probe_fn(struct hid_device *hdev, ...) { > > <... > > hid_hw_start@p1(hdev, flags) > > ... > > - \(input_ff_create\|input_ff_create_memless\)@p2(...) > > + \(input_ff_create@p2\|input_ff_create_memless@p2\)(...) > > ...> > > } > > > > > > Regards! > > > -- Ricardo Ribalda [-- Attachment #2: Type: text/html, Size: 3622 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [cocci] HID: add documentation and Coccinelle script for FF registration race 2026-08-18 12:08 ` Julia Lawall 2026-08-27 9:39 ` Ricardo Ribalda @ 2026-08-27 9:45 ` Ricardo Ribalda 1 sibling, 0 replies; 7+ messages in thread From: Ricardo Ribalda @ 2026-08-27 9:45 UTC (permalink / raw) To: Julia Lawall Cc: dmitry.torokhov, bentiss, cocci, corbet, hadess, jikos, lains, linux-doc, linux-input, linux-kernel, nicolas.palix, skhan [In plaintext this time, sorry for the previous HTML email[ Hi, Just a heads-up that this this patch has landed in Linus tree, not only in -next: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/scripts/coccinelle/hid/ff_race.cocci?id=225c30812857f47cb42bfd945a15f448f58e82cc We should fix it before -rc1 is tagged Regards! On Tue, 18 Aug 2026 at 14:08, Julia Lawall <julia.lawall@inria.fr> wrote: > > > > On Tue, 18 Aug 2026, Ricardo Ribalda wrote: > > > Hi Dimitry > > > > Looks like media-ci is not particularly happy about this patch: > > > > https://gitlab.freedesktop.org/linux-media/users/ribalda/-/jobs/108127901 > > > > /usr/bin/spatch -D report --no-show-diff --very-quiet --cocci-file /builds/linux-media/users/ribalda/scripts/coccinelle/hid/ff_race.cocci --patch /builds/linux-media/users/ribalda --dir . -I /builds/linux-media/users/ribalda/arch/x86/include -I /builds/linux-media/users/ribalda/arch/x86/include/generated -I /builds/linux-media/users/ribalda/include -I /builds/linux-media/users/ribalda/include -I /builds/linux-media/users/ribalda/arch/x86/include/uapi -I /builds/linux-media/users/ribalda/arch/x86/include/generated/uapi -I /builds/linux-media/users/ribalda/include/uapi -I /builds/linux-media/users/ribalda/include/generated/uapi --include /builds/linux-media/users/ribalda/include/linux/compiler-version.h --include /builds/linux-media/users/ribalda/include/linux/kconfig.h --jobs 16 --chunksize 1 > > Position variable r.p2 on line 20 must be attached to some other token using @. > > coccicheck failed > > > > > > The following change fixes the issue for me... but you probably want to double > > check it, I am not proficient at cocci. > > I would also like to improve this, as suggested in a previous mail. > Could it be detached from the documentation change? Then I can take this > part and fix it up. > > julia > > > > > diff --git a/scripts/coccinelle/hid/ff_race.cocci b/scripts/coccinelle/hid/ff_race.cocci > > index 479f5d1e3184..7cf84936db13 100644 > > --- a/scripts/coccinelle/hid/ff_race.cocci > > +++ b/scripts/coccinelle/hid/ff_race.cocci > > @@ -9,7 +9,8 @@ virtual report > > > > @r@ > > identifier probe_fn; > > -expression hdev, flags; > > +identifier hdev; > > +expression flags; > > position p1, p2; > > @@ > > > > @@ -17,7 +18,7 @@ probe_fn(struct hid_device *hdev, ...) { > > <... > > hid_hw_start@p1(hdev, flags) > > ... > > - \(input_ff_create\|input_ff_create_memless\)@p2(...) > > + \(input_ff_create@p2\|input_ff_create_memless@p2\)(...) > > ...> > > } > > > > > > Regards! > > -- Ricardo Ribalda ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-08-27 12:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260803-hid-ff-input-configured-v1-0-1dc9bbacd88c@gmail.com>
2026-08-14 12:47 ` [cocci] [PATCH 00/21] HID: fix racy force feedback initialization via .input_configured() Jiri Kosina
[not found] ` <20260803-hid-ff-input-configured-v1-2-1dc9bbacd88c@gmail.com>
2026-08-16 18:52 ` [cocci] [PATCH 02/21] HID: add documentation and Coccinelle script for FF registration race Julia Lawall
2026-08-17 4:03 ` Dmitry Torokhov
2026-08-18 12:04 ` [cocci] " Ricardo Ribalda
2026-08-18 12:08 ` Julia Lawall
2026-08-27 9:39 ` Ricardo Ribalda
2026-08-27 9:45 ` Ricardo Ribalda
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).