cocci.systeme.lip6.fr archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Coccinelle <cocci@systeme.lip6.fr>
Subject: [Cocci] Checking redundant variable initialisations with SmPL?
Date: Thu, 20 Jun 2019 14:30:12 +0200	[thread overview]
Message-ID: <f1bb347b-7318-f69f-ad86-bd633c72b375@web.de> (raw)

Hello,

A patch on a topic like “[next] lkdtm: remove redundant initialization of ret”
caught also my software development attention.
https://lkml.org/lkml/2019/6/14/265
https://lore.kernel.org/patchwork/patch/1088971/
https://lore.kernel.org/lkml/20190614094311.24024-1-colin.king@canonical.com/


I hoped that the following script for the semantic patch language can point
such an update candidate also out.

@display@
binary operator bo;
expression e1, e2, e3;
identifier var, work;
statement is, es;
type t;
@@
*t var = e1;
 ... when != if (var bo e2) is else es
*var =
(      work(...)
|      e3
)


elfring@Sonne:~/Projekte/Linux/next-patched> spatch ~/Projekte/Coccinelle/janitor/show_questionable_variable_initialisation1.cocci drivers/misc/lkdtm/core.c
…
exn while in timeout_function
Fatal error: exception Coccinelle_modules.Common.Impossible(56)


How do you think about the software situation?

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

             reply	other threads:[~2019-06-20 12:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-20 12:30 Markus Elfring [this message]
2019-06-21 20:52 ` [Cocci] Checking redundant variable initialisations with SmPL? Julia Lawall
2019-06-22 13:15   ` Markus Elfring
2019-06-22 13:19     ` Julia Lawall
2019-06-22 13:35       ` Markus Elfring
2019-06-22 13:58         ` Julia Lawall
2019-06-22 14:16           ` Markus Elfring
2019-06-23  7:48           ` Markus Elfring
2019-06-23 12:48           ` Markus Elfring
2019-06-23 12:48           ` Markus Elfring
2019-06-23 12:55             ` Julia Lawall
2019-06-23 13:05               ` Markus Elfring
2019-06-23 13:13                 ` Julia Lawall
2019-06-23 14:17                   ` Markus Elfring
2019-06-23 13:05               ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1bb347b-7318-f69f-ad86-bd633c72b375@web.de \
    --to=markus.elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).