[Cocci] __init macro and Coccinelle

[Cocci] __init macro and Coccinelle

[Gustavo A. R. Silva]

Hello everybody,

I have the following script:

@r@
identifier f_init;
position p;
@@


* __init f_init at p(...)

I want to spot __init functions, but it doesn't seem to work. I get a 
parse error around the __init macro:

around = '__init',
   whole content = * __init f_init at p(...)

I wonder if there is a way to work around that issue?

Thank you
-- 
Gustavo A. R. Silva

[Cocci] __init macro and Coccinelle

[Julia Lawall]

On Tue, 15 Aug 2017, Gustavo A. R. Silva wrote:

> Hello everybody,
>
> I have the following script:
>
> @r@
> identifier f_init;
> position p;
> @@
>
>
> * __init f_init at p(...)
>
> I want to spot __init functions, but it doesn't seem to work. I get a parse
> error around the __init macro:
>
> around = '__init',
>   whole content = * __init f_init at p(...)
>
> I wonder if there is a way to work around that issue?

If you want to match a function, you have to put something that will match
the whole function, not just the top part.  So it would be

__init f(...) { ... }

julia

[Cocci] __init macro and Coccinelle

[Gustavo A. R. Silva]

On 08/15/2017 03:24 PM, Julia Lawall wrote:
>
>
> On Tue, 15 Aug 2017, Gustavo A. R. Silva wrote:
>
>> Hello everybody,
>>
>> I have the following script:
>>
>> @r@
>> identifier f_init;
>> position p;
>> @@
>>
>>
>> * __init f_init at p(...)
>>
>> I want to spot __init functions, but it doesn't seem to work. I get a parse
>> error around the __init macro:
>>
>> around = '__init',
>>   whole content = * __init f_init at p(...)
>>
>> I wonder if there is a way to work around that issue?
>
> If you want to match a function, you have to put something that will match
> the whole function, not just the top part.  So it would be
>
> __init f(...) { ... }
>

That worked, thanks. :)

But now if I combine it in the following way:

@r1@
identifier s_type;
identifier f_init;
identifier s;
position p;
type T;
@@

(
* struct s_type s = {.init = f_init at p};
|
* __init f_init at p(...) { ... }
)

I get the same error parse error:

   around = '__init',
   whole content = __init f_init at p(...) { ... }


-- 
Gustavo A. R. Silva

[Cocci] __init macro and Coccinelle

[Julia Lawall]

On Tue, 15 Aug 2017, Gustavo A. R. Silva wrote:

>
>
> On 08/15/2017 03:24 PM, Julia Lawall wrote:
> >
> >
> > On Tue, 15 Aug 2017, Gustavo A. R. Silva wrote:
> >
> > > Hello everybody,
> > >
> > > I have the following script:
> > >
> > > @r@
> > > identifier f_init;
> > > position p;
> > > @@
> > >
> > >
> > > * __init f_init at p(...)
> > >
> > > I want to spot __init functions, but it doesn't seem to work. I get a
> > > parse
> > > error around the __init macro:
> > >
> > > around = '__init',
> > >   whole content = * __init f_init at p(...)
> > >
> > > I wonder if there is a way to work around that issue?
> >
> > If you want to match a function, you have to put something that will match
> > the whole function, not just the top part.  So it would be
> >
> > __init f(...) { ... }
> >
>
> That worked, thanks. :)
>
> But now if I combine it in the following way:
>
> @r1@
> identifier s_type;
> identifier f_init;
> identifier s;
> position p;
> type T;
> @@
>
> (
> * struct s_type s = {.init = f_init at p};
> |
> * __init f_init at p(...) { ... }
> )
>
> I get the same error parse error:
>
>   around = '__init',
>   whole content = __init f_init at p(...) { ... }

Don't do it :)

There are some parsing hacks to differentiate function calls from function
definitions.  Adding the disjunction defeats them.  Just make two separate
rules.

julia

[Cocci] __init macro and Coccinelle

[Gustavo A. R. Silva]

On 08/15/2017 03:42 PM, Julia Lawall wrote:
>
>
> On Tue, 15 Aug 2017, Gustavo A. R. Silva wrote:
>
>>
>>
>> On 08/15/2017 03:24 PM, Julia Lawall wrote:
>>>
>>>
>>> On Tue, 15 Aug 2017, Gustavo A. R. Silva wrote:
>>>
>>>> Hello everybody,
>>>>
>>>> I have the following script:
>>>>
>>>> @r@
>>>> identifier f_init;
>>>> position p;
>>>> @@
>>>>
>>>>
>>>> * __init f_init at p(...)
>>>>
>>>> I want to spot __init functions, but it doesn't seem to work. I get a
>>>> parse
>>>> error around the __init macro:
>>>>
>>>> around = '__init',
>>>>   whole content = * __init f_init at p(...)
>>>>
>>>> I wonder if there is a way to work around that issue?
>>>
>>> If you want to match a function, you have to put something that will match
>>> the whole function, not just the top part.  So it would be
>>>
>>> __init f(...) { ... }
>>>
>>
>> That worked, thanks. :)
>>
>> But now if I combine it in the following way:
>>
>> @r1@
>> identifier s_type;
>> identifier f_init;
>> identifier s;
>> position p;
>> type T;
>> @@
>>
>> (
>> * struct s_type s = {.init = f_init at p};
>> |
>> * __init f_init at p(...) { ... }
>> )
>>
>> I get the same error parse error:
>>
>>   around = '__init',
>>   whole content = __init f_init at p(...) { ... }
>
> Don't do it :)
>
> There are some parsing hacks to differentiate function calls from function
> definitions.  Adding the disjunction defeats them.  Just make two separate
> rules.
>

Oh OK, I got it. I'll do that.

Thank you, Julia. :)

-- 
Gustavo A. R. Silva