* Re: [RFC][PATCH 0/9] Make containers kernel objects [not found] ` <149547014649.10599.12025037906646164347.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org> @ 2017-05-22 16:53 ` James Bottomley [not found] ` <1495472039.2757.19.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org> ` (3 more replies) 0 siblings, 4 replies; 25+ messages in thread From: James Bottomley @ 2017-05-22 16:53 UTC (permalink / raw) To: David Howells, trondmy-7I+n7zu2hftEKMMhf/gKZA Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, jlayton-H+wXaHxf7aLQT0dZR+AlfA, Linux Containers, linux-kernel-u79uwXL29TY76Z2rM5mHXA, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, cgroups-u79uwXL29TY76Z2rM5mHXA, ebiederm-aS9lmoZGLiVWk0Htik3J/w [Added missing cc to containers list] On Mon, 2017-05-22 at 17:22 +0100, David Howells wrote: > Here are a set of patches to define a container object for the kernel > and to provide some methods to create and manipulate them. > > The reason I think this is necessary is that the kernel has no idea > how to direct upcalls to what userspace considers to be a container - > current Linux practice appears to make a "container" just an > arbitrarily chosen junction of namespaces, control groups and files, > which may be changed individually within the "container". This sounds like a step in the wrong direction: the strength of the current container interfaces in Linux is that people who set up containers don't have to agree what they look like. So I can set up a user namespace without a mount namespace or an architecture emulation container with only a mount namespace. But ignoring my fun foibles with containers and to give a concrete example in terms of a popular orchestration system: in kubernetes, where certain namespaces are shared across pods, do you imagine the kernel's view of the "container" to be the pod or what kubernetes thinks of as the container? This is important, because half the examples you give below are network related and usually pods share a network namespace. > The kernel upcall mechanism then needs to decide which set of > namespaces, etc., it must exec the appropriate upcall program. > Examples of this include: > > (1) The DNS resolver. The DNS cache in the kernel should probably > be per-network namespace, but in userspace the program, its > libraries and its config data are associated with a mount tree and a > user namespace and it gets run in a particular pid namespace. All persistent (written to fs data) has to be mount ns associated; there are no ifs, ands and buts to that. I agree this implies that if you want to run a separate network namespace, you either take DNS from the parent (a lot of containers do) or you set up a daemon to run within the mount namespace. I agree the latter is a slightly fiddly operation you have to get right, but that's why we have orchestration systems. What is it we could do with the above that we cannot do today? > (2) NFS ID mapper. The NFS ID mapping cache should also probably be > per-network namespace. I think this is a view but not the only one: Right at the moment, NFS ID mapping is used as the one of the ways we can get the user namespace ID mapping writes to file problems fixed ... that makes it a property of the mount namespace for a lot of containers. There are many other instances where they do exactly as you say, but what I'm saying is that we don't want to lose the flexibility we currently have. > (3) nfsdcltrack. A way for NFSD to access stable storage for > tracking of persistent state. Again, network-namespace dependent, > but also perhaps mount-namespace dependent. So again, given we can set this up to work today, this sounds like more a restriction that will bite us than an enhancement that gives us extra features. > (4) General request-key upcalls. Not particularly namespace > dependent, apart from keyrings being somewhat governed by the user > namespace and the upcall being configured by the mount namespace. All mount namespaces have an owning user namespace, so the data relations are already there in the kernel, is the problem simply finding them? > These patches are built on top of the mount context patchset so that > namespaces can be properly propagated over submounts/automounts. I'll stop here ... you get the idea that I think this is imposing a set of restrictions that will come back to bite us later. If this is just for the sake of figuring out how to get keyring upcalls to work, then I'm sure we can come up with something. James ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <1495472039.2757.19.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>]
* Re: [RFC][PATCH 0/9] Make containers kernel objects [not found] ` <1495472039.2757.19.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org> @ 2017-05-22 17:14 ` Aleksa Sarai 2017-05-22 17:27 ` Jessica Frazelle ` (3 subsequent siblings) 4 siblings, 0 replies; 25+ messages in thread From: Aleksa Sarai @ 2017-05-22 17:14 UTC (permalink / raw) To: James Bottomley, David Howells, trondmy-7I+n7zu2hftEKMMhf/gKZA Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, jlayton-H+wXaHxf7aLQT0dZR+AlfA, Linux Containers, linux-kernel-u79uwXL29TY76Z2rM5mHXA, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, cgroups-u79uwXL29TY76Z2rM5mHXA, ebiederm-aS9lmoZGLiVWk0Htik3J/w >> The reason I think this is necessary is that the kernel has no idea >> how to direct upcalls to what userspace considers to be a container - >> current Linux practice appears to make a "container" just an >> arbitrarily chosen junction of namespaces, control groups and files, >> which may be changed individually within the "container". Just want to point out that if the kernel APIs for containers massively change, then the OCI will have to completely rework how we describe containers (and so will all existing runtimes). Not to mention that while I don't like how hard it is (from a runtime perspective) to actually set up a container securely, there are undoubtedly benefits to having namespaces split out. The network namespace being separate means that in certain contexts you actually don't want to create a new network namespace when creating a container. I had some ideas about how you could implement bridging in userspace (as an unprivileged user, for rootless containers) but if you can't join namespaces individually then such a setup is not practically possible. -- Aleksa Sarai Software Engineer (Containers) SUSE Linux GmbH https://www.cyphar.com/ ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [RFC][PATCH 0/9] Make containers kernel objects [not found] ` <1495472039.2757.19.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org> 2017-05-22 17:14 ` Aleksa Sarai @ 2017-05-22 17:27 ` Jessica Frazelle 2017-05-22 18:34 ` Jeff Layton ` (2 subsequent siblings) 4 siblings, 0 replies; 25+ messages in thread From: Jessica Frazelle @ 2017-05-22 17:27 UTC (permalink / raw) To: James Bottomley Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, jlayton-H+wXaHxf7aLQT0dZR+AlfA, Linux Containers, linux-kernel-u79uwXL29TY76Z2rM5mHXA, David Howells, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, cgroups-u79uwXL29TY76Z2rM5mHXA, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, trondmy-7I+n7zu2hftEKMMhf/gKZA, ebiederm-aS9lmoZGLiVWk0Htik3J/w I had replied but not to the thread with the containers mailing list. See https://marc.info/?l=linux-cgroups&m=149547317006676&w=2 On Mon, May 22, 2017 at 5:53 PM, James Bottomley <James.Bottomley-JuX6DAaQMKPCXq6kfMZ53/egYHeGw8Jk@public.gmane.org> wrote: > [Added missing cc to containers list] > On Mon, 2017-05-22 at 17:22 +0100, David Howells wrote: >> Here are a set of patches to define a container object for the kernel >> and to provide some methods to create and manipulate them. >> >> The reason I think this is necessary is that the kernel has no idea >> how to direct upcalls to what userspace considers to be a container - >> current Linux practice appears to make a "container" just an >> arbitrarily chosen junction of namespaces, control groups and files, >> which may be changed individually within the "container". > > This sounds like a step in the wrong direction: the strength of the > current container interfaces in Linux is that people who set up > containers don't have to agree what they look like. So I can set up a > user namespace without a mount namespace or an architecture emulation > container with only a mount namespace. > > But ignoring my fun foibles with containers and to give a concrete > example in terms of a popular orchestration system: in kubernetes, > where certain namespaces are shared across pods, do you imagine the > kernel's view of the "container" to be the pod or what kubernetes > thinks of as the container? This is important, because half the > examples you give below are network related and usually pods share a > network namespace. I am glad you pointed this out because I was trying to make the same point, various definitions of containers differ and who is to say whether the various container runtimes (runc, rkt, systemd-nspawn) or consumers of containers (kubernetes) won't modify their definition in the future. How will this scale as new LSMs like Landlock or new namespaces are added in the future will they be included in the container kernel object as well... Seems like a lot more maintenance for something that is really just making the keyring namespace-aware... unless there are other things I missed. > >> The kernel upcall mechanism then needs to decide which set of >> namespaces, etc., it must exec the appropriate upcall program. >> Examples of this include: >> >> (1) The DNS resolver. The DNS cache in the kernel should probably >> be per-network namespace, but in userspace the program, its >> libraries and its config data are associated with a mount tree and a >> user namespace and it gets run in a particular pid namespace. > > All persistent (written to fs data) has to be mount ns associated; > there are no ifs, ands and buts to that. I agree this implies that if > you want to run a separate network namespace, you either take DNS from > the parent (a lot of containers do) or you set up a daemon to run > within the mount namespace. I agree the latter is a slightly fiddly > operation you have to get right, but that's why we have orchestration > systems. > > What is it we could do with the above that we cannot do today? > >> (2) NFS ID mapper. The NFS ID mapping cache should also probably be >> per-network namespace. > > I think this is a view but not the only one: Right at the moment, NFS > ID mapping is used as the one of the ways we can get the user namespace > ID mapping writes to file problems fixed ... that makes it a property > of the mount namespace for a lot of containers. There are many other > instances where they do exactly as you say, but what I'm saying is that > we don't want to lose the flexibility we currently have. > >> (3) nfsdcltrack. A way for NFSD to access stable storage for >> tracking of persistent state. Again, network-namespace dependent, >> but also perhaps mount-namespace dependent. > > So again, given we can set this up to work today, this sounds like more > a restriction that will bite us than an enhancement that gives us extra > features. > >> (4) General request-key upcalls. Not particularly namespace >> dependent, apart from keyrings being somewhat governed by the user >> namespace and the upcall being configured by the mount namespace. > > All mount namespaces have an owning user namespace, so the data > relations are already there in the kernel, is the problem simply > finding them? > >> These patches are built on top of the mount context patchset so that >> namespaces can be properly propagated over submounts/automounts. > > I'll stop here ... you get the idea that I think this is imposing a set > of restrictions that will come back to bite us later. If this is just > for the sake of figuring out how to get keyring upcalls to work, then > I'm sure we can come up with something. > > James > > -- > To unsubscribe from this list: send the line "unsubscribe cgroups" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jessie Frazelle 4096R / D4C4 DD60 0D66 F65A 8EFC 511E 18F3 685C 0022 BFF3 pgp.mit.edu ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [RFC][PATCH 0/9] Make containers kernel objects [not found] ` <1495472039.2757.19.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org> 2017-05-22 17:14 ` Aleksa Sarai 2017-05-22 17:27 ` Jessica Frazelle @ 2017-05-22 18:34 ` Jeff Layton 2017-05-23 9:38 ` Ian Kent 2017-05-23 13:52 ` David Howells 4 siblings, 0 replies; 25+ messages in thread From: Jeff Layton @ 2017-05-22 18:34 UTC (permalink / raw) To: James Bottomley, David Howells, trondmy-7I+n7zu2hftEKMMhf/gKZA Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, Linux Containers, linux-kernel-u79uwXL29TY76Z2rM5mHXA, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, cgroups-u79uwXL29TY76Z2rM5mHXA, ebiederm-aS9lmoZGLiVWk0Htik3J/w On Mon, 2017-05-22 at 09:53 -0700, James Bottomley wrote: > [Added missing cc to containers list] > On Mon, 2017-05-22 at 17:22 +0100, David Howells wrote: > > Here are a set of patches to define a container object for the kernel > > and to provide some methods to create and manipulate them. > > > > The reason I think this is necessary is that the kernel has no idea > > how to direct upcalls to what userspace considers to be a container - > > current Linux practice appears to make a "container" just an > > arbitrarily chosen junction of namespaces, control groups and files, > > which may be changed individually within the "container". > > This sounds like a step in the wrong direction: the strength of the > current container interfaces in Linux is that people who set up > containers don't have to agree what they look like. So I can set up a > user namespace without a mount namespace or an architecture emulation > container with only a mount namespace. > Does this really mandate what they look like though? AFAICT, you can still spawn disconnected namespaces to your heart's content. What this does is provide a container for several different namespaces so that the kernel can actually be aware of the association between them. The way you populate the different namespaces looks to be pretty flexible. > But ignoring my fun foibles with containers and to give a concrete > example in terms of a popular orchestration system: in kubernetes, > where certain namespaces are shared across pods, do you imagine the > kernel's view of the "container" to be the pod or what kubernetes > thinks of as the container? This is important, because half the > examples you give below are network related and usually pods share a > network namespace. > > > The kernel upcall mechanism then needs to decide which set of > > namespaces, etc., it must exec the appropriate upcall program. > > Examples of this include: > > > > (1) The DNS resolver. The DNS cache in the kernel should probably > > be per-network namespace, but in userspace the program, its > > libraries and its config data are associated with a mount tree and a > > user namespace and it gets run in a particular pid namespace. > > All persistent (written to fs data) has to be mount ns associated; > there are no ifs, ands and buts to that. I agree this implies that if > you want to run a separate network namespace, you either take DNS from > the parent (a lot of containers do) or you set up a daemon to run > within the mount namespace. I agree the latter is a slightly fiddly > operation you have to get right, but that's why we have orchestration > systems. > > What is it we could do with the above that we cannot do today? > Spawn a task directly from the kernel, already set up in the correct namespaces, a'la call_usermodehelper. So far there is no way to do that, and it is something we'd very much desire. Ian Kent has made several passes at it recently. > > (2) NFS ID mapper. The NFS ID mapping cache should also probably be > > per-network namespace. > > I think this is a view but not the only one: Right at the moment, NFS > ID mapping is used as the one of the ways we can get the user namespace > ID mapping writes to file problems fixed ... that makes it a property > of the mount namespace for a lot of containers. There are many other > instances where they do exactly as you say, but what I'm saying is that > we don't want to lose the flexibility we currently have. > > > (3) nfsdcltrack. A way for NFSD to access stable storage for > > tracking of persistent state. Again, network-namespace dependent, > > but also perhaps mount-namespace dependent. Definitely mount-namespace dependent. > > So again, given we can set this up to work today, this sounds like more > a restriction that will bite us than an enhancement that gives us extra > features. > How do you set this up to work today? AFAIK, if you want to run knfsd in a container today, you're out of luck for any non-trivial configuration. The main reason is that most of knfsd is namespace-ized in the network namespace, but there is no clear way to associate that with a mount namespace, which is what we need to do this properly inside a container. I think David's patches would get us there. > > (4) General request-key upcalls. Not particularly namespace > > dependent, apart from keyrings being somewhat governed by the user > > namespace and the upcall being configured by the mount namespace. > > All mount namespaces have an owning user namespace, so the data > relations are already there in the kernel, is the problem simply > finding them? > > > These patches are built on top of the mount context patchset so that > > namespaces can be properly propagated over submounts/automounts. > > I'll stop here ... you get the idea that I think this is imposing a set > of restrictions that will come back to bite us later. If this is just > for the sake of figuring out how to get keyring upcalls to work, then > I'm sure we can come up with something. > -- Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [RFC][PATCH 0/9] Make containers kernel objects [not found] ` <1495472039.2757.19.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org> ` (2 preceding siblings ...) 2017-05-22 18:34 ` Jeff Layton @ 2017-05-23 9:38 ` Ian Kent 2017-05-23 13:52 ` David Howells 4 siblings, 0 replies; 25+ messages in thread From: Ian Kent @ 2017-05-23 9:38 UTC (permalink / raw) To: James Bottomley, David Howells, trondmy-7I+n7zu2hftEKMMhf/gKZA Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, jlayton-H+wXaHxf7aLQT0dZR+AlfA, Linux Containers, linux-kernel-u79uwXL29TY76Z2rM5mHXA, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, cgroups-u79uwXL29TY76Z2rM5mHXA, ebiederm-aS9lmoZGLiVWk0Htik3J/w On Mon, 2017-05-22 at 09:53 -0700, James Bottomley wrote: > [Added missing cc to containers list] > On Mon, 2017-05-22 at 17:22 +0100, David Howells wrote: > > Here are a set of patches to define a container object for the kernel > > and to provide some methods to create and manipulate them. > > > > The reason I think this is necessary is that the kernel has no idea > > how to direct upcalls to what userspace considers to be a container - > > current Linux practice appears to make a "container" just an > > arbitrarily chosen junction of namespaces, control groups and files, > > which may be changed individually within the "container". > > This sounds like a step in the wrong direction: the strength of the > current container interfaces in Linux is that people who set up > containers don't have to agree what they look like. So I can set up a > user namespace without a mount namespace or an architecture emulation > container with only a mount namespace. > > But ignoring my fun foibles with containers and to give a concrete > example in terms of a popular orchestration system: in kubernetes, > where certain namespaces are shared across pods, do you imagine the > kernel's view of the "container" to be the pod or what kubernetes > thinks of as the container? This is important, because half the > examples you give below are network related and usually pods share a > network namespace. > > > The kernel upcall mechanism then needs to decide which set of > > namespaces, etc., it must exec the appropriate upcall program. > > Examples of this include: > > > > (1) The DNS resolver. The DNS cache in the kernel should probably > > be per-network namespace, but in userspace the program, its > > libraries and its config data are associated with a mount tree and a > > user namespace and it gets run in a particular pid namespace. > > All persistent (written to fs data) has to be mount ns associated; > there are no ifs, ands and buts to that. I agree this implies that if > you want to run a separate network namespace, you either take DNS from > the parent (a lot of containers do) or you set up a daemon to run > within the mount namespace. I agree the latter is a slightly fiddly > operation you have to get right, but that's why we have orchestration > systems. > > What is it we could do with the above that we cannot do today? > > > (2) NFS ID mapper. The NFS ID mapping cache should also probably be > > per-network namespace. > > I think this is a view but not the only one: Right at the moment, NFS > ID mapping is used as the one of the ways we can get the user namespace > ID mapping writes to file problems fixed ... that makes it a property > of the mount namespace for a lot of containers. There are many other > instances where they do exactly as you say, but what I'm saying is that > we don't want to lose the flexibility we currently have. > > > (3) nfsdcltrack. A way for NFSD to access stable storage for > > tracking of persistent state. Again, network-namespace dependent, > > but also perhaps mount-namespace dependent. > > So again, given we can set this up to work today, this sounds like more > a restriction that will bite us than an enhancement that gives us extra > features. > > > (4) General request-key upcalls. Not particularly namespace > > dependent, apart from keyrings being somewhat governed by the user > > namespace and the upcall being configured by the mount namespace. > > All mount namespaces have an owning user namespace, so the data > relations are already there in the kernel, is the problem simply > finding them? > > > These patches are built on top of the mount context patchset so that > > namespaces can be properly propagated over submounts/automounts. > > I'll stop here ... you get the idea that I think this is imposing a set > of restrictions that will come back to bite us later. If this is just > for the sake of figuring out how to get keyring upcalls to work, then > I'm sure we can come up with something. You talk about a number of things I'm simply not aware of so I can't answer your questions. But your points do sound like issues that need to be covered. I think you mentioned user space used NFS ID mapper works fine. I wonder, could you give more detail on that please. Perhaps nsenter(1) is being used, I tried that as a possible usermode helper solution and it probably did "work" in the sense of in container execution but no-one liked it, it seems kernel folk expect to do things, well, in kernel. Not only that there were other problems, probably request key sub system not being namespace aware, or id caching within nfs or somewhere else, and there was a question of not being able to cater for user namespace usage. Anyway I do have a different view from my own experiences. First there are a number of subsystems involved in creating a process from within a container that has the container environment and, AFAICS (from the usermode helper experience), it needs to be done from outside the container. For example sub systems that need to be handled properly are the namespaces (and the pid namespace in particular is tricky), credentials and cgroups, to name those that come immediately to mind. I just couldn't get all that right after a number of tries. From this the problem that occurred to me is that we have a comprehensive namespace implementation within the kernel but no container implementation to help the binding together of the various sub systems for container use cases in a way that satisfies container (or a process within an existing container) creation. The risk is that, as time passes, problems like usermode helper will be solved in different places in different ways, not necessarily satisfactorily and potentially hard to find when there are bugs and even harder to maintain than the implementation here. At least the interface here provides a "goto" place to define and maintain the procedures required to do these things. Yes, it would require change but change happens and the first pass may not be on a par with what is currently done from a simplicity POV. But why not see it as solving a kernel development problem and focus on what needs to be done to make it on par with (and perhaps simpler) to cover the current usage .... Eric Biederman's comment is attractive indeed but I don't see how that solves problem of having a containers sub system implementation which I think is needed, if for no other reason than as a definition of correct usage and localization of that usage for easier (right, nothing is easy) bug resolution. Ian _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/containers ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [RFC][PATCH 0/9] Make containers kernel objects [not found] ` <1495472039.2757.19.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org> ` (3 preceding siblings ...) 2017-05-23 9:38 ` Ian Kent @ 2017-05-23 13:52 ` David Howells 4 siblings, 0 replies; 25+ messages in thread From: David Howells @ 2017-05-23 13:52 UTC (permalink / raw) To: James Bottomley Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, jlayton-H+wXaHxf7aLQT0dZR+AlfA, Linux Containers, linux-kernel-u79uwXL29TY76Z2rM5mHXA, dhowells-H+wXaHxf7aLQT0dZR+AlfA, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, cgroups-u79uwXL29TY76Z2rM5mHXA, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, trondmy-7I+n7zu2hftEKMMhf/gKZA, ebiederm-aS9lmoZGLiVWk0Htik3J/w James Bottomley <James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org> wrote: > This sounds like a step in the wrong direction: the strength of the > current container interfaces in Linux is that people who set up > containers don't have to agree what they look like. It may be a strength, but it is also a problem. > So I can set up a user namespace without a mount namespace or an > architecture emulation container with only a mount namespace. (I presume you mean with only the mount namespace separate) Yep. You can do that with this too. > But ignoring my fun foibles with containers and to give a concrete > example in terms of a popular orchestration system: in kubernetes, > where certain namespaces are shared across pods, do you imagine the > kernel's view of the "container" to be the pod or what kubernetes > thinks of as the container? Why not both? If the net_ns is created in the pod container, then probably network-related upcalls should be directed there. Unless instructed otherwise, upon creation a container object will inherit the caller's namespaces. > This is important, because half the examples you give below are network > related and usually pods share a network namespace. Yeah - I'm more familiar with upcalls made by NFS, AFS and keyrings. > > (1) The DNS resolver. ... > > All persistent (written to fs data) has to be mount ns associated; > there are no ifs, ands and buts to that. I agree this implies that if > you want to run a separate network namespace, you either take DNS from > the parent (a lot of containers do) My intention is to make the DNS cache per-network namespace within the kernel. Currently, there's only one and it's shared between all namespaces, but that won't work if you end up with two net namespaces that direct the same addresses to different things. > or you set up a daemon to run within the mount namespace. That's not currently an option: the DNS service upcalls only, and /sbin/request-key is invoked in the init_ns. This performs the network accesses in the wrong network namespace. > I agree the latter is a slightly fiddly operation you have to get right, but > that's why we have orchestration systems. An orchestration system can use this. This is not a replacement for Kubernetes or Docker or whatever. > What is it we could do with the above that we cannot do today? Upcall into an appropriate set of namespaces and keep the results separate by network namespace. > > (2) NFS ID mapper. The NFS ID mapping cache should also probably be > > per-network namespace. > > I think this is a view but not the only one: Right at the moment, NFS > ID mapping is used as the one of the ways we can get the user namespace > ID mapping writes to file problems fixed ... that makes it a property > of the mount namespace for a lot of containers. In some ways it's really a property of the server, and two different servers may appear in two separate network namespaces with the same apparent name and address. It's not a property of the mount namespace because mount namespaces share superblocks, and this is done at the superblock level. Possibly it should be done on the vfsmount, as a filter on the interaction between userspace and kernel. > There are many other instances where they do exactly as you say, but what > I'm saying is that we don't want to lose the flexibility we currently have. You don't really lose any flexibility; if anything, you gain it. (Note that in case your objection is that I haven't yet implemented the ability to set namespaces arbitrarily in a namespace, that's on list of things to do that I included, as is adjusting the control groups.) > All mount namespaces have an owning user namespace, so the data > relations are already there in the kernel, is the problem simply > finding them? The superblocks used by the vfsmounts in a mount namespace aren't all necessarily in the same user_ns, so none of: sb->s_user_ns == current_user_ns() sb->s_user_ns == current->ns->mnt_ns->user_ns current->ns->mnt_ns->user_ns == current_user_ns() need hold true that I can see. > > These patches are built on top of the mount context patchset so that > > namespaces can be properly propagated over submounts/automounts. > > I'll stop here ... you get the idea that I think this is imposing a set > of restrictions that will come back to bite us later. What restrictions am I imposing? > If this is just for the sake of figuring out how to get keyring upcalls to > work, then I'm sure we can come up with something. No, it's not just for that, though, admittedly, all of the upcall mechanisms I outlined use request_key() at the core. Really, a container is an anchor for the resources you need to make an upcall, but it can also be used to anchor other things. One thing I've been asked for by a number of people is a per-container keyring for the provision of authentication keys, fs decryption keys and other things - but there's no actual container off which this can be hung. Another thing that could be useful is a list of what device files a container may access, so that we can allow limited mounting by the container root user within the container. Now these could be made into their own namespaces or added to one that already exists - perhaps the mount namespace being the most logical. David ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <1495478092.2816.17.camel@redhat.com>]
[parent not found: <1495478092.2816.17.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]
* Re: [RFC][PATCH 0/9] Make containers kernel objects [not found] ` <1495478092.2816.17.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> @ 2017-05-22 19:21 ` James Bottomley 0 siblings, 0 replies; 25+ messages in thread From: James Bottomley @ 2017-05-22 19:21 UTC (permalink / raw) To: Jeff Layton, David Howells, trondmy-7I+n7zu2hftEKMMhf/gKZA Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, Linux Containers, linux-kernel-u79uwXL29TY76Z2rM5mHXA, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, cgroups-u79uwXL29TY76Z2rM5mHXA, ebiederm-aS9lmoZGLiVWk0Htik3J/w On Mon, 2017-05-22 at 14:34 -0400, Jeff Layton wrote: > On Mon, 2017-05-22 at 09:53 -0700, James Bottomley wrote: > > [Added missing cc to containers list] > > On Mon, 2017-05-22 at 17:22 +0100, David Howells wrote: > > > Here are a set of patches to define a container object for the > > > kernel and to provide some methods to create and manipulate them. > > > > > > The reason I think this is necessary is that the kernel has no > > > idea how to direct upcalls to what userspace considers to be a > > > container - current Linux practice appears to make a "container" > > > just an arbitrarily chosen junction of namespaces, control groups > > > and files, which may be changed individually within the > > > "container". > > > > This sounds like a step in the wrong direction: the strength of the > > current container interfaces in Linux is that people who set up > > containers don't have to agree what they look like. So I can set > > up a user namespace without a mount namespace or an architecture > > emulation container with only a mount namespace. > > > > Does this really mandate what they look like though? AFAICT, you can > still spawn disconnected namespaces to your heart's content. What > this does is provide a container for several different namespaces so > that the kernel can actually be aware of the association between > them. Yes, because it imposes a view of what is in a container. As the several replies have pointed out (and indeed as I pointed out below for kubernetes), this isn't something the orchestration systems would find usable. > The way you populate the different namespaces looks to be pretty > flexible. OK, but look at it another way: If we provides a container API no actual consumer of container technologies wants to use just because we think it makes certain tasks easy, is it really a good API? Containers are multi-layered and complex. If you're not ready for this as a user, then you should use an orchestration system that prevents you from screwing up. > > But ignoring my fun foibles with containers and to give a concrete > > example in terms of a popular orchestration system: in kubernetes, > > where certain namespaces are shared across pods, do you imagine the > > kernel's view of the "container" to be the pod or what kubernetes > > thinks of as the container? This is important, because half the > > examples you give below are network related and usually pods share > > a network namespace. > > > > > The kernel upcall mechanism then needs to decide which set of > > > namespaces, etc., it must exec the appropriate upcall program. > > > Examples of this include: > > > > > > (1) The DNS resolver. The DNS cache in the kernel should > > > probably be per-network namespace, but in userspace the program, > > > its libraries and its config data are associated with a mount > > > tree and a user namespace and it gets run in a particular pid > > > namespace. > > > > All persistent (written to fs data) has to be mount ns associated; > > there are no ifs, ands and buts to that. I agree this implies that > > if you want to run a separate network namespace, you either take > > DNS from the parent (a lot of containers do) or you set up a daemon > > to run within the mount namespace. I agree the latter is a > > slightly fiddly operation you have to get right, but that's why we > > have orchestration systems. > > > > What is it we could do with the above that we cannot do today? > > > > Spawn a task directly from the kernel, already set up in the correct > namespaces, a'la call_usermodehelper. So far there is no way to do > that, Today the usermode helper has to be namespace aware. We spawn it into the root namespace and it jumps into the correct namespace/cgroup combination and re-executes itself or simply performs the requisite task on behalf of the container. Is this simple, no; does it work, yes, provided the host OS is aware of what the container orchestration system wants it to do. > and it is something we'd very much desire. Ian Kent has made several > passes at it recently. Well, every time we try to remove some of the complexity from userspace, we end up wrapping around the axle of what exactly we're trying to achieve, yes. > > > (2) NFS ID mapper. The NFS ID mapping cache should also > > > probably be per-network namespace. > > > > I think this is a view but not the only one: Right at the moment, > > NFS ID mapping is used as the one of the ways we can get the user > > namespace ID mapping writes to file problems fixed ... that makes > > it a property of the mount namespace for a lot of containers. > > There are many other instances where they do exactly as you say, > > but what I'm saying is that we don't want to lose the flexibility > > we currently have. > > > > > (3) nfsdcltrack. A way for NFSD to access stable storage for > > > tracking of persistent state. Again, network-namespace > > > dependent, but also perhaps mount-namespace dependent. > > Definitely mount-namespace dependent. > > > > > So again, given we can set this up to work today, this sounds like > > more a restriction that will bite us than an enhancement that gives > > us extra features. > > > > How do you set this up to work today? Well, as above, it spawns into the root, you jump it to where it should be and re-execute or simply handle in the host. > AFAIK, if you want to run knfsd in a container today, you're out of > luck for any non-trivial configuration. Well "running knfsd in a container" is actually different from having a containerised nfs export. My understanding was that thanks to the work of Stas Kinsbursky, the latter has mostly worked since the 3.9 kernel for v3 and below. I assume the current issue is that there's a problem with v4? James > The main reason is that most of knfsd is namespace-ized in the > network namespace, but there is no clear way to associate that with a > mount namespace, which is what we need to do this properly inside a > container. I think David's patches would get us there. > > > > (4) General request-key upcalls. Not particularly namespace > > > dependent, apart from keyrings being somewhat governed by the > > > user namespace and the upcall being configured by the mount > > > namespace. > > > > All mount namespaces have an owning user namespace, so the data > > relations are already there in the kernel, is the problem simply > > finding them? > > > > > These patches are built on top of the mount context patchset so > > > that namespaces can be properly propagated over > > > submounts/automounts. > > > > I'll stop here ... you get the idea that I think this is imposing a > > set of restrictions that will come back to bite us later. If this > > is just for the sake of figuring out how to get keyring upcalls to > > work, then I'm sure we can come up with something. > > > ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <1495480860.9050.18.camel@HansenPartnership.com>]
[parent not found: <1495480860.9050.18.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>]
* Re: [RFC][PATCH 0/9] Make containers kernel objects [not found] ` <1495480860.9050.18.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org> @ 2017-05-22 22:14 ` Jeff Layton 2017-05-23 10:35 ` Ian Kent 1 sibling, 0 replies; 25+ messages in thread From: Jeff Layton @ 2017-05-22 22:14 UTC (permalink / raw) To: James Bottomley, David Howells, trondmy-7I+n7zu2hftEKMMhf/gKZA Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, Linux Containers, linux-kernel-u79uwXL29TY76Z2rM5mHXA, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, cgroups-u79uwXL29TY76Z2rM5mHXA, ebiederm-aS9lmoZGLiVWk0Htik3J/w On Mon, 2017-05-22 at 12:21 -0700, James Bottomley wrote: > On Mon, 2017-05-22 at 14:34 -0400, Jeff Layton wrote: > > On Mon, 2017-05-22 at 09:53 -0700, James Bottomley wrote: > > > [Added missing cc to containers list] > > > On Mon, 2017-05-22 at 17:22 +0100, David Howells wrote: > > > > Here are a set of patches to define a container object for the > > > > kernel and to provide some methods to create and manipulate them. > > > > > > > > The reason I think this is necessary is that the kernel has no > > > > idea how to direct upcalls to what userspace considers to be a > > > > container - current Linux practice appears to make a "container" > > > > just an arbitrarily chosen junction of namespaces, control groups > > > > and files, which may be changed individually within the > > > > "container". > > > > > > This sounds like a step in the wrong direction: the strength of the > > > current container interfaces in Linux is that people who set up > > > containers don't have to agree what they look like. So I can set > > > up a user namespace without a mount namespace or an architecture > > > emulation container with only a mount namespace. > > > > > > > Does this really mandate what they look like though? AFAICT, you can > > still spawn disconnected namespaces to your heart's content. What > > this does is provide a container for several different namespaces so > > that the kernel can actually be aware of the association between > > them. > > Yes, because it imposes a view of what is in a container. As the > several replies have pointed out (and indeed as I pointed out below for > kubernetes), this isn't something the orchestration systems would find > usable. > > > The way you populate the different namespaces looks to be pretty > > flexible. > > OK, but look at it another way: If we provides a container API no > actual consumer of container technologies wants to use just because we > think it makes certain tasks easy, is it really a good API? > > Containers are multi-layered and complex. If you're not ready for this > as a user, then you should use an orchestration system that prevents > you from screwing up. > > > > But ignoring my fun foibles with containers and to give a concrete > > > example in terms of a popular orchestration system: in kubernetes, > > > where certain namespaces are shared across pods, do you imagine the > > > kernel's view of the "container" to be the pod or what kubernetes > > > thinks of as the container? This is important, because half the > > > examples you give below are network related and usually pods share > > > a network namespace. > > > > > > > The kernel upcall mechanism then needs to decide which set of > > > > namespaces, etc., it must exec the appropriate upcall program. > > > > Examples of this include: > > > > > > > > (1) The DNS resolver. The DNS cache in the kernel should > > > > probably be per-network namespace, but in userspace the program, > > > > its libraries and its config data are associated with a mount > > > > tree and a user namespace and it gets run in a particular pid > > > > namespace. > > > > > > All persistent (written to fs data) has to be mount ns associated; > > > there are no ifs, ands and buts to that. I agree this implies that > > > if you want to run a separate network namespace, you either take > > > DNS from the parent (a lot of containers do) or you set up a daemon > > > to run within the mount namespace. I agree the latter is a > > > slightly fiddly operation you have to get right, but that's why we > > > have orchestration systems. > > > > > > What is it we could do with the above that we cannot do today? > > > > > > > Spawn a task directly from the kernel, already set up in the correct > > namespaces, a'la call_usermodehelper. So far there is no way to do > > that, > > Today the usermode helper has to be namespace aware. We spawn it into > the root namespace and it jumps into the correct namespace/cgroup > combination and re-executes itself or simply performs the requisite > task on behalf of the container. Is this simple, no; does it work, > yes, provided the host OS is aware of what the container orchestration > system wants it to do. > > > and it is something we'd very much desire. Ian Kent has made several > > passes at it recently. > > Well, every time we try to remove some of the complexity from > userspace, we end up wrapping around the axle of what exactly we're > trying to achieve, yes. > > > > > (2) NFS ID mapper. The NFS ID mapping cache should also > > > > probably be per-network namespace. > > > > > > I think this is a view but not the only one: Right at the moment, > > > NFS ID mapping is used as the one of the ways we can get the user > > > namespace ID mapping writes to file problems fixed ... that makes > > > it a property of the mount namespace for a lot of containers. > > > There are many other instances where they do exactly as you say, > > > but what I'm saying is that we don't want to lose the flexibility > > > we currently have. > > > > > > > (3) nfsdcltrack. A way for NFSD to access stable storage for > > > > tracking of persistent state. Again, network-namespace > > > > dependent, but also perhaps mount-namespace dependent. > > > > Definitely mount-namespace dependent. > > > > > > > > So again, given we can set this up to work today, this sounds like > > > more a restriction that will bite us than an enhancement that gives > > > us extra features. > > > > > > > How do you set this up to work today? > > Well, as above, it spawns into the root, you jump it to where it should > be and re-execute or simply handle in the host. > > > AFAIK, if you want to run knfsd in a container today, you're out of > > luck for any non-trivial configuration. > > Well "running knfsd in a container" is actually different from having a > containerised nfs export. My understanding was that thanks to the work > of Stas Kinsbursky, the latter has mostly worked since the 3.9 kernel > for v3 and below. I assume the current issue is that there's a problem > with v4? > Yes -- v3 mostly works because the equivalent state-tracking (rpc.statd) is run as a long-running daemon. nfsdcltrack uses call_usermodehelper, so for that you need to be able to determine what mount namespace to run the thing in. All we really know in knfsd when we want to do an upcall is the net namespace. We could really use a way to associate the two and spawn the thing in the correct container (or pass it enough info for it to setns() into the right ones). In principle, we could just ensure that we do all of this sort of thing with long-running daemons that are started whenever the container starts. But...having to run daemons full-time for infrequently-used services sort of sucks and requires it to be setup. UMH helpers just get run as long as the binary is in the right place. I've also been reading over Eric suggestion, and that seems like it might work as well though. > > The main reason is that most of knfsd is namespace-ized in the > > network namespace, but there is no clear way to associate that with a > > mount namespace, which is what we need to do this properly inside a > > container. I think David's patches would get us there. > > > > > > (4) General request-key upcalls. Not particularly namespace > > > > dependent, apart from keyrings being somewhat governed by the > > > > user namespace and the upcall being configured by the mount > > > > namespace. > > > > > > All mount namespaces have an owning user namespace, so the data > > > relations are already there in the kernel, is the problem simply > > > finding them? > > > > > > > These patches are built on top of the mount context patchset so > > > > that namespaces can be properly propagated over > > > > submounts/automounts. > > > > > > I'll stop here ... you get the idea that I think this is imposing a > > > set of restrictions that will come back to bite us later. If this > > > is just for the sake of figuring out how to get keyring upcalls to > > > work, then I'm sure we can come up with something. > > > > > -- Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [RFC][PATCH 0/9] Make containers kernel objects [not found] ` <1495480860.9050.18.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org> 2017-05-22 22:14 ` Jeff Layton @ 2017-05-23 10:35 ` Ian Kent 1 sibling, 0 replies; 25+ messages in thread From: Ian Kent @ 2017-05-23 10:35 UTC (permalink / raw) To: James Bottomley, Jeff Layton, David Howells, trondmy-7I+n7zu2hftEKMMhf/gKZA Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, Linux Containers, linux-kernel-u79uwXL29TY76Z2rM5mHXA, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, cgroups-u79uwXL29TY76Z2rM5mHXA, ebiederm-aS9lmoZGLiVWk0Htik3J/w On Mon, 2017-05-22 at 12:21 -0700, James Bottomley wrote: > > > > > (3) nfsdcltrack. A way for NFSD to access stable storage for > > > > tracking of persistent state. Again, network-namespace > > > > dependent, but also perhaps mount-namespace dependent. > > > > Definitely mount-namespace dependent. > > > > > > > > So again, given we can set this up to work today, this sounds like > > > more a restriction that will bite us than an enhancement that gives > > > us extra features. > > > > > > > How do you set this up to work today? > > Well, as above, it spawns into the root, you jump it to where it should > be and re-execute or simply handle in the host. > > > AFAIK, if you want to run knfsd in a container today, you're out of > > luck for any non-trivial configuration. > > Well "running knfsd in a container" is actually different from having a > containerised nfs export. My understanding was that thanks to the work > of Stas Kinsbursky, the latter has mostly worked since the 3.9 kernel > for v3 and below. I assume the current issue is that there's a problem > with v4? Oh, ok, I thought that, say, a docker (NFS) volumes-from a container to another container didn't work for any version of NFS. Certainly didn't work last time I tried, it was a while ago though. Ian _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/containers ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <f167feeb-e653-12e3-eec8-24162f7f7c07-l3A5Bk7waGM@public.gmane.org>]
* Re: [RFC][PATCH 0/9] Make containers kernel objects [not found] ` <f167feeb-e653-12e3-eec8-24162f7f7c07-l3A5Bk7waGM@public.gmane.org> @ 2017-05-23 14:53 ` David Howells 0 siblings, 0 replies; 25+ messages in thread From: David Howells @ 2017-05-23 14:53 UTC (permalink / raw) To: Aleksa Sarai Cc: James Bottomley, linux-nfs-u79uwXL29TY76Z2rM5mHXA, jlayton-H+wXaHxf7aLQT0dZR+AlfA, mszeredi-H+wXaHxf7aLQT0dZR+AlfA, Linux Containers, linux-kernel-u79uwXL29TY76Z2rM5mHXA, dhowells-H+wXaHxf7aLQT0dZR+AlfA, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, cgroups-u79uwXL29TY76Z2rM5mHXA, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, trondmy-7I+n7zu2hftEKMMhf/gKZA, ebiederm-aS9lmoZGLiVWk0Htik3J/w Aleksa Sarai <asarai-l3A5Bk7waGM@public.gmane.org> wrote: > >> The reason I think this is necessary is that the kernel has no idea > >> how to direct upcalls to what userspace considers to be a container - > >> current Linux practice appears to make a "container" just an > >> arbitrarily chosen junction of namespaces, control groups and files, > >> which may be changed individually within the "container". > > Just want to point out that if the kernel APIs for containers massively > change, then the OCI will have to completely rework how we describe containers > (and so will all existing runtimes). > > Not to mention that while I don't like how hard it is (from a runtime > perspective) to actually set up a container securely, there are undoubtedly > benefits to having namespaces split out. The network namespace being separate > means that in certain contexts you actually don't want to create a new network > namespace when creating a container. Yep, I quite agree. However, certain things need to be made per-net namespace that *aren't*. DNS results, for instance. As an example, I could set up a client machine with two ethernet ports, set up two DNS+NFS servers, each of which think they're called "foo.bar" and attach each server to a different port on the client machine. Then I could create a pair of containers on the client machine and route the network in each container to a different port. Now there's a problem because the names of the cached DNS records for each port overlap. Further, the NFS idmapper needs to be able to direct its calls to the appropriate network. > I had some ideas about how you could implement bridging in userspace (as an > unprivileged user, for rootless containers) but if you can't join namespaces > individually then such a setup is not practically possible. I'm not proposing to take away the ability to arbitrarily set the namespaces in a container. I haven't implemented it yet, but it was on the to-do list: (7) Directly set a container's namespaces to allow cross-container sharing. David ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <2446.1495551216@warthog.procyon.org.uk>]
[parent not found: <2446.1495551216-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>]
* Re: [RFC][PATCH 0/9] Make containers kernel objects [not found] ` <2446.1495551216-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org> @ 2017-05-23 14:56 ` Eric W. Biederman 0 siblings, 0 replies; 25+ messages in thread From: Eric W. Biederman @ 2017-05-23 14:56 UTC (permalink / raw) To: David Howells Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, jlayton-H+wXaHxf7aLQT0dZR+AlfA, Linux Containers, linux-kernel-u79uwXL29TY76Z2rM5mHXA, James Bottomley, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, cgroups-u79uwXL29TY76Z2rM5mHXA, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, trondmy-7I+n7zu2hftEKMMhf/gKZA David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> writes: > Aleksa Sarai <asarai-l3A5Bk7waGM@public.gmane.org> wrote: > >> >> The reason I think this is necessary is that the kernel has no idea >> >> how to direct upcalls to what userspace considers to be a container - >> >> current Linux practice appears to make a "container" just an >> >> arbitrarily chosen junction of namespaces, control groups and files, >> >> which may be changed individually within the "container". >> >> Just want to point out that if the kernel APIs for containers massively >> change, then the OCI will have to completely rework how we describe containers >> (and so will all existing runtimes). >> >> Not to mention that while I don't like how hard it is (from a runtime >> perspective) to actually set up a container securely, there are undoubtedly >> benefits to having namespaces split out. The network namespace being separate >> means that in certain contexts you actually don't want to create a new network >> namespace when creating a container. > > Yep, I quite agree. > > However, certain things need to be made per-net namespace that *aren't*. DNS > results, for instance. > > As an example, I could set up a client machine with two ethernet ports, set up > two DNS+NFS servers, each of which think they're called "foo.bar" and attach > each server to a different port on the client machine. Then I could create a > pair of containers on the client machine and route the network in each > container to a different port. Now there's a problem because the names of the > cached DNS records for each port overlap. Please look at ip netns add. It does solve this in userspace rather simply. > Further, the NFS idmapper needs to be able to direct its calls to the > appropriate network. Eric ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <87zie3mxkc.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>]
* Re: [RFC][PATCH 0/9] Make containers kernel objects [not found] ` <87zie3mxkc.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> @ 2017-05-23 15:14 ` David Howells 0 siblings, 0 replies; 25+ messages in thread From: David Howells @ 2017-05-23 15:14 UTC (permalink / raw) To: Eric W. Biederman Cc: James Bottomley, linux-nfs-u79uwXL29TY76Z2rM5mHXA, jlayton-H+wXaHxf7aLQT0dZR+AlfA, mszeredi-H+wXaHxf7aLQT0dZR+AlfA, Linux Containers, linux-kernel-u79uwXL29TY76Z2rM5mHXA, dhowells-H+wXaHxf7aLQT0dZR+AlfA, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, cgroups-u79uwXL29TY76Z2rM5mHXA, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, trondmy-7I+n7zu2hftEKMMhf/gKZA Eric W. Biederman <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> wrote: > > As an example, I could set up a client machine with two ethernet ports, > > set up two DNS+NFS servers, each of which think they're called "foo.bar" > > and attach each server to a different port on the client machine. Then I > > could create a pair of containers on the client machine and route the > > network in each container to a different port. Now there's a problem > > because the names of the cached DNS records for each port overlap. > > Please look at ip netns add. warthog>man ip | grep setns warthog1> > It does solve this in userspace rather simply. Ummm... How? The kernel DNS resolver is not namespace aware. David ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <2961.1495552481@warthog.procyon.org.uk>]
[parent not found: <2961.1495552481-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>]
* Re: [RFC][PATCH 0/9] Make containers kernel objects [not found] ` <2961.1495552481-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org> @ 2017-05-23 15:17 ` Eric W. Biederman [not found] ` <87bmqjmwl5.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> [not found] ` <1495554267.27369.9.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org> 0 siblings, 2 replies; 25+ messages in thread From: Eric W. Biederman @ 2017-05-23 15:17 UTC (permalink / raw) To: David Howells Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, jlayton-H+wXaHxf7aLQT0dZR+AlfA, Linux Containers, linux-kernel-u79uwXL29TY76Z2rM5mHXA, James Bottomley, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, cgroups-u79uwXL29TY76Z2rM5mHXA, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, trondmy-7I+n7zu2hftEKMMhf/gKZA David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> writes: > Eric W. Biederman <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> wrote: > >> > As an example, I could set up a client machine with two ethernet ports, >> > set up two DNS+NFS servers, each of which think they're called "foo.bar" >> > and attach each server to a different port on the client machine. Then I >> > could create a pair of containers on the client machine and route the >> > network in each container to a different port. Now there's a problem >> > because the names of the cached DNS records for each port overlap. >> >> Please look at ip netns add. > > warthog>man ip | grep setns > warthog1> Not setns netns >> It does solve this in userspace rather simply. > > Ummm... How? The kernel DNS resolver is not namespace aware. But it works fine if called in the proper context and we have a defacto standard for where to put all of the files (the tricky part) if you are dealing with multiple network namespaces simultaneously. Eric ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <87bmqjmwl5.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>]
* Re: [RFC][PATCH 0/9] Make containers kernel objects [not found] ` <87bmqjmwl5.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> @ 2017-05-23 15:44 ` James Bottomley 0 siblings, 0 replies; 25+ messages in thread From: James Bottomley @ 2017-05-23 15:44 UTC (permalink / raw) To: Eric W. Biederman, David Howells Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, jlayton-H+wXaHxf7aLQT0dZR+AlfA, Linux Containers, linux-kernel-u79uwXL29TY76Z2rM5mHXA, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, cgroups-u79uwXL29TY76Z2rM5mHXA, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, trondmy-7I+n7zu2hftEKMMhf/gKZA On Tue, 2017-05-23 at 10:17 -0500, Eric W. Biederman wrote: > David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> writes: > > Eric W. Biederman <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> wrote: > > > It does solve this in userspace rather simply. > > > > Ummm... How? The kernel DNS resolver is not namespace aware. > > But it works fine if called in the proper context and we have a > defacto standard for where to put all of the files (the tricky part) > if you are dealing with multiple network namespaces simultaneously. I think you're missing each other's points slightly. What David is pointing out is that the kernel has a DNS cache (net/dns_resolver/) it can do name to IP translations, but isn't namespaced. Once it has one entry all containers would see it if they cause a lookup to go through the kernel cache, so going through the cache you can't have a name resolving to different IP addresses on a per container basis. I think Eric's point is that if you need the same DNS names resolving to different IP addresses on a per container basis, you can do this in userspace today but you have to disable the in-kernel DNS cache. James ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <1495554267.27369.9.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>]
* Re: [RFC][PATCH 0/9] Make containers kernel objects [not found] ` <1495554267.27369.9.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org> @ 2017-05-23 16:36 ` David Howells [not found] ` <3860.1495557363-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org> 0 siblings, 1 reply; 25+ messages in thread From: David Howells @ 2017-05-23 16:36 UTC (permalink / raw) To: James Bottomley Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, jlayton-H+wXaHxf7aLQT0dZR+AlfA, Linux Containers, linux-kernel-u79uwXL29TY76Z2rM5mHXA, dhowells-H+wXaHxf7aLQT0dZR+AlfA, Eric W. Biederman, cgroups-u79uwXL29TY76Z2rM5mHXA, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, trondmy-7I+n7zu2hftEKMMhf/gKZA, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn James Bottomley <James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org> wrote: > What David is pointing out is that the kernel has a DNS cache > (net/dns_resolver/) it can do name to IP translations, but isn't > namespaced. Once it has one entry all containers would see it if they > cause a lookup to go through the kernel cache, so going through the > cache you can't have a name resolving to different IP addresses on a > per container basis. Yes - and the transport to userspace, the request_key() upcall, isn't namespaced either. Namespacing it isn't entirely simple since we have to set the right mount namespace (for execve, config, etc.), plus any other relevant namespaces (such as network) - which is dependent on key type. I can't record the mount namespace in the network namespace because that would create a dependency loop: mnt_ns -> mnt -> sb -> net_ns -> mnt_ns > I think Eric's point is that if you need the same DNS names resolving > to different IP addresses on a per container basis, you can do this in > userspace today but you have to disable the in-kernel DNS cache. You could disable the in-kernel dns resolver in your config, but then you don't get referrals in NFS. Also, CIFS, AFS and other filesystems would be affected. If you're fine with the restrictions, then there is no problem. David ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <3860.1495557363-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>]
* Re: [RFC][PATCH 0/9] Make containers kernel objects [not found] ` <3860.1495557363-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org> @ 2017-05-24 8:26 ` Eric W. Biederman [not found] ` <87k256ek3e.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> 0 siblings, 1 reply; 25+ messages in thread From: Eric W. Biederman @ 2017-05-24 8:26 UTC (permalink / raw) To: David Howells Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, jlayton-H+wXaHxf7aLQT0dZR+AlfA, Linux Containers, linux-kernel-u79uwXL29TY76Z2rM5mHXA, James Bottomley, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, trondmy-7I+n7zu2hftEKMMhf/gKZA, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, cgroups-u79uwXL29TY76Z2rM5mHXA David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> writes: > James Bottomley <James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org> wrote: > >> What David is pointing out is that the kernel has a DNS cache >> (net/dns_resolver/) it can do name to IP translations, but isn't >> namespaced. Once it has one entry all containers would see it if they >> cause a lookup to go through the kernel cache, so going through the >> cache you can't have a name resolving to different IP addresses on a >> per container basis. > > Yes - and the transport to userspace, the request_key() upcall, isn't > namespaced either. Namespacing it isn't entirely simple since we have to set > the right mount namespace (for execve, config, etc.), plus any other relevant > namespaces (such as network) - which is dependent on key type. > > I can't record the mount namespace in the network namespace because that would > create a dependency loop: > > mnt_ns -> mnt -> sb -> net_ns -> mnt_ns I have already given a concrete suggest on how this might be untangled. So I won't repeat it here. >> I think Eric's point is that if you need the same DNS names resolving >> to different IP addresses on a per container basis, you can do this in >> userspace today but you have to disable the in-kernel DNS cache. > > You could disable the in-kernel dns resolver in your config, but then you > don't get referrals in NFS. Also, CIFS, AFS and other filesystems would be > affected. If you're fine with the restrictions, then there is no > problem. I haven't been arguing that at all. I was only pointing out that this issue is not an issue with DNS. Userspace handles this all fine. The issue is exclusively with this request_key api and generally user mode upcalls. I have no problem seeing that there is an issue with the kernel code. I am well aware of the problem. Unfortunately the people who cared enough to start addressing this have not been able to write kernel code that fixes this. My personal experience when I tried to use the request_key api at the beginning of this was it was too hard to test. There was no room for goofing up as at that time it was impossible to invalidate a cached reply from userspace if you happened to know it was wrong. Which meant that if something incorrect was cached it required rebooting the kernel. I have a lot of sympathy with the view that the best way to do some of this is with socket activations or perhaps something with rpc portmapper. Where something like inetd is used to start the user space component on-demand. I won't call that a solution to this case but I do think it makes a good example to compare with. When you need run something in a clean context having that something only need to worry about the contents of the data it is receiving and not about it's environment as suid applications do is a nice simplification. The entire user mode helper paradigm removes from user space the freedom to specify what context it's code should run in. In a world where everything is global that is fine. But in a world with containers where not everything is global it becomes a royal pain. And I am very very sympathetic to solving this. The only solution that I know would work is to capture the context at some point in a process and then to use that process to fork user mode helpers. So far no one has even bothered to seriously try the one solution that is guaranteed to work because it takes a lot of changes to kernel code. I believe the last effort snagged on what a pain it is to refactor the user mode helper infrastructure. I don't see in your code any of that work. I am glad to see that you also see the problem. At least when it comes to the request_key api. What I am hoping to see is someone who has the will to dig in and understand all of the interactions and refactor the kernel to solve the problem. This is not a case where our user space interfaces are preventing a solution to this problem (as your patchset implies). This is a case where things need to be refactored kernel side to solve this. So far this attempt is just another in the bazillion or so bad half-assed attempts to solve this problem I have seen over the years. Eric ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <87k256ek3e.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>]
* Re: [RFC][PATCH 0/9] Make containers kernel objects [not found] ` <87k256ek3e.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> @ 2017-05-24 9:16 ` Ian Kent 0 siblings, 0 replies; 25+ messages in thread From: Ian Kent @ 2017-05-24 9:16 UTC (permalink / raw) To: Eric W. Biederman, David Howells Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, jlayton-H+wXaHxf7aLQT0dZR+AlfA, Linux Containers, linux-kernel-u79uwXL29TY76Z2rM5mHXA, James Bottomley, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, trondmy-7I+n7zu2hftEKMMhf/gKZA, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, cgroups-u79uwXL29TY76Z2rM5mHXA On Wed, 2017-05-24 at 03:26 -0500, Eric W. Biederman wrote: > > So far no one has even bothered to seriously try the one solution that > is guaranteed to work because it takes a lot of changes to kernel code. > I believe the last effort snagged on what a pain it is to refactor the > user mode helper infrastructure. Yes, that's mostly true in my case although I wouldn't say I haven't looked at it seriously but equally I haven't got anything towards it yet either, sorry. I'm likely going to revisit this based on a couple of approaches. One is just what you describe and I had already been looking at this some time ago. It seems to me that adding a work queue type that starts and retains a process until the work queue is destroyed (similar to the way the work queue sub system starts a fail over thread for use under resource exhaustion) would be a sensible way to do it. This doesn't mean I think it's a good idea for reasons I've outlined in the past but the approach does warrant the effort to work out if it can be used without problems. And there's also the request key infrastructure which, as it is now, gets in the road of verifying results, *sigh*. Ian ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <32556.1495547529@warthog.procyon.org.uk>]
[parent not found: <32556.1495547529-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>]
* Re: [RFC][PATCH 0/9] Make containers kernel objects [not found] ` <32556.1495547529-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org> @ 2017-05-23 15:02 ` James Bottomley 2017-05-23 15:23 ` Eric W. Biederman 1 sibling, 0 replies; 25+ messages in thread From: James Bottomley @ 2017-05-23 15:02 UTC (permalink / raw) To: David Howells Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, jlayton-H+wXaHxf7aLQT0dZR+AlfA, Linux Containers, linux-kernel-u79uwXL29TY76Z2rM5mHXA, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, trondmy-7I+n7zu2hftEKMMhf/gKZA, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, cgroups-u79uwXL29TY76Z2rM5mHXA, ebiederm-aS9lmoZGLiVWk0Htik3J/w On Tue, 2017-05-23 at 14:52 +0100, David Howells wrote: > James Bottomley <James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org> wrote: > > > This sounds like a step in the wrong direction: the strength of the > > current container interfaces in Linux is that people who set up > > containers don't have to agree what they look like. > > It may be a strength, but it is also a problem. > > > So I can set up a user namespace without a mount namespace or an > > architecture emulation container with only a mount namespace. > > (I presume you mean with only the mount namespace separate) > > Yep. You can do that with this too. > > > But ignoring my fun foibles with containers and to give a concrete > > example in terms of a popular orchestration system: in kubernetes, > > where certain namespaces are shared across pods, do you imagine the > > kernel's view of the "container" to be the pod or what kubernetes > > thinks of as the container? > > Why not both? If the net_ns is created in the pod container, then > probably > network-related upcalls should be directed there. Unless instructed > otherwise, upon creation a container object will inherit the caller's > namespaces. The pod isn't a container, it's a collection of containers. Lets say each container has a separate mount namespace but shares a network namespace (this is a gross simplification, there are many other ways you can set up a pod, but this one illustrates the point). For your upcall you'd have to pick a kubernetes container and you don't have the information to do that, even with your current patches, because what kubernetes has done. This is where your view of "container" doesn't match the kubernetes view. > > This is important, because half the examples you give below are > > network related and usually pods share a network namespace. > > Yeah - I'm more familiar with upcalls made by NFS, AFS and keyrings. OK, so rather than getting into the technical back and forth below can we agree that the kernel can't have a unitary view of "container" because the current use cases (the orchestration systems) don't have one? Then the next step becomes how can we add an abstraction that gives you what you want (as far as I can tell basically identifying a set of namespaces for an upcall) in a way that doesn't bind the kernel to have a unitary view of a container? And then we can tack the ideas on to the Jeff/Eric subthread. James ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [RFC][PATCH 0/9] Make containers kernel objects [not found] ` <32556.1495547529-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org> 2017-05-23 15:02 ` James Bottomley @ 2017-05-23 15:23 ` Eric W. Biederman 1 sibling, 0 replies; 25+ messages in thread From: Eric W. Biederman @ 2017-05-23 15:23 UTC (permalink / raw) To: David Howells Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, jlayton-H+wXaHxf7aLQT0dZR+AlfA, Linux Containers, linux-kernel-u79uwXL29TY76Z2rM5mHXA, James Bottomley, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, cgroups-u79uwXL29TY76Z2rM5mHXA, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, trondmy-7I+n7zu2hftEKMMhf/gKZA David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> writes: > Another thing that could be useful is a list of what device files a container > may access, so that we can allow limited mounting by the container root user > within the container. That is totally not why that isn't allowed, and won't be allowed any time soon. The issue is that the filesystem implementations in the kernel are not prepared to handle hostile filesystem data structures so that that is the definition of a kernel exploit. The attack surface of the kernel gets quite a bit larger in that case. Perhaps if all of the filesystems data structures had a hmac on them we could allow something like this. Once we can make it safe it is easy to add an appropriate interface. We most defintiely don't need a ``container'' data structure in the kernel to do that. A completely unprivileged fuse is much more likely to work for this use case. And we do already have have the device cgroup which sort of does this. Eric ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <149547016213.10599.1969443294414531853.stgit@warthog.procyon.org.uk>]
[parent not found: <149547016213.10599.1969443294414531853.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>]
* Re: [PATCH 2/9] Implement containers as kernel objects [not found] ` <149547016213.10599.1969443294414531853.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org> @ 2017-08-14 5:47 ` Richard Guy Briggs 0 siblings, 0 replies; 25+ messages in thread From: Richard Guy Briggs @ 2017-08-14 5:47 UTC (permalink / raw) To: David Howells, linux-nfs-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, cgroups-u79uwXL29TY76Z2rM5mHXA, linux-api-u79uwXL29TY76Z2rM5mHXA, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, linux-audit-H+wXaHxf7aLQT0dZR+AlfA Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, jlayton-H+wXaHxf7aLQT0dZR+AlfA, eparis-H+wXaHxf7aLQT0dZR+AlfA, pmoore-H+wXaHxf7aLQT0dZR+AlfA, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, luto-DgEjT+Ai2ygdnm+yROfE0A, trondmy-7I+n7zu2hftEKMMhf/gKZA, sgrubb-H+wXaHxf7aLQT0dZR+AlfA, ebiederm-aS9lmoZGLiVWk0Htik3J/w On 2017-05-22 17:22, David Howells wrote: > A container is then a kernel object that contains the following things: > > (1) Namespaces. > > (2) A root directory. > > (3) A set of processes, including one designated as the 'init' process. > > A container is created and attached to a file descriptor by: > > int cfd = container_create(const char *name, unsigned int flags); > > this inherits all the namespaces of the parent container unless otherwise > the mask calls for new namespaces. > > CONTAINER_NEW_FS_NS > CONTAINER_NEW_EMPTY_FS_NS > CONTAINER_NEW_CGROUP_NS [root only] > CONTAINER_NEW_UTS_NS > CONTAINER_NEW_IPC_NS > CONTAINER_NEW_USER_NS > CONTAINER_NEW_PID_NS > CONTAINER_NEW_NET_NS > > Other flags include: > > CONTAINER_KILL_ON_CLOSE > CONTAINER_CLOSE_ON_EXEC Hi David, I wanted to respond to this thread to attempt some constructive feedback, better late than never. I had a look at your fsopen/fsmount() patchset(s) to support this patchset which was interesting, but doesn't directly affect my work. The primary patch of interest to the audit kernel folks (Paul Moore and me) is this patch while the rest of the patchset is interesting, but not likely to directly affect us. This patch has most of what we need to solve our problem. Paul and I agree that audit is going to have a difficult time identifying containers or even namespaces without some change to the kernel. The audit subsystem in the kernel needs at least a basic clue about which container caused an event to be able to report this at the appropriate level and ignore it at other levels to avoid a DoS. We also agree that there will need to be some sort of trigger from userspace to indicate the creation of a container and its allocated resources and we're not really picky how that is done, such as a clone flag, a syscall or a sysfs write (or even a read, I suppose), but there will need to be some permission restrictions, obviously. (I'd like to see capabilities used for this by adding a specific container bit to the capabilities bitmask.) I doubt we will be able to accomodate all definitions or concepts of a container in a timely fashion. We'll need to start somewhere with a minimum definition so that we can get traction and actually move forward before another compelling shared kernel microservice method leaves our entire community behind. I'd like to declare that a container is a full set of cloned namespaces, but this is inefficient, overly constricting and unnecessary for our needs. If we could agree on a minimum definition of a container (which may have only one specific cloned namespace) then we have something on which to build. I could even see a container being defined by a trigger sent from userspace about a process (task) from which all its children are considered to be within that container, subject to further nesting. In the simplest usable model for audit, if a container (definition implies and) starts a PID namespace, then the container ID could simply be the container's "init" process PID in the initial PID namespace. This assumes that as soon as that process vanishes, that entire container and all its children are killed off (which you've done). There may be some container orchestration systems that don't use a unique PID namespace per container and that imposing this will cause them challenges. If containers have at minimum a unique mount namespace then the root path dentry inode device and inode number could be used, but there are likely better identifiers. Again, there may be container orchestrators that don't use a unique mount namespace per container and that imposing this will cause challenges. I expect there are similar examples for each of the other namespaces. If we could pick one namespace type for consensus for which each container has a unique instance of that namespace, we could use the dev/ino tuple from that namespace as had originally been suggested by Aristeu Rozanski more than 4 years ago as part of the set of namespace IDs. I had also attempted to solve this problem by using the namespace' proc inode, then switched over to generate a unique kernel serial number for each namespace and then went back to namespace proc dev/ino once Al Viro implemented nsfs: v1 https://lkml.org/lkml/2014/4/22/662 v2 https://lkml.org/lkml/2014/5/9/637 v3 https://lkml.org/lkml/2014/5/20/287 v4 https://lkml.org/lkml/2014/8/20/844 v5 https://lkml.org/lkml/2014/10/6/25 v6 https://lkml.org/lkml/2015/4/17/48 v7 https://lkml.org/lkml/2015/5/12/773 These patches don't use a container ID, but track all namespaces in use for an event. This has the benefit of punting this tracking to userspace for some other tool to analyse and determine to which container an event belongs. This will use a lot of bandwidth in audit log files when a single container ID that doesn't require nesting information to be complete would be a much more efficient use of audit log bandwidth. If we rely only on the setting of arbitrary container names from userspace, then we must provide a map or tree back to the initial audit domain for that running kernel to be able to differentiate between potentially identical container names assigned in a nested container system. If we assign a container serial number sequentially (atomic64_inc) from the kernel on request from userspace like the sessionID and log the creation with all nsIDs and the parent container serial number and/or container name, the nesting is clear due to lack of ambiguity in potential duplicate names in nesting. If a container serial number is used, the tree of inheritance of nested containers can be rebuilt from the audit records showing what containers were spawned from what parent. As was suggested in one of the previous threads, if there are any events not associated with a task (incoming network packets) we log the namespace ID and then only concern ourselves with its container serial number or container name once it becomes associated with a task at which point that tracking will be more important anyways. I'm not convinced that a userspace or kernel generated UUID is that useful since they are large, not human readable and may not be globally unique given the "pets vs cattle" direction we are going with potentially identical conditions in hosts or containers spawning containers, but I see no need to restrict them. How do we deal with setns()? Once it is determined that action is permitted, given the new combinaiton of namespaces and potential membership in a different container, record the transition from one container to another including all namespaces if the latter are a different subset than the target container initial set. David, this patch of yours provides most of what we need, but there is a danger that some compromises (complete freedom of which namespaces to clone) will make it unusable for our needs unless other mechanisms are added (internal container serial number). To answer Andy's inevitable question: We want to be able to attribute audit events, whether they are generated by userspace or by a kernel event, to a specific container. Since the kernel has no concept of a container, it needs at least a rudimentary one to be able to track activity of kernel objects, similar to what is already done with the loginuid (auid) and sessionid, neither of which are kernel concepts, but the kernel keeps track of these as a service to userspace. We are able to track activity by task, but we don't know when that task or its namespaces (both resources) were allocated to a nebulous "container". This resource tracking is required for security certifications. Thanks. > Note that I've added a pointer to the current container to task_struct. > This doesn't make the nsproxy pointer redundant as you can still make new > namespaces with clone(). > > I've also added a list_head to task_struct to form a list in the container > of its member processes. This is convenient, but redundant since the code > could iterate over all the tasks looking for ones that have a matching > task->container. > > > ================== > FUTURE DEVELOPMENT > ================== > > (1) Setting up the container. > > It should then be possible for the supervising process to modify the > new container by: > > container_mount(int cfd, > const char *source, > const char *target, /* NULL -> root */ > const char *filesystemtype, > unsigned long mountflags, > const void *data); > container_chroot(int cfd, const char *path); > container_bind_mount_across(int cfd, > const char *source, > const char *target); /* NULL -> root */ > mkdirat(int cfd, const char *path, mode_t mode); > mknodat(int cfd, const char *path, mode_t mode, dev_t dev); > int fd = openat(int cfd, const char *path, > unsigned int flags, mode_t mode); > int fd = container_socket(int cfd, int domain, int type, > int protocol); > > Opening a netlink socket inside the container should allow management > of the container's network namespace. > > (2) Starting the container. > > Once all modifications are complete, the container's 'init' process > can be started by: > > fork_into_container(int cfd); > > This precludes further external modification of the mount tree within > the container. Before this point, the container is simply destroyed > if the container fd is closed. > > (3) Waiting for the container to complete. > > The container fd can then be polled to wait for init process therein > to complete and the exit code collected by: > > container_wait(int container_fd, int *_wstatus, unsigned int wait, > struct rusage *rusage); > > The container and everything in it can be terminated or killed off: > > container_kill(int container_fd, int initonly, int signal); > > If 'init' dies, all other processes in the container are preemptively > SIGKILL'd by the kernel. > > By default, if the container is active and its fd is closed, the > container is left running and wil be cleaned up when its 'init' exits. > The default can be changed with the CONTAINER_KILL_ON_CLOSE flag. > > (4) Supervising the container. > > Given that we have an fd attached to the container, we could make it > such that the supervising process could monitor and override EPERM > returns for mount and other privileged operations within the > container. > > (5) Device restriction. > > Containers could come with a list of device IDs that the container is > allowed to open. Perhaps a list major numbers, each with a bitmap of > permitted minor numbers. > > (6) Per-container keyring. > > Each container could be given a per-container keyring for the holding > of integrity keys and filesystem keys. This list would be only > modifiable by the container's 'root' user and the supervisor process: > > container_add_key(const char *type, const char *description, > const void *payload, size_t plen, > int container_fd); > > The keys on the keyring would, however, be accessible/usable by all > processes within the keyring. > > > =============== > EXAMPLE PROGRAM > =============== > > #include <stdio.h> > #include <stdlib.h> > #include <unistd.h> > #include <sys/wait.h> > > #define CONTAINER_NEW_FS_NS 0x00000001 /* Dup current fs namespace */ > #define CONTAINER_NEW_EMPTY_FS_NS 0x00000002 /* Provide new empty fs namespace */ > #define CONTAINER_NEW_CGROUP_NS 0x00000004 /* Dup current cgroup namespace [priv] */ > #define CONTAINER_NEW_UTS_NS 0x00000008 /* Dup current uts namespace */ > #define CONTAINER_NEW_IPC_NS 0x00000010 /* Dup current ipc namespace */ > #define CONTAINER_NEW_USER_NS 0x00000020 /* Dup current user namespace */ > #define CONTAINER_NEW_PID_NS 0x00000040 /* Dup current pid namespace */ > #define CONTAINER_NEW_NET_NS 0x00000080 /* Dup current net namespace */ > #define CONTAINER_KILL_ON_CLOSE 0x00000100 /* Kill all member processes when fd closed */ > #define CONTAINER_FD_CLOEXEC 0x00000200 /* Close the fd on exec */ > #define CONTAINER__FLAG_MASK 0x000003ff > > static inline int container_create(const char *name, unsigned int mask) > { > return syscall(333, name, mask, 0, 0, 0); > } > > static inline int fork_into_container(int containerfd) > { > return syscall(334, containerfd); > } > > int main() > { > pid_t pid; > int fd, ws; > > fd = container_create("foo-test", > CONTAINER__FLAG_MASK & ~( > CONTAINER_NEW_EMPTY_FS_NS | > CONTAINER_NEW_CGROUP_NS)); > if (fd == -1) { > perror("container_create"); > exit(1); > } > > system("cat /proc/containers"); > > switch ((pid = fork_into_container(fd))) { > case -1: > perror("fork_into_container"); > exit(1); > case 0: > close(fd); > setenv("PS1", "container>", 1); > execl("/bin/bash", "bash", NULL); > perror("execl"); > exit(1); > default: > if (waitpid(pid, &ws, 0) < 0) { > perror("waitpid"); > exit(1); > } > } > close(fd); > exit(0); > } > > Signed-off-by: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> > --- > > arch/x86/entry/syscalls/syscall_32.tbl | 1 > arch/x86/entry/syscalls/syscall_64.tbl | 1 > fs/namespace.c | 5 > include/linux/container.h | 85 ++++++ > include/linux/init_task.h | 4 > include/linux/lsm_hooks.h | 21 + > include/linux/sched.h | 3 > include/linux/security.h | 15 + > include/linux/syscalls.h | 3 > include/uapi/linux/container.h | 28 ++ > include/uapi/linux/magic.h | 1 > init/Kconfig | 7 > kernel/Makefile | 2 > kernel/container.c | 462 ++++++++++++++++++++++++++++++++ > kernel/exit.c | 1 > kernel/fork.c | 7 > kernel/namespaces.h | 15 + > kernel/nsproxy.c | 23 +- > kernel/sys_ni.c | 4 > security/security.c | 13 + > 20 files changed, 688 insertions(+), 13 deletions(-) > create mode 100644 include/linux/container.h > create mode 100644 include/uapi/linux/container.h > create mode 100644 kernel/container.c > create mode 100644 kernel/namespaces.h > > diff --git a/arch/x86/entry/syscalls/syscall_32.tbl b/arch/x86/entry/syscalls/syscall_32.tbl > index abe6ea95e0e6..9ccd0f52f874 100644 > --- a/arch/x86/entry/syscalls/syscall_32.tbl > +++ b/arch/x86/entry/syscalls/syscall_32.tbl > @@ -393,3 +393,4 @@ > 384 i386 arch_prctl sys_arch_prctl compat_sys_arch_prctl > 385 i386 fsopen sys_fsopen > 386 i386 fsmount sys_fsmount > +387 i386 container_create sys_container_create > diff --git a/arch/x86/entry/syscalls/syscall_64.tbl b/arch/x86/entry/syscalls/syscall_64.tbl > index 0977c5079831..dab92591511e 100644 > --- a/arch/x86/entry/syscalls/syscall_64.tbl > +++ b/arch/x86/entry/syscalls/syscall_64.tbl > @@ -341,6 +341,7 @@ > 332 common statx sys_statx > 333 common fsopen sys_fsopen > 334 common fsmount sys_fsmount > +335 common container_create sys_container_create > > # > # x32-specific system call numbers start at 512 to avoid cache impact > diff --git a/fs/namespace.c b/fs/namespace.c > index 4e9ad16db79c..7e2d5fe5728b 100644 > --- a/fs/namespace.c > +++ b/fs/namespace.c > @@ -28,6 +28,7 @@ > #include <linux/file.h> > #include <linux/sched/task.h> > #include <linux/sb_config.h> > +#include <linux/container.h> > > #include "pnode.h" > #include "internal.h" > @@ -3510,6 +3511,10 @@ static void __init init_mount_tree(void) > > set_fs_pwd(current->fs, &root); > set_fs_root(current->fs, &root); > +#ifdef CONFIG_CONTAINERS > + path_get(&root); > + init_container.root = root; > +#endif > } > > void __init mnt_init(void) > diff --git a/include/linux/container.h b/include/linux/container.h > new file mode 100644 > index 000000000000..084ea9982fe6 > --- /dev/null > +++ b/include/linux/container.h > @@ -0,0 +1,85 @@ > +/* Container objects > + * > + * Copyright (C) 2017 Red Hat, Inc. All Rights Reserved. > + * Written by David Howells (dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org) > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public Licence > + * as published by the Free Software Foundation; either version > + * 2 of the Licence, or (at your option) any later version. > + */ > + > +#ifndef _LINUX_CONTAINER_H > +#define _LINUX_CONTAINER_H > + > +#include <uapi/linux/container.h> > +#include <linux/refcount.h> > +#include <linux/list.h> > +#include <linux/spinlock.h> > +#include <linux/wait.h> > +#include <linux/path.h> > +#include <linux/seqlock.h> > + > +struct fs_struct; > +struct nsproxy; > +struct task_struct; > + > +/* > + * The container object. > + */ > +struct container { > + char name[24]; > + refcount_t usage; > + int exit_code; /* The exit code of 'init' */ > + const struct cred *cred; /* Creds for this container, including userns */ > + struct nsproxy *ns; /* This container's namespaces */ > + struct path root; /* The root of the container's fs namespace */ > + struct task_struct *init; /* The 'init' task for this container */ > + struct container *parent; /* Parent of this container. */ > + void *security; /* LSM data */ > + struct list_head members; /* Member processes, guarded with ->lock */ > + struct list_head child_link; /* Link in parent->children */ > + struct list_head children; /* Child containers */ > + wait_queue_head_t waitq; /* Someone waiting for init to exit waits here */ > + unsigned long flags; > +#define CONTAINER_FLAG_INIT_STARTED 0 /* Init is started - certain ops now prohibited */ > +#define CONTAINER_FLAG_DEAD 1 /* Init has died */ > +#define CONTAINER_FLAG_KILL_ON_CLOSE 2 /* Kill init if container handle closed */ > + spinlock_t lock; > + seqcount_t seq; /* Track changes in ->root */ > +}; > + > +extern struct container init_container; > + > +#ifdef CONFIG_CONTAINERS > +extern const struct file_operations containerfs_fops; > + > +extern int copy_container(unsigned long flags, struct task_struct *tsk, > + struct container *container); > +extern void exit_container(struct task_struct *tsk); > +extern void put_container(struct container *c); > + > +static inline struct container *get_container(struct container *c) > +{ > + refcount_inc(&c->usage); > + return c; > +} > + > +static inline bool is_container_file(struct file *file) > +{ > + return file->f_op == &containerfs_fops; > +} > + > +#else > + > +static inline int copy_container(unsigned long flags, struct task_struct *tsk, > + struct container *container) > +{ return 0; } > +static inline void exit_container(struct task_struct *tsk) { } > +static inline void put_container(struct container *c) {} > +static inline struct container *get_container(struct container *c) { return NULL; } > +static inline bool is_container_file(struct file *file) { return false; } > + > +#endif /* CONFIG_CONTAINERS */ > + > +#endif /* _LINUX_CONTAINER_H */ > diff --git a/include/linux/init_task.h b/include/linux/init_task.h > index e049526bc188..488385ad79db 100644 > --- a/include/linux/init_task.h > +++ b/include/linux/init_task.h > @@ -9,6 +9,7 @@ > #include <linux/ipc.h> > #include <linux/pid_namespace.h> > #include <linux/user_namespace.h> > +#include <linux/container.h> > #include <linux/securebits.h> > #include <linux/seqlock.h> > #include <linux/rbtree.h> > @@ -273,6 +274,9 @@ extern struct cred init_cred; > .signal = &init_signals, \ > .sighand = &init_sighand, \ > .nsproxy = &init_nsproxy, \ > + .container = &init_container, \ > + .container_link.next = &init_container.members, \ > + .container_link.prev = &init_container.members, \ > .pending = { \ > .list = LIST_HEAD_INIT(tsk.pending.list), \ > .signal = {{0}}}, \ > diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h > index 7064c0c15386..7b0d484a6a25 100644 > --- a/include/linux/lsm_hooks.h > +++ b/include/linux/lsm_hooks.h > @@ -1368,6 +1368,17 @@ > * @inode we wish to get the security context of. > * @ctx is a pointer in which to place the allocated security context. > * @ctxlen points to the place to put the length of @ctx. > + * > + * Security hooks for containers: > + * > + * @container_alloc: > + * Permit creation of a new container and assign security data. > + * @container: The new container. > + * > + * @container_free: > + * Free security data attached to a container. > + * @container: The container. > + * > * This is the main security structure. > */ > > @@ -1699,6 +1710,12 @@ union security_list_options { > struct audit_context *actx); > void (*audit_rule_free)(void *lsmrule); > #endif /* CONFIG_AUDIT */ > + > + /* Container management security hooks */ > +#ifdef CONFIG_CONTAINERS > + int (*container_alloc)(struct container *container, unsigned int flags); > + void (*container_free)(struct container *container); > +#endif > }; > > struct security_hook_heads { > @@ -1919,6 +1936,10 @@ struct security_hook_heads { > struct list_head audit_rule_match; > struct list_head audit_rule_free; > #endif /* CONFIG_AUDIT */ > +#ifdef CONFIG_CONTAINERS > + struct list_head container_alloc; > + struct list_head container_free; > +#endif /* CONFIG_CONTAINERS */ > }; > > /* > diff --git a/include/linux/sched.h b/include/linux/sched.h > index eba196521562..d9b92a98f99f 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -33,6 +33,7 @@ struct backing_dev_info; > struct bio_list; > struct blk_plug; > struct cfs_rq; > +struct container; > struct fs_struct; > struct futex_pi_state; > struct io_context; > @@ -741,6 +742,8 @@ struct task_struct { > > /* Namespaces: */ > struct nsproxy *nsproxy; > + struct container *container; > + struct list_head container_link; > > /* Signal handlers: */ > struct signal_struct *signal; > diff --git a/include/linux/security.h b/include/linux/security.h > index 8c06e158c195..01bdf7637ec6 100644 > --- a/include/linux/security.h > +++ b/include/linux/security.h > @@ -68,6 +68,7 @@ struct ctl_table; > struct audit_krule; > struct user_namespace; > struct timezone; > +struct container; > > /* These functions are in security/commoncap.c */ > extern int cap_capable(const struct cred *cred, struct user_namespace *ns, > @@ -1672,6 +1673,20 @@ static inline void security_audit_rule_free(void *lsmrule) > #endif /* CONFIG_SECURITY */ > #endif /* CONFIG_AUDIT */ > > +#ifdef CONFIG_CONTAINERS > +#ifdef CONFIG_SECURITY > +int security_container_alloc(struct container *container, unsigned int flags); > +void security_container_free(struct container *container); > +#else > +static inline int security_container_alloc(struct container *container, > + unsigned int flags) > +{ > + return 0; > +} > +static inline void security_container_free(struct container *container) {} > +#endif > +#endif /* CONFIG_CONTAINERS */ > + > #ifdef CONFIG_SECURITYFS > > extern struct dentry *securityfs_create_file(const char *name, umode_t mode, > diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h > index 07e4f775f24d..5a0324dd024c 100644 > --- a/include/linux/syscalls.h > +++ b/include/linux/syscalls.h > @@ -908,5 +908,8 @@ asmlinkage long sys_statx(int dfd, const char __user *path, unsigned flags, > asmlinkage long sys_fsopen(const char *fs_name, int containerfd, unsigned int flags); > asmlinkage long sys_fsmount(int fsfd, int dfd, const char *path, unsigned int at_flags, > unsigned int flags); > +asmlinkage long sys_container_create(const char __user *name, unsigned int flags, > + unsigned long spare3, unsigned long spare4, > + unsigned long spare5); > > #endif > diff --git a/include/uapi/linux/container.h b/include/uapi/linux/container.h > new file mode 100644 > index 000000000000..43748099b28d > --- /dev/null > +++ b/include/uapi/linux/container.h > @@ -0,0 +1,28 @@ > +/* Container UAPI > + * > + * Copyright (C) 2017 Red Hat, Inc. All Rights Reserved. > + * Written by David Howells (dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org) > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public Licence > + * as published by the Free Software Foundation; either version > + * 2 of the Licence, or (at your option) any later version. > + */ > + > +#ifndef _UAPI_LINUX_CONTAINER_H > +#define _UAPI_LINUX_CONTAINER_H > + > + > +#define CONTAINER_NEW_FS_NS 0x00000001 /* Dup current fs namespace */ > +#define CONTAINER_NEW_EMPTY_FS_NS 0x00000002 /* Provide new empty fs namespace */ > +#define CONTAINER_NEW_CGROUP_NS 0x00000004 /* Dup current cgroup namespace */ > +#define CONTAINER_NEW_UTS_NS 0x00000008 /* Dup current uts namespace */ > +#define CONTAINER_NEW_IPC_NS 0x00000010 /* Dup current ipc namespace */ > +#define CONTAINER_NEW_USER_NS 0x00000020 /* Dup current user namespace */ > +#define CONTAINER_NEW_PID_NS 0x00000040 /* Dup current pid namespace */ > +#define CONTAINER_NEW_NET_NS 0x00000080 /* Dup current net namespace */ > +#define CONTAINER_KILL_ON_CLOSE 0x00000100 /* Kill all member processes when fd closed */ > +#define CONTAINER_FD_CLOEXEC 0x00000200 /* Close the fd on exec */ > +#define CONTAINER__FLAG_MASK 0x000003ff > + > +#endif /* _UAPI_LINUX_CONTAINER_H */ > diff --git a/include/uapi/linux/magic.h b/include/uapi/linux/magic.h > index 88ae83492f7c..758705412b44 100644 > --- a/include/uapi/linux/magic.h > +++ b/include/uapi/linux/magic.h > @@ -85,5 +85,6 @@ > #define BALLOON_KVM_MAGIC 0x13661366 > #define ZSMALLOC_MAGIC 0x58295829 > #define FS_FS_MAGIC 0x66736673 > +#define CONTAINERFS_MAGIC 0x636f6e74 > > #endif /* __LINUX_MAGIC_H__ */ > diff --git a/init/Kconfig b/init/Kconfig > index 1d3475fc9496..3a0ee88df6c8 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -1288,6 +1288,13 @@ config NET_NS > Allow user space to create what appear to be multiple instances > of the network stack. > > +config CONTAINERS > + bool "Container support" > + default y > + help > + Allow userspace to create and manipulate containers as objects that > + have namespaces and hold a set of processes. > + > endif # NAMESPACES > > config SCHED_AUTOGROUP > diff --git a/kernel/Makefile b/kernel/Makefile > index 72aa080f91f0..117479b05fb1 100644 > --- a/kernel/Makefile > +++ b/kernel/Makefile > @@ -7,7 +7,7 @@ obj-y = fork.o exec_domain.o panic.o \ > sysctl.o sysctl_binary.o capability.o ptrace.o user.o \ > signal.o sys.o kmod.o workqueue.o pid.o task_work.o \ > extable.o params.o \ > - kthread.o sys_ni.o nsproxy.o \ > + kthread.o sys_ni.o nsproxy.o container.o \ > notifier.o ksysfs.o cred.o reboot.o \ > async.o range.o smpboot.o ucount.o > > diff --git a/kernel/container.c b/kernel/container.c > new file mode 100644 > index 000000000000..eef1566835eb > --- /dev/null > +++ b/kernel/container.c > @@ -0,0 +1,462 @@ > +/* Implement container objects. > + * > + * Copyright (C) 2017 Red Hat, Inc. All Rights Reserved. > + * Written by David Howells (dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org) > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public Licence > + * as published by the Free Software Foundation; either version > + * 2 of the Licence, or (at your option) any later version. > + */ > + > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > +#include <linux/poll.h> > +#include <linux/wait.h> > +#include <linux/init_task.h> > +#include <linux/fs.h> > +#include <linux/fs_struct.h> > +#include <linux/mount.h> > +#include <linux/file.h> > +#include <linux/container.h> > +#include <linux/magic.h> > +#include <linux/syscalls.h> > +#include <linux/printk.h> > +#include <linux/security.h> > +#include "namespaces.h" > + > +struct container init_container = { > + .name = ".init", > + .usage = REFCOUNT_INIT(2), > + .cred = &init_cred, > + .ns = &init_nsproxy, > + .init = &init_task, > + .members.next = &init_task.container_link, > + .members.prev = &init_task.container_link, > + .children = LIST_HEAD_INIT(init_container.children), > + .flags = (1 << CONTAINER_FLAG_INIT_STARTED), > + .lock = __SPIN_LOCK_UNLOCKED(init_container.lock), > + .seq = SEQCNT_ZERO(init_fs.seq), > +}; > + > +#ifdef CONFIG_CONTAINERS > + > +static struct vfsmount *containerfs_mnt __read_mostly; > + > +/* > + * Drop a ref on a container and clear it if no longer in use. > + */ > +void put_container(struct container *c) > +{ > + struct container *parent; > + > + while (c && refcount_dec_and_test(&c->usage)) { > + BUG_ON(!list_empty(&c->members)); > + if (c->ns) > + put_nsproxy(c->ns); > + path_put(&c->root); > + > + parent = c->parent; > + if (parent) { > + spin_lock(&parent->lock); > + list_del(&c->child_link); > + spin_unlock(&parent->lock); > + } > + > + if (c->cred) > + put_cred(c->cred); > + security_container_free(c); > + kfree(c); > + c = parent; > + } > +} > + > +/* > + * Allow the user to poll for the container dying. > + */ > +static unsigned int containerfs_poll(struct file *file, poll_table *wait) > +{ > + struct container *container = file->private_data; > + unsigned int mask = 0; > + > + poll_wait(file, &container->waitq, wait); > + > + if (test_bit(CONTAINER_FLAG_DEAD, &container->flags)) > + mask |= POLLHUP; > + > + return mask; > +} > + > +static int containerfs_release(struct inode *inode, struct file *file) > +{ > + struct container *container = file->private_data; > + > + put_container(container); > + return 0; > +} > + > +const struct file_operations containerfs_fops = { > + .poll = containerfs_poll, > + .release = containerfs_release, > +}; > + > +/* > + * Indicate the name we want to display the container file as. > + */ > +static char *containerfs_dname(struct dentry *dentry, char *buffer, int buflen) > +{ > + return dynamic_dname(dentry, buffer, buflen, "container:[%lu]", > + d_inode(dentry)->i_ino); > +} > + > +static const struct dentry_operations containerfs_dentry_operations = { > + .d_dname = containerfs_dname, > +}; > + > +/* > + * Allocate a container. > + */ > +static struct container *alloc_container(const char __user *name) > +{ > + struct container *c; > + long len; > + int ret; > + > + c = kzalloc(sizeof(struct container), GFP_KERNEL); > + if (!c) > + return ERR_PTR(-ENOMEM); > + > + INIT_LIST_HEAD(&c->members); > + INIT_LIST_HEAD(&c->children); > + init_waitqueue_head(&c->waitq); > + spin_lock_init(&c->lock); > + refcount_set(&c->usage, 1); > + > + ret = -EFAULT; > + len = strncpy_from_user(c->name, name, sizeof(c->name)); > + if (len < 0) > + goto err; > + ret = -ENAMETOOLONG; > + if (len >= sizeof(c->name)) > + goto err; > + ret = -EINVAL; > + if (strchr(c->name, '/')) > + goto err; > + > + c->name[len] = 0; > + return c; > + > +err: > + kfree(c); > + return ERR_PTR(ret); > +} > + > +/* > + * Create a supervisory file for a new container > + */ > +static struct file *create_container_file(struct container *c) > +{ > + struct inode *inode; > + struct file *f; > + struct path path; > + int ret; > + > + inode = alloc_anon_inode(containerfs_mnt->mnt_sb); > + if (!inode) > + return ERR_PTR(-ENFILE); > + inode->i_fop = &containerfs_fops; > + > + ret = -ENOMEM; > + path.dentry = d_alloc_pseudo(containerfs_mnt->mnt_sb, &empty_name); > + if (!path.dentry) > + goto err_inode; > + path.mnt = mntget(containerfs_mnt); > + > + d_instantiate(path.dentry, inode); > + > + f = alloc_file(&path, 0, &containerfs_fops); > + if (IS_ERR(f)) { > + ret = PTR_ERR(f); > + goto err_file; > + } > + > + f->private_data = c; > + return f; > + > +err_file: > + path_put(&path); > + return ERR_PTR(ret); > + > +err_inode: > + iput(inode); > + return ERR_PTR(ret); > +} > + > +static const struct super_operations containerfs_ops = { > + .drop_inode = generic_delete_inode, > + .destroy_inode = free_inode_nonrcu, > + .statfs = simple_statfs, > +}; > + > +/* > + * containerfs should _never_ be mounted by userland - too much of security > + * hassle, no real gain from having the whole whorehouse mounted. So we don't > + * need any operations on the root directory. However, we need a non-trivial > + * d_name - container: will go nicely and kill the special-casing in procfs. > + */ > +static struct dentry *containerfs_mount(struct file_system_type *fs_type, > + int flags, const char *dev_name, > + void *data) > +{ > + return mount_pseudo(fs_type, "container:", &containerfs_ops, > + &containerfs_dentry_operations, CONTAINERFS_MAGIC); > +} > + > +static struct file_system_type container_fs_type = { > + .name = "containerfs", > + .mount = containerfs_mount, > + .kill_sb = kill_anon_super, > +}; > + > +static int __init init_container_fs(void) > +{ > + int ret; > + > + ret = register_filesystem(&container_fs_type); > + if (ret < 0) > + panic("Cannot register containerfs\n"); > + > + containerfs_mnt = kern_mount(&container_fs_type); > + if (IS_ERR(containerfs_mnt)) > + panic("Cannot mount containerfs: %ld\n", > + PTR_ERR(containerfs_mnt)); > + > + return 0; > +} > + > +fs_initcall(init_container_fs); > + > +/* > + * Handle fork/clone. > + * > + * A process inherits its parent's container. The first process into the > + * container is its 'init' process and the life of everything else in there is > + * dependent upon that. > + */ > +int copy_container(unsigned long flags, struct task_struct *tsk, > + struct container *container) > +{ > + struct container *c = container ?: tsk->container; > + int ret = -ECANCELED; > + > + spin_lock(&c->lock); > + > + if (!test_bit(CONTAINER_FLAG_DEAD, &c->flags)) { > + list_add_tail(&tsk->container_link, &c->members); > + get_container(c); > + tsk->container = c; > + if (!c->init) { > + set_bit(CONTAINER_FLAG_INIT_STARTED, &c->flags); > + c->init = tsk; > + } > + ret = 0; > + } > + > + spin_unlock(&c->lock); > + return ret; > +} > + > +/* > + * Remove a dead process from a container. > + * > + * If the 'init' process in a container dies, we kill off all the other > + * processes in the container. > + */ > +void exit_container(struct task_struct *tsk) > +{ > + struct task_struct *p; > + struct container *c = tsk->container; > + struct siginfo si = { > + .si_signo = SIGKILL, > + .si_code = SI_KERNEL, > + }; > + > + spin_lock(&c->lock); > + > + list_del(&tsk->container_link); > + > + if (c->init == tsk) { > + c->init = NULL; > + c->exit_code = tsk->exit_code; > + smp_wmb(); /* Order exit_code vs CONTAINER_DEAD. */ > + set_bit(CONTAINER_FLAG_DEAD, &c->flags); > + wake_up_bit(&c->flags, CONTAINER_FLAG_DEAD); > + > + list_for_each_entry(p, &c->members, container_link) { > + si.si_pid = task_tgid_vnr(p); > + send_sig_info(SIGKILL, &si, p); > + } > + } > + > + spin_unlock(&c->lock); > + put_container(c); > +} > + > +/* > + * Create some creds for the container. We don't want to pin things we don't > + * have to, so drop all keyrings from the new cred. The LSM gets to audit the > + * cred struct when security_container_alloc() is invoked. > + */ > +static const struct cred *create_container_creds(unsigned int flags) > +{ > + struct cred *new; > + int ret; > + > + new = prepare_creds(); > + if (!new) > + return ERR_PTR(-ENOMEM); > + > +#ifdef CONFIG_KEYS > + key_put(new->thread_keyring); > + new->thread_keyring = NULL; > + key_put(new->process_keyring); > + new->process_keyring = NULL; > + key_put(new->session_keyring); > + new->session_keyring = NULL; > + key_put(new->request_key_auth); > + new->request_key_auth = NULL; > +#endif > + > + if (flags & CONTAINER_NEW_USER_NS) { > + ret = create_user_ns(new); > + if (ret < 0) > + goto err; > + new->euid = new->user_ns->owner; > + new->egid = new->user_ns->group; > + } > + > + new->fsuid = new->suid = new->uid = new->euid; > + new->fsgid = new->sgid = new->gid = new->egid; > + return new; > + > +err: > + abort_creds(new); > + return ERR_PTR(ret); > +} > + > +/* > + * Create a new container. > + */ > +static struct container *create_container(const char *name, unsigned int flags) > +{ > + struct container *parent, *c; > + struct fs_struct *fs; > + struct nsproxy *ns; > + const struct cred *cred; > + int ret; > + > + c = alloc_container(name); > + if (IS_ERR(c)) > + return c; > + > + if (flags & CONTAINER_KILL_ON_CLOSE) > + __set_bit(CONTAINER_FLAG_KILL_ON_CLOSE, &c->flags); > + > + cred = create_container_creds(flags); > + if (IS_ERR(cred)) { > + ret = PTR_ERR(cred); > + goto err_cont; > + } > + c->cred = cred; > + > + ret = -ENOMEM; > + fs = copy_fs_struct(current->fs); > + if (!fs) > + goto err_cont; > + > + ns = create_new_namespaces( > + (flags & CONTAINER_NEW_FS_NS ? CLONE_NEWNS : 0) | > + (flags & CONTAINER_NEW_CGROUP_NS ? CLONE_NEWCGROUP : 0) | > + (flags & CONTAINER_NEW_UTS_NS ? CLONE_NEWUTS : 0) | > + (flags & CONTAINER_NEW_IPC_NS ? CLONE_NEWIPC : 0) | > + (flags & CONTAINER_NEW_PID_NS ? CLONE_NEWPID : 0) | > + (flags & CONTAINER_NEW_NET_NS ? CLONE_NEWNET : 0), > + current->nsproxy, cred->user_ns, fs); > + if (IS_ERR(ns)) { > + ret = PTR_ERR(ns); > + goto err_fs; > + } > + > + c->ns = ns; > + c->root = fs->root; > + c->seq = fs->seq; > + fs->root.mnt = NULL; > + fs->root.dentry = NULL; > + > + ret = security_container_alloc(c, flags); > + if (ret < 0) > + goto err_fs; > + > + parent = current->container; > + get_container(parent); > + c->parent = parent; > + spin_lock(&parent->lock); > + list_add_tail(&c->child_link, &parent->children); > + spin_unlock(&parent->lock); > + return c; > + > +err_fs: > + free_fs_struct(fs); > +err_cont: > + put_container(c); > + return ERR_PTR(ret); > +} > + > +/* > + * Create a new container object. > + */ > +SYSCALL_DEFINE5(container_create, > + const char __user *, name, > + unsigned int, flags, > + unsigned long, spare3, > + unsigned long, spare4, > + unsigned long, spare5) > +{ > + struct container *c; > + struct file *f; > + int ret, fd; > + > + if (!name || > + flags & ~CONTAINER__FLAG_MASK || > + spare3 != 0 || spare4 != 0 || spare5 != 0) > + return -EINVAL; > + if ((flags & (CONTAINER_NEW_FS_NS | CONTAINER_NEW_EMPTY_FS_NS)) == > + (CONTAINER_NEW_FS_NS | CONTAINER_NEW_EMPTY_FS_NS)) > + return -EINVAL; > + > + c = create_container(name, flags); > + if (IS_ERR(c)) > + return PTR_ERR(c); > + > + f = create_container_file(c); > + if (IS_ERR(f)) { > + ret = PTR_ERR(f); > + goto err_cont; > + } > + > + ret = get_unused_fd_flags(flags & CONTAINER_FD_CLOEXEC ? O_CLOEXEC : 0); > + if (ret < 0) > + goto err_file; > + > + fd = ret; > + fd_install(fd, f); > + return fd; > + > +err_file: > + fput(f); > + return ret; > +err_cont: > + put_container(c); > + return ret; > +} > + > +#endif /* CONFIG_CONTAINERS */ > diff --git a/kernel/exit.c b/kernel/exit.c > index 31b8617aee04..1ff87f7e40a2 100644 > --- a/kernel/exit.c > +++ b/kernel/exit.c > @@ -875,6 +875,7 @@ void __noreturn do_exit(long code) > if (group_dead) > disassociate_ctty(1); > exit_task_namespaces(tsk); > + exit_container(tsk); > exit_task_work(tsk); > exit_thread(tsk); > > diff --git a/kernel/fork.c b/kernel/fork.c > index aec6672d3f0e..ff2779426fe9 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -1728,9 +1728,12 @@ static __latent_entropy struct task_struct *copy_process( > retval = copy_namespaces(clone_flags, p); > if (retval) > goto bad_fork_cleanup_mm; > - retval = copy_io(clone_flags, p); > + retval = copy_container(clone_flags, p, NULL); > if (retval) > goto bad_fork_cleanup_namespaces; > + retval = copy_io(clone_flags, p); > + if (retval) > + goto bad_fork_cleanup_container; > retval = copy_thread_tls(clone_flags, stack_start, stack_size, p, tls); > if (retval) > goto bad_fork_cleanup_io; > @@ -1918,6 +1921,8 @@ static __latent_entropy struct task_struct *copy_process( > bad_fork_cleanup_io: > if (p->io_context) > exit_io_context(p); > +bad_fork_cleanup_container: > + exit_container(p); > bad_fork_cleanup_namespaces: > exit_task_namespaces(p); > bad_fork_cleanup_mm: > diff --git a/kernel/namespaces.h b/kernel/namespaces.h > new file mode 100644 > index 000000000000..c44e3cf0e254 > --- /dev/null > +++ b/kernel/namespaces.h > @@ -0,0 +1,15 @@ > +/* Local namespaces defs > + * > + * Copyright (C) 2017 Red Hat, Inc. All Rights Reserved. > + * Written by David Howells (dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org) > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public Licence > + * as published by the Free Software Foundation; either version > + * 2 of the Licence, or (at your option) any later version. > + */ > + > +extern struct nsproxy *create_new_namespaces(unsigned long flags, > + struct nsproxy *nsproxy, > + struct user_namespace *user_ns, > + struct fs_struct *new_fs); > diff --git a/kernel/nsproxy.c b/kernel/nsproxy.c > index f6c5d330059a..4bb5184b3a80 100644 > --- a/kernel/nsproxy.c > +++ b/kernel/nsproxy.c > @@ -27,6 +27,7 @@ > #include <linux/syscalls.h> > #include <linux/cgroup.h> > #include <linux/perf_event.h> > +#include "namespaces.h" > > static struct kmem_cache *nsproxy_cachep; > > @@ -61,8 +62,8 @@ static inline struct nsproxy *create_nsproxy(void) > * Return the newly created nsproxy. Do not attach this to the task, > * leave it to the caller to do proper locking and attach it to task. > */ > -static struct nsproxy *create_new_namespaces(unsigned long flags, > - struct task_struct *tsk, struct user_namespace *user_ns, > +struct nsproxy *create_new_namespaces(unsigned long flags, > + struct nsproxy *nsproxy, struct user_namespace *user_ns, > struct fs_struct *new_fs) > { > struct nsproxy *new_nsp; > @@ -72,39 +73,39 @@ static struct nsproxy *create_new_namespaces(unsigned long flags, > if (!new_nsp) > return ERR_PTR(-ENOMEM); > > - new_nsp->mnt_ns = copy_mnt_ns(flags, tsk->nsproxy->mnt_ns, user_ns, new_fs); > + new_nsp->mnt_ns = copy_mnt_ns(flags, nsproxy->mnt_ns, user_ns, new_fs); > if (IS_ERR(new_nsp->mnt_ns)) { > err = PTR_ERR(new_nsp->mnt_ns); > goto out_ns; > } > > - new_nsp->uts_ns = copy_utsname(flags, user_ns, tsk->nsproxy->uts_ns); > + new_nsp->uts_ns = copy_utsname(flags, user_ns, nsproxy->uts_ns); > if (IS_ERR(new_nsp->uts_ns)) { > err = PTR_ERR(new_nsp->uts_ns); > goto out_uts; > } > > - new_nsp->ipc_ns = copy_ipcs(flags, user_ns, tsk->nsproxy->ipc_ns); > + new_nsp->ipc_ns = copy_ipcs(flags, user_ns, nsproxy->ipc_ns); > if (IS_ERR(new_nsp->ipc_ns)) { > err = PTR_ERR(new_nsp->ipc_ns); > goto out_ipc; > } > > new_nsp->pid_ns_for_children = > - copy_pid_ns(flags, user_ns, tsk->nsproxy->pid_ns_for_children); > + copy_pid_ns(flags, user_ns, nsproxy->pid_ns_for_children); > if (IS_ERR(new_nsp->pid_ns_for_children)) { > err = PTR_ERR(new_nsp->pid_ns_for_children); > goto out_pid; > } > > new_nsp->cgroup_ns = copy_cgroup_ns(flags, user_ns, > - tsk->nsproxy->cgroup_ns); > + nsproxy->cgroup_ns); > if (IS_ERR(new_nsp->cgroup_ns)) { > err = PTR_ERR(new_nsp->cgroup_ns); > goto out_cgroup; > } > > - new_nsp->net_ns = copy_net_ns(flags, user_ns, tsk->nsproxy->net_ns); > + new_nsp->net_ns = copy_net_ns(flags, user_ns, nsproxy->net_ns); > if (IS_ERR(new_nsp->net_ns)) { > err = PTR_ERR(new_nsp->net_ns); > goto out_net; > @@ -162,7 +163,7 @@ int copy_namespaces(unsigned long flags, struct task_struct *tsk) > (CLONE_NEWIPC | CLONE_SYSVSEM)) > return -EINVAL; > > - new_ns = create_new_namespaces(flags, tsk, user_ns, tsk->fs); > + new_ns = create_new_namespaces(flags, tsk->nsproxy, user_ns, tsk->fs); > if (IS_ERR(new_ns)) > return PTR_ERR(new_ns); > > @@ -203,7 +204,7 @@ int unshare_nsproxy_namespaces(unsigned long unshare_flags, > if (!ns_capable(user_ns, CAP_SYS_ADMIN)) > return -EPERM; > > - *new_nsp = create_new_namespaces(unshare_flags, current, user_ns, > + *new_nsp = create_new_namespaces(unshare_flags, current->nsproxy, user_ns, > new_fs ? new_fs : current->fs); > if (IS_ERR(*new_nsp)) { > err = PTR_ERR(*new_nsp); > @@ -251,7 +252,7 @@ SYSCALL_DEFINE2(setns, int, fd, int, nstype) > if (nstype && (ns->ops->type != nstype)) > goto out; > > - new_nsproxy = create_new_namespaces(0, tsk, current_user_ns(), tsk->fs); > + new_nsproxy = create_new_namespaces(0, tsk->nsproxy, current_user_ns(), tsk->fs); > if (IS_ERR(new_nsproxy)) { > err = PTR_ERR(new_nsproxy); > goto out; > diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c > index a0fe764bd5dd..99b1e1f58d05 100644 > --- a/kernel/sys_ni.c > +++ b/kernel/sys_ni.c > @@ -262,3 +262,7 @@ cond_syscall(sys_pkey_free); > /* fd-based mount */ > cond_syscall(sys_fsopen); > cond_syscall(sys_fsmount); > + > +/* Containers */ > +cond_syscall(sys_container_create); > + > diff --git a/security/security.c b/security/security.c > index f4136ca5cb1b..b5c5b5ae1266 100644 > --- a/security/security.c > +++ b/security/security.c > @@ -1668,3 +1668,16 @@ int security_audit_rule_match(u32 secid, u32 field, u32 op, void *lsmrule, > actx); > } > #endif /* CONFIG_AUDIT */ > + > +#ifdef CONFIG_CONTAINERS > + > +int security_container_alloc(struct container *container, unsigned int flags) > +{ > + return call_int_hook(container_alloc, 0, container, flags); > +} > + > +void security_container_free(struct container *container) > +{ > + call_void_hook(container_free, container); > +} > +#endif /* CONFIG_CONTAINERS */ - RGB -- Richard Guy Briggs <rgb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635 ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <20170814054711.GB29957@madcap2.tricolour.ca>]
[parent not found: <20170814054711.GB29957-bcJWsdo4jJjeVoXN4CMphl7TgLCtbB0G@public.gmane.org>]
* Re: [PATCH 2/9] Implement containers as kernel objects [not found] ` <20170814054711.GB29957-bcJWsdo4jJjeVoXN4CMphl7TgLCtbB0G@public.gmane.org> @ 2017-08-16 22:21 ` Paul Moore 0 siblings, 0 replies; 25+ messages in thread From: Paul Moore @ 2017-08-16 22:21 UTC (permalink / raw) To: Richard Guy Briggs Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, ebiederm-aS9lmoZGLiVWk0Htik3J/w, jlayton-H+wXaHxf7aLQT0dZR+AlfA, linux-api-u79uwXL29TY76Z2rM5mHXA, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, David Howells, linux-audit-H+wXaHxf7aLQT0dZR+AlfA, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, luto-DgEjT+Ai2ygdnm+yROfE0A, trondmy-7I+n7zu2hftEKMMhf/gKZA, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, cgroups-u79uwXL29TY76Z2rM5mHXA On Mon, Aug 14, 2017 at 1:47 AM, Richard Guy Briggs <rgb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote: > Hi David, > > I wanted to respond to this thread to attempt some constructive feedback, > better late than never. I had a look at your fsopen/fsmount() patchset(s) to > support this patchset which was interesting, but doesn't directly affect my > work. The primary patch of interest to the audit kernel folks (Paul Moore and > me) is this patch while the rest of the patchset is interesting, but not likely > to directly affect us. This patch has most of what we need to solve our > problem. > > Paul and I agree that audit is going to have a difficult time identifying > containers or even namespaces without some change to the kernel. The audit > subsystem in the kernel needs at least a basic clue about which container > caused an event to be able to report this at the appropriate level and ignore > it at other levels to avoid a DoS. While there is some increased risk of "death by audit", this is really only an issue once we start supporting multiple audit daemons; simply associating auditable events with the container that triggered them shouldn't add any additional overhead (I hope). For a number of use cases, a single auditd running outside the containers, but recording all their events with some type of container attribution will be sufficient. This is step #1. However, we will obviously want to go a bit further and support multiple audit daemons on the system to allow containers to record/process their own events (side note: the non-container auditd instance will still see all the events). There are a number of ways we could tackle this, both via in-kernel and in-userspace record routing, each with their own pros/cons. However, how this works is going to be dependent on how we identify containers and track their audit events: the bits from step #1. For this reason I'm not really interested in worrying about the multiple auditd problem just yet; it's obviously important, and something to keep in mind while working up a solution, but it isn't something we should focus on right now. > We also agree that there will need to be some sort of trigger from userspace to > indicate the creation of a container and its allocated resources and we're not > really picky how that is done, such as a clone flag, a syscall or a sysfs write > (or even a read, I suppose), but there will need to be some permission > restrictions, obviously. (I'd like to see capabilities used for this by adding > a specific container bit to the capabilities bitmask.) To be clear, from an audit perspective I think the only thing we would really care about controlling access to is the creation and assignment of a new audit container ID/token, not necessarily the container itself. It's a small point, but an important one I think. > I doubt we will be able to accomodate all definitions or concepts of a > container in a timely fashion. We'll need to start somewhere with a minimum > definition so that we can get traction and actually move forward before another > compelling shared kernel microservice method leaves our entire community > behind. I'd like to declare that a container is a full set of cloned > namespaces, but this is inefficient, overly constricting and unnecessary for > our needs. If we could agree on a minimum definition of a container (which may > have only one specific cloned namespace) then we have something on which to > build. I could even see a container being defined by a trigger sent from > userspace about a process (task) from which all its children are considered to > be within that container, subject to further nesting. I really would prefer if we could avoid defining the term "container". Even if we manage to get it right at this particular moment, we will surely be made fools a year or two from now when things change. At the very least lets avoid a rigid definition of container, I'll concede that we will probably need to have some definition simply so we can implement something, I just don't want the design or implementation to depend on a particular definition. This comment is jumping ahead a bit, but from an audit perspective I think we handle this by emitting an audit record whenever a container ID is created which describes it as the kernel sees it; as of now that probably means a list of namespace IDs. Richard mentions this in his email, I just wanted to make it clear that I think we should see this as a flexible mechanism. At the very least we will likely see a few more namespaces before the world moves on from containers. > In the simplest usable model for audit, if a container (definition implies and) > starts a PID namespace, then the container ID could simply be the container's > "init" process PID in the initial PID namespace. This assumes that as soon as > that process vanishes, that entire container and all its children are killed > off (which you've done). There may be some container orchestration systems > that don't use a unique PID namespace per container and that imposing this will > cause them challenges. I don't follow how this would cause challenges if the containers do not use a unique PID namespace; you are suggesting using the PID from in the context of the initial PID namespace, yes? Regardless, I do worry that using a PID could potentially be a bit racy once we start jumping between kernel and userspace (audit configuration, logs, etc.). > If containers have at minimum a unique mount namespace then the root path > dentry inode device and inode number could be used, but there are likely better > identifiers. Again, there may be container orchestrators that don't use a > unique mount namespace per container and that imposing this will cause > challenges. > > I expect there are similar examples for each of the other namespaces. The PID case is a bit unique as each process is going to have a unique PID regardless of namespaces, but even that has some drawbacks as discussed above. As for the other namespaces, I agree that we can't rely on them (see my earlier comments). > If we could pick one namespace type for consensus for which each container has > a unique instance of that namespace, we could use the dev/ino tuple from that > namespace as had originally been suggested by Aristeu Rozanski more than 4 > years ago as part of the set of namespace IDs. I had also attempted to > solve this problem by using the namespace' proc inode, then switched over to > generate a unique kernel serial number for each namespace and then went back to > namespace proc dev/ino once Al Viro implemented nsfs: > v1 https://lkml.org/lkml/2014/4/22/662 > v2 https://lkml.org/lkml/2014/5/9/637 > v3 https://lkml.org/lkml/2014/5/20/287 > v4 https://lkml.org/lkml/2014/8/20/844 > v5 https://lkml.org/lkml/2014/10/6/25 > v6 https://lkml.org/lkml/2015/4/17/48 > v7 https://lkml.org/lkml/2015/5/12/773 > > These patches don't use a container ID, but track all namespaces in use for an > event. This has the benefit of punting this tracking to userspace for some > other tool to analyse and determine to which container an event belongs. > This will use a lot of bandwidth in audit log files when a single > container ID that doesn't require nesting information to be complete > would be a much more efficient use of audit log bandwidth. Relying on a particular namespace to identify a containers is a non-starter from my perspective for all the reasons previously discussed. > If we rely only on the setting of arbitrary container names from userspace, > then we must provide a map or tree back to the initial audit domain for that > running kernel to be able to differentiate between potentially identical > container names assigned in a nested container system. If we assign a > container serial number sequentially (atomic64_inc) from the kernel on request > from userspace like the sessionID and log the creation with all nsIDs and the > parent container serial number and/or container name, the nesting is clear due > to lack of ambiguity in potential duplicate names in nesting. If a container > serial number is used, the tree of inheritance of nested containers can be > rebuilt from the audit records showing what containers were spawned from what > parent. I believe we are going to need a container ID to container definition (namespace, etc.) mapping mechanism regardless of if the container ID is provided by userspace or a kernel generated serial number. This mapping should be recorded in the audit log when the container ID is created/defined. > As was suggested in one of the previous threads, if there are any events not > associated with a task (incoming network packets) we log the namespace ID and > then only concern ourselves with its container serial number or container name > once it becomes associated with a task at which point that tracking will be > more important anyways. Agreed. After all, a single namespace can be shared between multiple containers. For those security officers who need to track individual events like this they will have the container ID mapping information in the logs as well so they should be able to trace the unassociated event to a set of containers. > I'm not convinced that a userspace or kernel generated UUID is that useful > since they are large, not human readable and may not be globally unique given > the "pets vs cattle" direction we are going with potentially identical > conditions in hosts or containers spawning containers, but I see no need to > restrict them. From a kernel perspective I think an int should suffice; after all, you can't have more containers then you have processes. If the container engine requires something more complex, it can use the int as input to its own mapping function. > How do we deal with setns()? Once it is determined that action is permitted, > given the new combinaiton of namespaces and potential membership in a different > container, record the transition from one container to another including all > namespaces if the latter are a different subset than the target container > initial set. That is a fun one, isn't it? I think this is where the container ID-to-definition mapping comes into play. If setns() changes the process such that the existing container ID is no longer valid then we need to do a new lookup in the table to see if another container ID is valid; if no established container ID mappings are valid, the container ID becomes "undefined". -- paul moore www.paul-moore.com ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <CAHC9VhRgPRa7KeMt8G700aeFvqVYc0gMx__82K31TYY6oQQqTw@mail.gmail.com>]
[parent not found: <CAHC9VhRgPRa7KeMt8G700aeFvqVYc0gMx__82K31TYY6oQQqTw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 2/9] Implement containers as kernel objects [not found] ` <CAHC9VhRgPRa7KeMt8G700aeFvqVYc0gMx__82K31TYY6oQQqTw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2017-08-18 8:03 ` Richard Guy Briggs 0 siblings, 0 replies; 25+ messages in thread From: Richard Guy Briggs @ 2017-08-18 8:03 UTC (permalink / raw) To: Paul Moore Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, ebiederm-aS9lmoZGLiVWk0Htik3J/w, jlayton-H+wXaHxf7aLQT0dZR+AlfA, linux-api-u79uwXL29TY76Z2rM5mHXA, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, David Howells, linux-audit-H+wXaHxf7aLQT0dZR+AlfA, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, luto-DgEjT+Ai2ygdnm+yROfE0A, trondmy-7I+n7zu2hftEKMMhf/gKZA, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, cgroups-u79uwXL29TY76Z2rM5mHXA On 2017-08-16 18:21, Paul Moore wrote: > On Mon, Aug 14, 2017 at 1:47 AM, Richard Guy Briggs <rgb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote: > > Hi David, > > > > I wanted to respond to this thread to attempt some constructive feedback, > > better late than never. I had a look at your fsopen/fsmount() patchset(s) to > > support this patchset which was interesting, but doesn't directly affect my > > work. The primary patch of interest to the audit kernel folks (Paul Moore and > > me) is this patch while the rest of the patchset is interesting, but not likely > > to directly affect us. This patch has most of what we need to solve our > > problem. > > > > Paul and I agree that audit is going to have a difficult time identifying > > containers or even namespaces without some change to the kernel. The audit > > subsystem in the kernel needs at least a basic clue about which container > > caused an event to be able to report this at the appropriate level and ignore > > it at other levels to avoid a DoS. > > While there is some increased risk of "death by audit", this is really > only an issue once we start supporting multiple audit daemons; simply > associating auditable events with the container that triggered them > shouldn't add any additional overhead (I hope). For a number of use > cases, a single auditd running outside the containers, but recording > all their events with some type of container attribution will be > sufficient. This is step #1. > > However, we will obviously want to go a bit further and support > multiple audit daemons on the system to allow containers to > record/process their own events (side note: the non-container auditd > instance will still see all the events). There are a number of ways > we could tackle this, both via in-kernel and in-userspace record > routing, each with their own pros/cons. However, how this works is > going to be dependent on how we identify containers and track their > audit events: the bits from step #1. For this reason I'm not really > interested in worrying about the multiple auditd problem just yet; > it's obviously important, and something to keep in mind while working > up a solution, but it isn't something we should focus on right now. > > > We also agree that there will need to be some sort of trigger from userspace to > > indicate the creation of a container and its allocated resources and we're not > > really picky how that is done, such as a clone flag, a syscall or a sysfs write > > (or even a read, I suppose), but there will need to be some permission > > restrictions, obviously. (I'd like to see capabilities used for this by adding > > a specific container bit to the capabilities bitmask.) > > To be clear, from an audit perspective I think the only thing we would > really care about controlling access to is the creation and assignment > of a new audit container ID/token, not necessarily the container > itself. It's a small point, but an important one I think. > > > I doubt we will be able to accomodate all definitions or concepts of a > > container in a timely fashion. We'll need to start somewhere with a minimum > > definition so that we can get traction and actually move forward before another > > compelling shared kernel microservice method leaves our entire community > > behind. I'd like to declare that a container is a full set of cloned > > namespaces, but this is inefficient, overly constricting and unnecessary for > > our needs. If we could agree on a minimum definition of a container (which may > > have only one specific cloned namespace) then we have something on which to > > build. I could even see a container being defined by a trigger sent from > > userspace about a process (task) from which all its children are considered to > > be within that container, subject to further nesting. > > I really would prefer if we could avoid defining the term "container". > Even if we manage to get it right at this particular moment, we will > surely be made fools a year or two from now when things change. At > the very least lets avoid a rigid definition of container, I'll > concede that we will probably need to have some definition simply so > we can implement something, I just don't want the design or > implementation to depend on a particular definition. > > This comment is jumping ahead a bit, but from an audit perspective I > think we handle this by emitting an audit record whenever a container > ID is created which describes it as the kernel sees it; as of now that > probably means a list of namespace IDs. Richard mentions this in his > email, I just wanted to make it clear that I think we should see this > as a flexible mechanism. At the very least we will likely see a few > more namespaces before the world moves on from containers. > > > In the simplest usable model for audit, if a container (definition implies and) > > starts a PID namespace, then the container ID could simply be the container's > > "init" process PID in the initial PID namespace. This assumes that as soon as > > that process vanishes, that entire container and all its children are killed > > off (which you've done). There may be some container orchestration systems > > that don't use a unique PID namespace per container and that imposing this will > > cause them challenges. > > I don't follow how this would cause challenges if the containers do > not use a unique PID namespace; you are suggesting using the PID from > in the context of the initial PID namespace, yes? The PID of the "init" process of a container (PID=1 inside container, but PID=containerID from the initial PID namespace perspective). > Regardless, I do worry that using a PID could potentially be a bit > racy once we start jumping between kernel and userspace (audit > configuration, logs, etc.). How do you think this could be racy? An event happenning before or as the container has been defined? > > If containers have at minimum a unique mount namespace then the root path > > dentry inode device and inode number could be used, but there are likely better > > identifiers. Again, there may be container orchestrators that don't use a > > unique mount namespace per container and that imposing this will cause > > challenges. > > > > I expect there are similar examples for each of the other namespaces. > > The PID case is a bit unique as each process is going to have a unique > PID regardless of namespaces, but even that has some drawbacks as > discussed above. As for the other namespaces, I agree that we can't > rely on them (see my earlier comments). (In general can you specify which earlier comments so we can be sure to what you are referring?) > > If we could pick one namespace type for consensus for which each container has > > a unique instance of that namespace, we could use the dev/ino tuple from that > > namespace as had originally been suggested by Aristeu Rozanski more than 4 > > years ago as part of the set of namespace IDs. I had also attempted to > > solve this problem by using the namespace' proc inode, then switched over to > > generate a unique kernel serial number for each namespace and then went back to > > namespace proc dev/ino once Al Viro implemented nsfs: > > v1 https://lkml.org/lkml/2014/4/22/662 > > v2 https://lkml.org/lkml/2014/5/9/637 > > v3 https://lkml.org/lkml/2014/5/20/287 > > v4 https://lkml.org/lkml/2014/8/20/844 > > v5 https://lkml.org/lkml/2014/10/6/25 > > v6 https://lkml.org/lkml/2015/4/17/48 > > v7 https://lkml.org/lkml/2015/5/12/773 > > > > These patches don't use a container ID, but track all namespaces in use for an > > event. This has the benefit of punting this tracking to userspace for some > > other tool to analyse and determine to which container an event belongs. > > This will use a lot of bandwidth in audit log files when a single > > container ID that doesn't require nesting information to be complete > > would be a much more efficient use of audit log bandwidth. > > Relying on a particular namespace to identify a containers is a > non-starter from my perspective for all the reasons previously > discussed. I'd rather not either and suspect there isn't much danger of it, but if it is determined that there is one namespace in particular that is a minimum requirement, I'd prefer to use that nsID instead of creating an additional ID. > > If we rely only on the setting of arbitrary container names from userspace, > > then we must provide a map or tree back to the initial audit domain for that > > running kernel to be able to differentiate between potentially identical > > container names assigned in a nested container system. If we assign a > > container serial number sequentially (atomic64_inc) from the kernel on request > > from userspace like the sessionID and log the creation with all nsIDs and the > > parent container serial number and/or container name, the nesting is clear due > > to lack of ambiguity in potential duplicate names in nesting. If a container > > serial number is used, the tree of inheritance of nested containers can be > > rebuilt from the audit records showing what containers were spawned from what > > parent. > > I believe we are going to need a container ID to container definition > (namespace, etc.) mapping mechanism regardless of if the container ID > is provided by userspace or a kernel generated serial number. This > mapping should be recorded in the audit log when the container ID is > created/defined. Agreed. > > As was suggested in one of the previous threads, if there are any events not > > associated with a task (incoming network packets) we log the namespace ID and > > then only concern ourselves with its container serial number or container name > > once it becomes associated with a task at which point that tracking will be > > more important anyways. > > Agreed. After all, a single namespace can be shared between multiple > containers. For those security officers who need to track individual > events like this they will have the container ID mapping information > in the logs as well so they should be able to trace the unassociated > event to a set of containers. > > > I'm not convinced that a userspace or kernel generated UUID is that useful > > since they are large, not human readable and may not be globally unique given > > the "pets vs cattle" direction we are going with potentially identical > > conditions in hosts or containers spawning containers, but I see no need to > > restrict them. > > From a kernel perspective I think an int should suffice; after all, > you can't have more containers then you have processes. If the > container engine requires something more complex, it can use the int > as input to its own mapping function. PIDs roll over. That already causes some ambiguity in reporting. If a system is constantly spawning and reaping containers, especially single-process containers, I don't want to have to worry about that ID rolling to keep track of it even though there should be audit records of the spawn and death of each container. There isn't significant cost added here compared with some of the other overhead we're dealing with. > > How do we deal with setns()? Once it is determined that action is permitted, > > given the new combinaiton of namespaces and potential membership in a different > > container, record the transition from one container to another including all > > namespaces if the latter are a different subset than the target container > > initial set. > > That is a fun one, isn't it? I think this is where the container > ID-to-definition mapping comes into play. If setns() changes the > process such that the existing container ID is no longer valid then we > need to do a new lookup in the table to see if another container ID is > valid; if no established container ID mappings are valid, the > container ID becomes "undefined". Hopefully we can design this stuff so that container IDs are still valid while that transition occurs. > paul moore - RGB -- Richard Guy Briggs <rgb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635 ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <20170818080300.GQ7187@madcap2.tricolour.ca>]
[parent not found: <20170818080300.GQ7187-bcJWsdo4jJjeVoXN4CMphl7TgLCtbB0G@public.gmane.org>]
* Re: [PATCH 2/9] Implement containers as kernel objects [not found] ` <20170818080300.GQ7187-bcJWsdo4jJjeVoXN4CMphl7TgLCtbB0G@public.gmane.org> @ 2017-09-06 14:03 ` Serge E. Hallyn 2017-09-08 20:02 ` Paul Moore 1 sibling, 0 replies; 25+ messages in thread From: Serge E. Hallyn @ 2017-09-06 14:03 UTC (permalink / raw) To: Richard Guy Briggs Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, ebiederm-aS9lmoZGLiVWk0Htik3J/w, Paul Moore, jlayton-H+wXaHxf7aLQT0dZR+AlfA, linux-api-u79uwXL29TY76Z2rM5mHXA, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, David Howells, linux-audit-H+wXaHxf7aLQT0dZR+AlfA, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, luto-DgEjT+Ai2ygdnm+yROfE0A, trondmy-7I+n7zu2hftEKMMhf/gKZA, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, cgroups-u79uwXL29TY76Z2rM5mHXA Quoting Richard Guy Briggs (rgb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org): ... > > I believe we are going to need a container ID to container definition > > (namespace, etc.) mapping mechanism regardless of if the container ID > > is provided by userspace or a kernel generated serial number. This > > mapping should be recorded in the audit log when the container ID is > > created/defined. > > Agreed. > > > > As was suggested in one of the previous threads, if there are any events not > > > associated with a task (incoming network packets) we log the namespace ID and > > > then only concern ourselves with its container serial number or container name > > > once it becomes associated with a task at which point that tracking will be > > > more important anyways. > > > > Agreed. After all, a single namespace can be shared between multiple > > containers. For those security officers who need to track individual > > events like this they will have the container ID mapping information > > in the logs as well so they should be able to trace the unassociated > > event to a set of containers. > > > > > I'm not convinced that a userspace or kernel generated UUID is that useful > > > since they are large, not human readable and may not be globally unique given > > > the "pets vs cattle" direction we are going with potentially identical > > > conditions in hosts or containers spawning containers, but I see no need to > > > restrict them. > > > > From a kernel perspective I think an int should suffice; after all, > > you can't have more containers then you have processes. If the > > container engine requires something more complex, it can use the int > > as input to its own mapping function. > > PIDs roll over. That already causes some ambiguity in reporting. If a > system is constantly spawning and reaping containers, especially > single-process containers, I don't want to have to worry about that ID > rolling to keep track of it even though there should be audit records of > the spawn and death of each container. There isn't significant cost > added here compared with some of the other overhead we're dealing with. Strawman proposal: 1. Each clone/unshare/setns involving a namespace type generates an audit message along the lines of: PID 9512 (pid in init_pid_ns) in auditnsid 00000001 cloned CLONE_NEWNS|CLONE_NEWNET new auditnsid: 00000002 associated namespaces: (list of all namespace filesystem inode numbers) 2. Userspace (i.e. the container logging deamon here) can watch the audit log for all messages relating to auditnsid 00000002. Presumably there will be messages along the lines of "PID 9513 in auditnsid 00000002 cloned...". The container logging daemon can track those messages and add the new auditnsids to the list it watches. 3. If a container is migrated (checkpointed and restored here or elsewhere), userspace can just follow the appropriate logs for the new containers. Userspace does not ever *request* a auditnsid. They are ephemeral, just a tool to track the namespaces through the audit log. They are however guaranteed to never be re-used until reboot. (Feels like someone must have proposed this before) -serge ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 2/9] Implement containers as kernel objects [not found] ` <20170818080300.GQ7187-bcJWsdo4jJjeVoXN4CMphl7TgLCtbB0G@public.gmane.org> 2017-09-06 14:03 ` Serge E. Hallyn @ 2017-09-08 20:02 ` Paul Moore 1 sibling, 0 replies; 25+ messages in thread From: Paul Moore @ 2017-09-08 20:02 UTC (permalink / raw) To: Richard Guy Briggs Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, ebiederm-aS9lmoZGLiVWk0Htik3J/w, jlayton-H+wXaHxf7aLQT0dZR+AlfA, linux-api-u79uwXL29TY76Z2rM5mHXA, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, David Howells, linux-audit-H+wXaHxf7aLQT0dZR+AlfA, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, luto-DgEjT+Ai2ygdnm+yROfE0A, trondmy-7I+n7zu2hftEKMMhf/gKZA, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, cgroups-u79uwXL29TY76Z2rM5mHXA On Fri, Aug 18, 2017 at 4:03 AM, Richard Guy Briggs <rgb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote: > On 2017-08-16 18:21, Paul Moore wrote: >> On Mon, Aug 14, 2017 at 1:47 AM, Richard Guy Briggs <rgb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote: >> > Hi David, >> > >> > I wanted to respond to this thread to attempt some constructive feedback, >> > better late than never. I had a look at your fsopen/fsmount() patchset(s) to >> > support this patchset which was interesting, but doesn't directly affect my >> > work. The primary patch of interest to the audit kernel folks (Paul Moore and >> > me) is this patch while the rest of the patchset is interesting, but not likely >> > to directly affect us. This patch has most of what we need to solve our >> > problem. >> > >> > Paul and I agree that audit is going to have a difficult time identifying >> > containers or even namespaces without some change to the kernel. The audit >> > subsystem in the kernel needs at least a basic clue about which container >> > caused an event to be able to report this at the appropriate level and ignore >> > it at other levels to avoid a DoS. >> >> While there is some increased risk of "death by audit", this is really >> only an issue once we start supporting multiple audit daemons; simply >> associating auditable events with the container that triggered them >> shouldn't add any additional overhead (I hope). For a number of use >> cases, a single auditd running outside the containers, but recording >> all their events with some type of container attribution will be >> sufficient. This is step #1. >> >> However, we will obviously want to go a bit further and support >> multiple audit daemons on the system to allow containers to >> record/process their own events (side note: the non-container auditd >> instance will still see all the events). There are a number of ways >> we could tackle this, both via in-kernel and in-userspace record >> routing, each with their own pros/cons. However, how this works is >> going to be dependent on how we identify containers and track their >> audit events: the bits from step #1. For this reason I'm not really >> interested in worrying about the multiple auditd problem just yet; >> it's obviously important, and something to keep in mind while working >> up a solution, but it isn't something we should focus on right now. >> >> > We also agree that there will need to be some sort of trigger from userspace to >> > indicate the creation of a container and its allocated resources and we're not >> > really picky how that is done, such as a clone flag, a syscall or a sysfs write >> > (or even a read, I suppose), but there will need to be some permission >> > restrictions, obviously. (I'd like to see capabilities used for this by adding >> > a specific container bit to the capabilities bitmask.) >> >> To be clear, from an audit perspective I think the only thing we would >> really care about controlling access to is the creation and assignment >> of a new audit container ID/token, not necessarily the container >> itself. It's a small point, but an important one I think. >> >> > I doubt we will be able to accomodate all definitions or concepts of a >> > container in a timely fashion. We'll need to start somewhere with a minimum >> > definition so that we can get traction and actually move forward before another >> > compelling shared kernel microservice method leaves our entire community >> > behind. I'd like to declare that a container is a full set of cloned >> > namespaces, but this is inefficient, overly constricting and unnecessary for >> > our needs. If we could agree on a minimum definition of a container (which may >> > have only one specific cloned namespace) then we have something on which to >> > build. I could even see a container being defined by a trigger sent from >> > userspace about a process (task) from which all its children are considered to >> > be within that container, subject to further nesting. >> >> I really would prefer if we could avoid defining the term "container". >> Even if we manage to get it right at this particular moment, we will >> surely be made fools a year or two from now when things change. At >> the very least lets avoid a rigid definition of container, I'll >> concede that we will probably need to have some definition simply so >> we can implement something, I just don't want the design or >> implementation to depend on a particular definition. >> >> This comment is jumping ahead a bit, but from an audit perspective I >> think we handle this by emitting an audit record whenever a container >> ID is created which describes it as the kernel sees it; as of now that >> probably means a list of namespace IDs. Richard mentions this in his >> email, I just wanted to make it clear that I think we should see this >> as a flexible mechanism. At the very least we will likely see a few >> more namespaces before the world moves on from containers. >> >> > In the simplest usable model for audit, if a container (definition implies and) >> > starts a PID namespace, then the container ID could simply be the container's >> > "init" process PID in the initial PID namespace. This assumes that as soon as >> > that process vanishes, that entire container and all its children are killed >> > off (which you've done). There may be some container orchestration systems >> > that don't use a unique PID namespace per container and that imposing this will >> > cause them challenges. >> >> I don't follow how this would cause challenges if the containers do >> not use a unique PID namespace; you are suggesting using the PID from >> in the context of the initial PID namespace, yes? > > The PID of the "init" process of a container (PID=1 inside container, > but PID=containerID from the initial PID namespace perspective). Yep. I still don't see how a container not creating a unique PID namespace presents a challenge here as the unique information would be taken from the initial PID namespace. However, based on some off-list discussions I expect this is going to be a non-issue in the next proposal. >> Regardless, I do worry that using a PID could potentially be a bit >> racy once we start jumping between kernel and userspace (audit >> configuration, logs, etc.). > > How do you think this could be racy? An event happenning before or as > the container has been defined? It's racy for the same reasons why we have the pid struct in the kernel. If the orchestrator is referencing things via a PID there is always some danger of a mixup. >> > If containers have at minimum a unique mount namespace then the root path >> > dentry inode device and inode number could be used, but there are likely better >> > identifiers. Again, there may be container orchestrators that don't use a >> > unique mount namespace per container and that imposing this will cause >> > challenges. >> > >> > I expect there are similar examples for each of the other namespaces. >> >> The PID case is a bit unique as each process is going to have a unique >> PID regardless of namespaces, but even that has some drawbacks as >> discussed above. As for the other namespaces, I agree that we can't >> rely on them (see my earlier comments). > > (In general can you specify which earlier comments so we can be sure to > what you are referring?) Really? How about the race condition concerns. Come on Richard ... >> > If we could pick one namespace type for consensus for which each container has >> > a unique instance of that namespace, we could use the dev/ino tuple from that >> > namespace as had originally been suggested by Aristeu Rozanski more than 4 >> > years ago as part of the set of namespace IDs. I had also attempted to >> > solve this problem by using the namespace' proc inode, then switched over to >> > generate a unique kernel serial number for each namespace and then went back to >> > namespace proc dev/ino once Al Viro implemented nsfs: >> > v1 https://lkml.org/lkml/2014/4/22/662 >> > v2 https://lkml.org/lkml/2014/5/9/637 >> > v3 https://lkml.org/lkml/2014/5/20/287 >> > v4 https://lkml.org/lkml/2014/8/20/844 >> > v5 https://lkml.org/lkml/2014/10/6/25 >> > v6 https://lkml.org/lkml/2015/4/17/48 >> > v7 https://lkml.org/lkml/2015/5/12/773 >> > >> > These patches don't use a container ID, but track all namespaces in use for an >> > event. This has the benefit of punting this tracking to userspace for some >> > other tool to analyse and determine to which container an event belongs. >> > This will use a lot of bandwidth in audit log files when a single >> > container ID that doesn't require nesting information to be complete >> > would be a much more efficient use of audit log bandwidth. >> >> Relying on a particular namespace to identify a containers is a >> non-starter from my perspective for all the reasons previously >> discussed. > > I'd rather not either and suspect there isn't much danger of it, but if > it is determined that there is one namespace in particular that is a > minimum requirement, I'd prefer to use that nsID instead of creating an > additional ID. > >> > If we rely only on the setting of arbitrary container names from userspace, >> > then we must provide a map or tree back to the initial audit domain for that >> > running kernel to be able to differentiate between potentially identical >> > container names assigned in a nested container system. If we assign a >> > container serial number sequentially (atomic64_inc) from the kernel on request >> > from userspace like the sessionID and log the creation with all nsIDs and the >> > parent container serial number and/or container name, the nesting is clear due >> > to lack of ambiguity in potential duplicate names in nesting. If a container >> > serial number is used, the tree of inheritance of nested containers can be >> > rebuilt from the audit records showing what containers were spawned from what >> > parent. >> >> I believe we are going to need a container ID to container definition >> (namespace, etc.) mapping mechanism regardless of if the container ID >> is provided by userspace or a kernel generated serial number. This >> mapping should be recorded in the audit log when the container ID is >> created/defined. > > Agreed. > >> > As was suggested in one of the previous threads, if there are any events not >> > associated with a task (incoming network packets) we log the namespace ID and >> > then only concern ourselves with its container serial number or container name >> > once it becomes associated with a task at which point that tracking will be >> > more important anyways. >> >> Agreed. After all, a single namespace can be shared between multiple >> containers. For those security officers who need to track individual >> events like this they will have the container ID mapping information >> in the logs as well so they should be able to trace the unassociated >> event to a set of containers. >> >> > I'm not convinced that a userspace or kernel generated UUID is that useful >> > since they are large, not human readable and may not be globally unique given >> > the "pets vs cattle" direction we are going with potentially identical >> > conditions in hosts or containers spawning containers, but I see no need to >> > restrict them. >> >> From a kernel perspective I think an int should suffice; after all, >> you can't have more containers then you have processes. If the >> container engine requires something more complex, it can use the int >> as input to its own mapping function. > > PIDs roll over. That already causes some ambiguity in reporting. If a > system is constantly spawning and reaping containers, especially > single-process containers, I don't want to have to worry about that ID > rolling to keep track of it even though there should be audit records of > the spawn and death of each container. There isn't significant cost > added here compared with some of the other overhead we're dealing with. Fine, make it a u64. I believe that's what I've been proposing in the off-list discussion if memory serves. A UUID or string are not acceptable from my perspective. Too big for the audit records and not really necessary anyway, a u64 should be just fine. ... and if anyone dares bring up that 640kb quote I swear I'll NACK all their patches for the next year :) >> > How do we deal with setns()? Once it is determined that action is permitted, >> > given the new combinaiton of namespaces and potential membership in a different >> > container, record the transition from one container to another including all >> > namespaces if the latter are a different subset than the target container >> > initial set. >> >> That is a fun one, isn't it? I think this is where the container >> ID-to-definition mapping comes into play. If setns() changes the >> process such that the existing container ID is no longer valid then we >> need to do a new lookup in the table to see if another container ID is >> valid; if no established container ID mappings are valid, the >> container ID becomes "undefined". > > Hopefully we can design this stuff so that container IDs are still valid > while that transition occurs. > >> paul moore > > - RGB > > -- > Richard Guy Briggs <rgb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> > Sr. S/W Engineer, Kernel Security, Base Operating Systems > Remote, Ottawa, Red Hat Canada > IRC: rgb, SunRaycer > Voice: +1.647.777.2635, Internal: (81) 32635 -- paul moore www.paul-moore.com ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <20170906140341.GA8729@mail.hallyn.com>]
[parent not found: <20170906140341.GA8729-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>]
* Re: [PATCH 2/9] Implement containers as kernel objects [not found] ` <20170906140341.GA8729-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org> @ 2017-09-14 5:47 ` Richard Guy Briggs 0 siblings, 0 replies; 25+ messages in thread From: Richard Guy Briggs @ 2017-09-14 5:47 UTC (permalink / raw) To: Serge E. Hallyn Cc: mszeredi-H+wXaHxf7aLQT0dZR+AlfA, linux-nfs-u79uwXL29TY76Z2rM5mHXA, Paul Moore, jlayton-H+wXaHxf7aLQT0dZR+AlfA, linux-api-u79uwXL29TY76Z2rM5mHXA, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, David Howells, linux-audit-H+wXaHxf7aLQT0dZR+AlfA, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn, luto-DgEjT+Ai2ygdnm+yROfE0A, trondmy-7I+n7zu2hftEKMMhf/gKZA, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, cgroups-u79uwXL29TY76Z2rM5mHXA, ebiederm-aS9lmoZGLiVWk0Htik3J/w On 2017-09-06 09:03, Serge E. Hallyn wrote: > Quoting Richard Guy Briggs (rgb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org): > ... > > > I believe we are going to need a container ID to container definition > > > (namespace, etc.) mapping mechanism regardless of if the container ID > > > is provided by userspace or a kernel generated serial number. This > > > mapping should be recorded in the audit log when the container ID is > > > created/defined. > > > > Agreed. > > > > > > As was suggested in one of the previous threads, if there are any events not > > > > associated with a task (incoming network packets) we log the namespace ID and > > > > then only concern ourselves with its container serial number or container name > > > > once it becomes associated with a task at which point that tracking will be > > > > more important anyways. > > > > > > Agreed. After all, a single namespace can be shared between multiple > > > containers. For those security officers who need to track individual > > > events like this they will have the container ID mapping information > > > in the logs as well so they should be able to trace the unassociated > > > event to a set of containers. > > > > > > > I'm not convinced that a userspace or kernel generated UUID is that useful > > > > since they are large, not human readable and may not be globally unique given > > > > the "pets vs cattle" direction we are going with potentially identical > > > > conditions in hosts or containers spawning containers, but I see no need to > > > > restrict them. > > > > > > From a kernel perspective I think an int should suffice; after all, > > > you can't have more containers then you have processes. If the > > > container engine requires something more complex, it can use the int > > > as input to its own mapping function. > > > > PIDs roll over. That already causes some ambiguity in reporting. If a > > system is constantly spawning and reaping containers, especially > > single-process containers, I don't want to have to worry about that ID > > rolling to keep track of it even though there should be audit records of > > the spawn and death of each container. There isn't significant cost > > added here compared with some of the other overhead we're dealing with. > > Strawman proposal: > > 1. Each clone/unshare/setns involving a namespace type generates an audit > message along the lines of: > > PID 9512 (pid in init_pid_ns) in auditnsid 00000001 cloned CLONE_NEWNS|CLONE_NEWNET > new auditnsid: 00000002 > associated namespaces: (list of all namespace filesystem inode numbers) As you will have seen, this is pretty much what my most recent proposal suggests. > 2. Userspace (i.e. the container logging deamon here) can watch the audit log > for all messages relating to auditnsid 00000002. Presumably there will be > messages along the lines of "PID 9513 in auditnsid 00000002 cloned...". The > container logging daemon can track those messages and add the new auditnsids > to the list it watches. Yes. > 3. If a container is migrated (checkpointed and restored here or elsewhere), > userspace can just follow the appropriate logs for the new containers. Yes. > Userspace does not ever *request* a auditnsid. They are ephemeral, just a > tool to track the namespaces through the audit log. They are however guaranteed > to never be re-used until reboot. Well, this is where things get controvertial... I had wanted this, a kernel-generated serial number unique to a running kernel to track every container initiation, but this does have some CRIU challenges pointed out by Eric Biederman. Nested containers will not have a consistent view on a new host and no way to make it consistent. If we could guarantee that containers would never be nested, this could be workable. I think nesting is inevitable in the future given the variety and creativity of the orchestration tools, so restricting this seems short-sighted. At the moment the approch is to let the orchestrator determine the ID of a container. Some have argued for as small as u32 and others for a full UUID. A u32 runs the risk of rolling, so a u64 seems like a reasonable step to solve that issue. Others would like to be able to store a full UUID which seemed like a good idea on the outset, but on further thinking, this is something the orchestrator can manage while minimising the number of bits of required information per audit record to guarantee we can identify the provenance of a particular audit event. Let's see if we can make it work with a u64. > (Feels like someone must have proposed this before) Thsee ideas have been thrown around a few times and I'm starting to understand them better. > -serge - RGB -- Richard Guy Briggs <rgb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635 ^ permalink raw reply [flat|nested] 25+ messages in thread
end of thread, other threads:[~2017-09-14 5:47 UTC | newest]
Thread overview: 25+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1495554267.27369.9.camel@HansenPartnership.com>
[not found] ` <87zie3mxkc.fsf@xmission.com>
[not found] ` <f167feeb-e653-12e3-eec8-24162f7f7c07@suse.de>
[not found] ` <149547014649.10599.12025037906646164347.stgit@warthog.procyon.org.uk>
[not found] ` <149547014649.10599.12025037906646164347.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-05-22 16:53 ` [RFC][PATCH 0/9] Make containers kernel objects James Bottomley
[not found] ` <1495472039.2757.19.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-05-22 17:14 ` Aleksa Sarai
2017-05-22 17:27 ` Jessica Frazelle
2017-05-22 18:34 ` Jeff Layton
2017-05-23 9:38 ` Ian Kent
2017-05-23 13:52 ` David Howells
[not found] ` <1495478092.2816.17.camel@redhat.com>
[not found] ` <1495478092.2816.17.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-05-22 19:21 ` James Bottomley
[not found] ` <1495480860.9050.18.camel@HansenPartnership.com>
[not found] ` <1495480860.9050.18.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-05-22 22:14 ` Jeff Layton
2017-05-23 10:35 ` Ian Kent
[not found] ` <f167feeb-e653-12e3-eec8-24162f7f7c07-l3A5Bk7waGM@public.gmane.org>
2017-05-23 14:53 ` David Howells
[not found] ` <2446.1495551216@warthog.procyon.org.uk>
[not found] ` <2446.1495551216-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-05-23 14:56 ` Eric W. Biederman
[not found] ` <87zie3mxkc.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2017-05-23 15:14 ` David Howells
[not found] ` <2961.1495552481@warthog.procyon.org.uk>
[not found] ` <2961.1495552481-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-05-23 15:17 ` Eric W. Biederman
[not found] ` <87bmqjmwl5.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2017-05-23 15:44 ` James Bottomley
[not found] ` <1495554267.27369.9.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-05-23 16:36 ` David Howells
[not found] ` <3860.1495557363-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-05-24 8:26 ` Eric W. Biederman
[not found] ` <87k256ek3e.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2017-05-24 9:16 ` Ian Kent
[not found] ` <32556.1495547529@warthog.procyon.org.uk>
[not found] ` <32556.1495547529-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-05-23 15:02 ` James Bottomley
2017-05-23 15:23 ` Eric W. Biederman
[not found] ` <149547016213.10599.1969443294414531853.stgit@warthog.procyon.org.uk>
[not found] ` <149547016213.10599.1969443294414531853.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-08-14 5:47 ` [PATCH 2/9] Implement containers as " Richard Guy Briggs
[not found] ` <20170814054711.GB29957@madcap2.tricolour.ca>
[not found] ` <20170814054711.GB29957-bcJWsdo4jJjeVoXN4CMphl7TgLCtbB0G@public.gmane.org>
2017-08-16 22:21 ` Paul Moore
[not found] ` <CAHC9VhRgPRa7KeMt8G700aeFvqVYc0gMx__82K31TYY6oQQqTw@mail.gmail.com>
[not found] ` <CAHC9VhRgPRa7KeMt8G700aeFvqVYc0gMx__82K31TYY6oQQqTw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-18 8:03 ` Richard Guy Briggs
[not found] ` <20170818080300.GQ7187@madcap2.tricolour.ca>
[not found] ` <20170818080300.GQ7187-bcJWsdo4jJjeVoXN4CMphl7TgLCtbB0G@public.gmane.org>
2017-09-06 14:03 ` Serge E. Hallyn
2017-09-08 20:02 ` Paul Moore
[not found] ` <20170906140341.GA8729@mail.hallyn.com>
[not found] ` <20170906140341.GA8729-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2017-09-14 5:47 ` Richard Guy Briggs
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox