From: Oleg Nesterov <oleg-6lXkIZvqkOAvJsYlp49lxw@public.gmane.org>
To: sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org
Cc: Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
Pavel Emelianov <xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH 3/3] Signal semantics for pid namespaces
Date: Sat, 1 Sep 2007 15:48:03 +0400 [thread overview]
Message-ID: <20070901114803.GA215@tv-sign.ru> (raw)
In-Reply-To: <20070831203834.GC3268-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
On 08/31, sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org wrote:
>
> @@ -48,7 +49,7 @@ static int sig_init_ignore(struct task_s
> if (likely(!is_container_init(tsk->group_leader)))
> return 0;
>
> - if (!in_interrupt())
> + if (is_current_in_ancestor_pid_ns(tsk) && !in_interrupt())
> return 0;
We should return 1 in that case, afaics the logic is wrongly reversed.
Oleg.
next prev parent reply other threads:[~2007-09-01 11:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-31 20:38 [PATCH 3/3] Signal semantics for pid namespaces sukadev-r/Jw6+rmf7HQT0dZR+AlfA
[not found] ` <20070831203834.GC3268-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2007-09-01 11:48 ` Oleg Nesterov [this message]
[not found] ` <20070901114803.GA215-6lXkIZvqkOAvJsYlp49lxw@public.gmane.org>
2007-09-03 16:59 ` sukadev-r/Jw6+rmf7HQT0dZR+AlfA
[not found] ` <20070903165916.GD2793-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2007-09-03 17:10 ` Oleg Nesterov
-- strict thread matches above, loose matches on Subject: below --
2007-09-11 4:12 sukadev-r/Jw6+rmf7HQT0dZR+AlfA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070901114803.GA215@tv-sign.ru \
--to=oleg-6lxkizvqkoavjsylp49lxw@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox