From: Alexey Kuznetsov <kuznet-v/Mj1YrvjDBInbfyfbPRSQ@public.gmane.org>
To: "Denis V. Lunev" <den-3ImXcnM4P+0@public.gmane.org>
Cc: Pavel Emelianov <xemul-3ImXcnM4P+0@public.gmane.org>,
"Eric W. Biederman"
<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
Linux Containers
<containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
Alexey Kuznetsov <alexey-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>,
Benjamin Thery <benjamin.thery-6ktuUTfB/bM@public.gmane.org>
Subject: Re: namespace acceptance process. bad news
Date: Wed, 5 Dec 2007 15:33:55 +0300 [thread overview]
Message-ID: <20071205123355.GA26646@ms2.inr.ac.ru> (raw)
In-Reply-To: <47568A09.7050305-3ImXcnM4P+0@public.gmane.org>
Hello!
> Alexey seems to disagree with this approach, is it possible to elaborate
> a little bit ?
My first reaction was exactly the same as David's one. Exactly. :-)
flowi structure was invented to be both easily initialized/disposed
as a local variable and copied/stored in various caches as a key.
If it has some reference inside, it becomes really ugly.
But it is the first reaction. I guess you do not have much of choice.
The only alternative is to add an additional argument to functions
taking flowi, which is even uglier.
So, it looks like netns still have to go to flowi, but functions copying
flowi (in route.c/flow.c/whatever) should not use raw memcpy to store this
and must remember that saving flowi is possible only when refcnt to netns
is held somewhere.
Alexey
next prev parent reply other threads:[~2007-12-05 12:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 10:42 namespace acceptance process. bad news Denis V. Lunev
[not found] ` <475680A2.2000907-3ImXcnM4P+0@public.gmane.org>
2007-12-05 10:58 ` Daniel Lezcano
[not found] ` <47568471.1060503-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2007-12-05 11:22 ` Denis V. Lunev
[not found] ` <47568A09.7050305-3ImXcnM4P+0@public.gmane.org>
2007-12-05 11:52 ` Eric W. Biederman
2007-12-05 12:33 ` Alexey Kuznetsov [this message]
[not found] ` <20071205123355.GA26646-v/Mj1YrvjDBInbfyfbPRSQ@public.gmane.org>
2007-12-05 12:40 ` Denis V. Lunev
2007-12-05 13:20 ` Daniel Lezcano
[not found] ` <4756A58A.8050103-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2007-12-05 22:21 ` Eric W. Biederman
2007-12-05 12:31 ` Benjamin Thery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205123355.GA26646@ms2.inr.ac.ru \
--to=kuznet-v/mj1yrvjdbinbfyfbprsq@public.gmane.org \
--cc=alexey-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
--cc=benjamin.thery-6ktuUTfB/bM@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=den-3ImXcnM4P+0@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=xemul-3ImXcnM4P+0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox