From: "Denis V. Lunev" <den-3ImXcnM4P+0@public.gmane.org>
To: Daniel Lezcano <dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
Cc: Pavel Emelianov <xemul-3ImXcnM4P+0@public.gmane.org>,
"Eric W. Biederman"
<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
Linux Containers
<containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
Alexey Kuznetsov <alexey-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>,
Benjamin Thery <benjamin.thery-6ktuUTfB/bM@public.gmane.org>
Subject: Re: namespace acceptance process. bad news
Date: Wed, 05 Dec 2007 14:22:49 +0300 [thread overview]
Message-ID: <47568A09.7050305@sw.ru> (raw)
In-Reply-To: <47568471.1060503-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
Daniel Lezcano wrote:
> Denis V. Lunev wrote:
>> Hello, All!
>>
>> We are completely bite to ground with the current Eric's patchset today
>> by Dave Miller. flowi tagging considered wrong. The same opinion has
>> been received from Alexey Kuznetsov :(
>>
>> So, it seems that we can't push this approach.
>
> Argh !
>
>>
>> Daniel, Benjamin, should I merge your code to our git after this news or
>> we should stop a bit and think? We have talked on OLS that if Dave stop
>> us with current approach we could try global context as in OpenVz.
>
> IMHO, doing netns switching has no sense now we are so far in the netns
> implementation.
>
>> I think I'll code this a bit and see a reaction, but we need to have
>> some agreement here :)
>
> I am more inclined to think about how to handle this problem before
> doing anything.
>
> Let's try to understand why flowi tagging is considered wrong first.
>
> Alexey seems to disagree with this approach, is it possible to elaborate
> a little bit ?
>
>
Here is a quote from Miller:
| I'm not applying this, it's going to have a negative impact on routing
| performance.
|
| It also changes the semantics of the flowi object in a way I very
| much dislike, in that there is now non-clobberable state in there.
|
| Previously only addressing identifying objects were present in the
| flow, you could use it any context, and there were no pointer
| dereferencing or object references from this thing. It was very
| simple.
|
| That is no longer the case after your patch and I don't want us
| to go down this path.
|
| Please find another way to implement this.
flowi marking is a way to deliver the namespace into the routing code,
as far as I can understand the implementation.
Regards,
Den
next prev parent reply other threads:[~2007-12-05 11:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 10:42 namespace acceptance process. bad news Denis V. Lunev
[not found] ` <475680A2.2000907-3ImXcnM4P+0@public.gmane.org>
2007-12-05 10:58 ` Daniel Lezcano
[not found] ` <47568471.1060503-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2007-12-05 11:22 ` Denis V. Lunev [this message]
[not found] ` <47568A09.7050305-3ImXcnM4P+0@public.gmane.org>
2007-12-05 11:52 ` Eric W. Biederman
2007-12-05 12:33 ` Alexey Kuznetsov
[not found] ` <20071205123355.GA26646-v/Mj1YrvjDBInbfyfbPRSQ@public.gmane.org>
2007-12-05 12:40 ` Denis V. Lunev
2007-12-05 13:20 ` Daniel Lezcano
[not found] ` <4756A58A.8050103-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2007-12-05 22:21 ` Eric W. Biederman
2007-12-05 12:31 ` Benjamin Thery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47568A09.7050305@sw.ru \
--to=den-3imxcnm4p+0@public.gmane.org \
--cc=alexey-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
--cc=benjamin.thery-6ktuUTfB/bM@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=xemul-3ImXcnM4P+0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox