Re: [PATCH 04/10] Extract option parsing to new function

["Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>]

Quoting sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org (sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org):
> 
> >From 91a31d2286a22a2cfa03f9ddea44fd2eaf5fa576 Mon Sep 17 00:00:00 2001
> From: Sukadev Bhattiprolu <sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> Date: Tue, 9 Sep 2008 10:23:00 -0700
> Subject: [PATCH 04/10] Extract option parsing to new function
> 
> Move code to parse mount options into a separate function so it can
> (later) be shared between mount and remount operations.
> 
> Signed-off-by: Sukadev Bhattiprolu <sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

Acked-by: Serge Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

> ---
>  fs/devpts/inode.c |   12 +++++++++---
>  1 files changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c
> index e91c15c..7ae60aa 100644
> --- a/fs/devpts/inode.c
> +++ b/fs/devpts/inode.c
> @@ -72,11 +72,9 @@ static inline struct super_block *pts_sb_from_inode(struct inode *inode)
>  	return devpts_mnt->mnt_sb;
>  }
> 
> -static int devpts_remount(struct super_block *sb, int *flags, char *data)
> +static int parse_mount_options(char *data, struct pts_mount_opts *opts)
>  {
>  	char *p;
> -	struct pts_fs_info *fsi = DEVPTS_SB(sb);
> -	struct pts_mount_opts *opts = &fsi->mount_opts;
> 
>  	opts->setuid  = 0;
>  	opts->setgid  = 0;
> @@ -120,6 +118,14 @@ static int devpts_remount(struct super_block *sb, int *flags, char *data)
>  	return 0;
>  }
> 
> +static int devpts_remount(struct super_block *sb, int *flags, char *data)
> +{
> +	struct pts_fs_info *fsi = DEVPTS_SB(sb);
> +	struct pts_mount_opts *opts = &fsi->mount_opts;
> +
> +	return parse_mount_options(data, opts);
> +}
> +
>  static int devpts_show_options(struct seq_file *seq, struct vfsmount *vfs)
>  {
>  	struct pts_fs_info *fsi = DEVPTS_SB(vfs->mnt_sb);
> -- 
> 1.5.2.5