Linux Container Development
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
	adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	Dave Hansen
	<dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Subject: Re: [PATCH] c/r: Add UTS support (v4)
Date: Mon, 23 Mar 2009 10:08:33 -0500	[thread overview]
Message-ID: <20090323150833.GB31981@us.ibm.com> (raw)
In-Reply-To: <87eiwoi956.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>

Quoting Dan Smith (danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org):
> DH> for each ns in nsproxy {
> DH>   if (ns seen first time) {
> DH>     alloc ns_objref
> DH>     save state of ns
> DH>   } else {
> DH>     save existing ns_objref
> DH>   }
> DH> }
> 
> Isn't this precisely what I have in the latest patch?  Since there is
> only one supported namespace type, perhaps the for loop is hard to
> recognize...

Yes, I still think your patch is good...

> The bitfield serves only to describe which *new* namespace records
> follow the general one, but the objref of each (supported) namespace
> is included in the initial record.  Now that I think of it, I can do
> away with the bitfield to avoid confusion.

How about you tweak both Nathan and Oren (who I think both have
IPC c/r patchsets) by adding dummy ipc c/r support.  Just define
CR_OBJ_IPCNS, make cr_wrte_ns_ipc() empty and call it from
cr_write_namespaces().

-serge

  parent reply	other threads:[~2009-03-23 15:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-18 18:51 [PATCH] c/r: Add UTS support (v4) Dan Smith
     [not found] ` <1237402291-28812-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-19 22:26   ` Oren Laadan
     [not found]     ` <49C2C686.2060806-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-19 22:39       ` Dan Smith
     [not found]         ` <871vstdtn1.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>
2009-03-19 22:58           ` Oren Laadan
     [not found]             ` <49C2CDFA.4010907-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-19 23:13               ` Oren Laadan
2009-03-20 13:56                 ` Dan Smith
     [not found]                 ` <49C2D183.8040905-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-20 18:10                   ` Serge E. Hallyn
     [not found]                     ` <20090320181043.GB8380-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-20 19:34                       ` Oren Laadan
     [not found]                         ` <49C3EFAF.9030706-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-20 19:59                           ` Dave Hansen
2009-03-20 20:48                             ` Oren Laadan
     [not found]                               ` <49C4011C.1050707-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-20 21:00                                 ` Dave Hansen
2009-03-20 21:26                                   ` Oren Laadan
     [not found]                                     ` <49C40A23.6080708-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-20 21:39                                       ` Dave Hansen
2009-03-20 21:58                                         ` Oren Laadan
2009-03-23 14:52                             ` Dan Smith
     [not found]                               ` <87eiwoi956.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>
2009-03-23 15:08                                 ` Serge E. Hallyn [this message]
2009-03-20 18:05               ` Serge E. Hallyn
     [not found]                 ` <20090320180506.GA8380-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-20 19:38                   ` Oren Laadan
     [not found]                     ` <49C3F0A9.9080703-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-20 20:42                       ` Serge E. Hallyn
2009-03-19 22:28   ` Oren Laadan
2009-03-24 15:07   ` Oren Laadan
2009-03-24 15:21     ` Dan Smith
     [not found]       ` <87d4c7gd54.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>
2009-03-24 15:34         ` Oren Laadan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090323150833.GB31981@us.ibm.com \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox