From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Oren Laadan <orenl@cs.columbia.edu>
Cc: Linux Containers <containers@lists.osdl.org>,
David Howells <dhowells@redhat.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH 5/8] groups: allow compilation on s390x
Date: Tue, 26 May 2009 18:17:41 -0500 [thread overview]
Message-ID: <20090526231741.GA19730@us.ibm.com> (raw)
In-Reply-To: <20090526173344.GE13991@us.ibm.com>
Quoting Serge E. Hallyn (serue@us.ibm.com):
> Signed-off-by: Serge E. Hallyn <serue@us.ibm.com>
> ---
> kernel/groups.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/groups.c b/kernel/groups.c
> index 1b95b2f..14ebc6a 100644
> --- a/kernel/groups.c
> +++ b/kernel/groups.c
> @@ -1,6 +1,7 @@
> /*
> * Supplementary group IDs
> */
> +#include <linux/init.h>
> #include <linux/cred.h>
> #include <linux/module.h>
> #include <linux/slab.h>
> --
> 1.6.1
As noted by Alexey, this is wrong, and the prob was
actually fixed by the following patch he'd also sent
last friday, so please replace this patch with the
following:
From: Alexey Dobriyan <adobriyan@gmail.com>
Subject: [PATCH 01/38] cred: #include init.h in cred.h
cred.h can't be included as first header because it uses __init and
doesn't include init.h which is enough to break compilation on at least
ia64.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
include/linux/cred.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/cred.h b/include/linux/cred.h
index 3282ee4..4fa9996 100644
--- a/include/linux/cred.h
+++ b/include/linux/cred.h
@@ -13,6 +13,7 @@
#define _LINUX_CRED_H
#include <linux/capability.h>
+#include <linux/init.h>
#include <linux/key.h>
#include <asm/atomic.h>
--
1.5.6.5
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
next prev parent reply other threads:[~2009-05-26 23:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 17:32 [PATCH 0/8] a start to credentials c/r Serge E. Hallyn
2009-05-26 17:33 ` [PATCH 1/8] cr: break out new_user_ns() Serge E. Hallyn
2009-05-26 17:33 ` [PATCH 2/8] cr: split core function out of some set*{u,g}id functions Serge E. Hallyn
2009-05-26 17:33 ` [PATCH 3/8] cr: capabilities: define checkpoint and restore fns Serge E. Hallyn
2009-05-26 17:33 ` [PATCH 4/8] groups: move code to kernel/groups.c Serge E. Hallyn
2009-05-26 17:33 ` [PATCH 5/8] groups: allow compilation on s390x Serge E. Hallyn
2009-05-26 23:17 ` Serge E. Hallyn [this message]
[not found] ` <20090526173242.GA13757-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-26 17:33 ` [PATCH 6/8] cr: checkpoint and restore task credentials Serge E. Hallyn
2009-05-27 18:36 ` Alexey Dobriyan
2009-05-28 14:01 ` Serge E. Hallyn
2009-05-28 14:36 ` Alexey Dobriyan
2009-05-26 17:34 ` [PATCH 7/8] cr: restore file->f_cred Serge E. Hallyn
2009-05-26 17:34 ` [PATCH 8/8] user namespaces: debug refcounts Serge E. Hallyn
2009-05-27 3:05 ` [PATCH 0/8] a start to credentials c/r Casey Schaufler
2009-05-27 12:37 ` Serge E. Hallyn
2009-05-27 16:03 ` Casey Schaufler
2009-05-27 18:24 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090526231741.GA19730@us.ibm.com \
--to=serue@us.ibm.com \
--cc=adobriyan@gmail.com \
--cc=containers@lists.osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-security-module@vger.kernel.org \
--cc=orenl@cs.columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox