Linux Container Development
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: Re: [PATCH 1/1] cr: define CKPT_ARCH_NSIG for s390x
Date: Fri, 26 Jun 2009 07:33:16 -0500	[thread overview]
Message-ID: <20090626123316.GB14049@us.ibm.com> (raw)
In-Reply-To: <4A442D84.5010009-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>

Quoting Oren Laadan (orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org):
> 
> 
> Serge E. Hallyn wrote:
> > Else compilation fails on s390x.
> > 
> > Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> > ---
> >  arch/s390/include/asm/checkpoint_hdr.h |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/s390/include/asm/checkpoint_hdr.h b/arch/s390/include/asm/checkpoint_hdr.h
> > index fc0ace8..a5aaa3e 100644
> > --- a/arch/s390/include/asm/checkpoint_hdr.h
> > +++ b/arch/s390/include/asm/checkpoint_hdr.h
> > @@ -79,6 +79,8 @@ struct ckpt_hdr_mm_context {
> >  	unsigned long asce_limit;
> >  };
> >  
> > +#define CKPT_ARCH_NSIG _SIGCONTEXT_NSIG
> > +
> 
> But _SIGCONTEXT_NSIG is defined within #ifdef __KERNEL__ ?

hmm?  hmm.  right, indirectly, failed to notice that...

Well I don't really like to just hard define it to 64 especially
without leaving a note at the sigcontext.h NSIG defines...

Should we define both it and the x86 version in <asm/signal.h>
not under #ifdef __KERNEL__?

-serge

      parent reply	other threads:[~2009-06-26 12:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-25 18:48 [PATCH 1/1] cr: define CKPT_ARCH_NSIG for s390x Serge E. Hallyn
     [not found] ` <20090625184847.GA11510-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-26  2:08   ` Oren Laadan
     [not found]     ` <4A442D84.5010009-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-06-26 12:33       ` Serge E. Hallyn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090626123316.GB14049@us.ibm.com \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox