Re: + cgroups-fix-pid-namespace-bug.patch added to -mm tree

Re: + cgroups-fix-pid-namespace-bug.patch added to -mm tree

[Li Zefan]

> Subject: cgroups: fix pid namespace bug
> From: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> 

Hi Andrew,

Could you queue this fix for .31.

I think there's no more objection to this patch or to queuing it
for .31 instead of .32. And then Benjamin can rebase his patchset
on top of it.

> The bug was introduced by commit cc31edceee04a7b87f2be48f9489ebb72d264844
> ("cgroups: convert tasks file to use a seq_file with shared pid array").
> 
> We cache a pid array for all threads that are opening the same "tasks"
> file, but the pids in the array are always from the namespace of the
> last process that opened the file, so all other threads will read pids
> from that namespace instead of their own namespaces.
> 
> To fix it, we maintain a list of pid arrays, which is keyed by pid_ns.
> The list will be of length 1 at most time.
> 
> Reported-by: Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
> Idea-by: Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> Reviewed-by: Serge Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> Cc: Balbir Singh <balbir-xthvdsQ13ZrQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
> ---

Re: + cgroups-fix-pid-namespace-bug.patch added to -mm tree

[Andrew Morton]

On Fri, 24 Jul 2009 13:26:53 +0800 Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> wrote:

> > Subject: cgroups: fix pid namespace bug
> > From: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> > 
> 
> Hi Andrew,
> 
> Could you queue this fix for .31.

Yup, I have it there already.

> I think there's no more objection to this patch or to queuing it
> for .31 instead of .32. And then Benjamin can rebase his patchset
> on top of it.
> 

I have a note here that Paul Menage said the patch had "missing operations". 
Did that all get suitably resolved?

Re: + cgroups-fix-pid-namespace-bug.patch added to -mm tree

[Li Zefan]

Andrew Morton wrote:
> On Fri, 24 Jul 2009 13:26:53 +0800 Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> wrote:
> 
>>> Subject: cgroups: fix pid namespace bug
>>> From: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
>>>
>> Hi Andrew,
>>
>> Could you queue this fix for .31.
> 
> Yup, I have it there already.
> 
>> I think there's no more objection to this patch or to queuing it
>> for .31 instead of .32. And then Benjamin can rebase his patchset
>> on top of it.
>>
> 
> I have a note here that Paul Menage said the patch had "missing operations". 
> Did that all get suitably resolved?
> 

Yes, resolved by the delta patch "cgroups-fix-pid-namespace-bug-fix.patch"