Linux Container Development
 help / color / mirror / Atom feed
From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Containers
	<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	"Eric W. Biederman"
	<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
	hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
	mingo-X9Un+BFzKDI@public.gmane.org,
	torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
	Alexey Dobriyan
	<adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Pavel Emelyanov <xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
Subject: [RFC][v5][PATCH 6/8]: Add target_pids parameter to copy_process()
Date: Mon, 7 Sep 2009 14:15:54 -0700	[thread overview]
Message-ID: <20090907211553.GF6685@us.ibm.com> (raw)
In-Reply-To: <20090907211302.GA5892-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>



Subject: [RFC][v5][PATCH 6/8]: Add target_pids parameter to copy_process()

Add a 'target_pids' parameter to copy_process().  The new parameter will be
used in a follow-on patch when clone_with_pids() is implemented.

Signed-off-by: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Acked-by: Serge Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Reviewed-by: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
---
 kernel/fork.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

Index: linux-mmotm/kernel/fork.c
===================================================================
--- linux-mmotm.orig/kernel/fork.c	2009-09-05 21:19:16.000000000 -0700
+++ linux-mmotm/kernel/fork.c	2009-09-05 21:19:58.000000000 -0700
@@ -978,12 +978,12 @@
 					unsigned long stack_size,
 					int __user *child_tidptr,
 					struct pid *pid,
+					pid_t *target_pids,
 					int trace)
 {
 	int retval;
 	struct task_struct *p;
 	int cgroup_callbacks_done = 0;
-	pid_t *target_pids = NULL;
 
 	if ((clone_flags & (CLONE_NEWNS|CLONE_FS)) == (CLONE_NEWNS|CLONE_FS))
 		return ERR_PTR(-EINVAL);
@@ -1365,7 +1365,7 @@
 	struct pt_regs regs;
 
 	task = copy_process(CLONE_VM, 0, idle_regs(&regs), 0, NULL,
-			    &init_struct_pid, 0);
+			    &init_struct_pid, NULL, 0);
 	if (!IS_ERR(task))
 		init_idle(task, cpu);
 
@@ -1388,6 +1388,7 @@
 	struct task_struct *p;
 	int trace = 0;
 	long nr;
+	pid_t *target_pids = NULL;
 
 	/*
 	 * Do some preliminary argument and permissions checking before we
@@ -1428,7 +1429,7 @@
 		trace = tracehook_prepare_clone(clone_flags);
 
 	p = copy_process(clone_flags, stack_start, regs, stack_size,
-			 child_tidptr, NULL, trace);
+			 child_tidptr, NULL, target_pids, trace);
 	/*
 	 * Do this prior waking up the new thread - the thread pointer
 	 * might get invalid after that point, if the thread exits quickly.

  parent reply	other threads:[~2009-09-07 21:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-07 21:13 [RFC][v5] clone_with_pids() system call Sukadev Bhattiprolu
     [not found] ` <20090907211302.GA5892-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-07 21:13   ` [RFC][v5][PATCH 1/8]: Factor out code to allocate pidmap page Sukadev Bhattiprolu
2009-09-07 21:14   ` [RFC][v5][PATCH 2/8]: Have alloc_pidmap() return actual error code Sukadev Bhattiprolu
2009-09-07 21:14   ` [RFC][v5][PATCH 3/8] Make pid_max a pid_ns property Sukadev Bhattiprolu
2009-09-07 21:15   ` [RFC][v5][PATCH 4/8]: Add target_pid parameter to alloc_pidmap() Sukadev Bhattiprolu
     [not found]     ` <20090907211506.GD6685-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-08 14:16       ` Serge E. Hallyn
2009-09-07 21:15   ` [RFC][v5][PATCH 5/8]: Add target_pids parameter to alloc_pid() Sukadev Bhattiprolu
2009-09-07 21:15   ` Sukadev Bhattiprolu [this message]
2009-09-07 21:16   ` [RFC][v5][PATCH 7/8]: Define do_fork_with_pids() Sukadev Bhattiprolu
2009-09-07 21:17   ` [RFC][v5][PATCH 8/8]: Define clone_with_pids() syscall Sukadev Bhattiprolu
     [not found] ` <20090907211700.GH6685@us.ibm.com>
     [not found]   ` <20090907211700.GH6685-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-08 18:19     ` Nathan Lynch
     [not found]   ` <m3zl95l2oz.fsf@pobox.com>
     [not found]     ` <m3zl95l2oz.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-09-09 12:19       ` Arnd Bergmann
     [not found]         ` <200909091419.50496.arnd-r2nGTMty4D4@public.gmane.org>
2009-09-09 15:51           ` H. Peter Anvin
     [not found]             ` <4AA7CF1F.3020408-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2009-09-09 18:03               ` Sukadev Bhattiprolu
     [not found]             ` <20090909180303.GA21048@us.ibm.com>
     [not found]               ` <20090909180303.GA21048-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-09 18:01                 ` H. Peter Anvin
2009-09-09 18:34                 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090907211553.GF6685@us.ibm.com \
    --to=sukadev-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
    --cc=adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mingo-X9Un+BFzKDI@public.gmane.org \
    --cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox