Linux Container Development
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Containers
	<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>,
	"Eric W. Biederman"
	<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
	mingo-X9Un+BFzKDI@public.gmane.org,
	Sukadev Bhattiprolu
	<sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
	torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
	Alexey Dobriyan
	<adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Pavel Emelyanov <xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
Subject: Re: [RFC][v5][PATCH 8/8]: Define clone_with_pids() syscall
Date: Wed, 09 Sep 2009 08:51:59 -0700	[thread overview]
Message-ID: <4AA7CF1F.3020408@zytor.com> (raw)
In-Reply-To: <200909091419.50496.arnd-r2nGTMty4D4@public.gmane.org>

On 09/09/2009 05:19 AM, Arnd Bergmann wrote:
> 
> This is a complex problem. The structure above would need a conversion
> for the pointer size that you can avoid by using a u64, but that introduces
> another problem:
> 
> 2. use a single pointer, with variable length data structures:
> 
> struct pid_set {
> 	int num_pids;
> 	pid_t pids[0];
> };
> 
> Since pid_t is always an int, you have no problem with padding or
> incompatible types, but rely on a data structure definition that
> is not in C89 (not sure about C99).
> 

C90 has these data structures, but you have to give the array a nonzero
length:

struct pid_set {
	int num_pids;
	pid_t pids[1];
};

In C99, this is spelt:

struct pid_set {
	int num_pids;
	pid_t pids[];
};

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

  parent reply	other threads:[~2009-09-09 15:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-07 21:13 [RFC][v5] clone_with_pids() system call Sukadev Bhattiprolu
     [not found] ` <20090907211302.GA5892-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-07 21:13   ` [RFC][v5][PATCH 1/8]: Factor out code to allocate pidmap page Sukadev Bhattiprolu
2009-09-07 21:14   ` [RFC][v5][PATCH 2/8]: Have alloc_pidmap() return actual error code Sukadev Bhattiprolu
2009-09-07 21:14   ` [RFC][v5][PATCH 3/8] Make pid_max a pid_ns property Sukadev Bhattiprolu
2009-09-07 21:15   ` [RFC][v5][PATCH 4/8]: Add target_pid parameter to alloc_pidmap() Sukadev Bhattiprolu
     [not found]     ` <20090907211506.GD6685-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-08 14:16       ` Serge E. Hallyn
2009-09-07 21:15   ` [RFC][v5][PATCH 5/8]: Add target_pids parameter to alloc_pid() Sukadev Bhattiprolu
2009-09-07 21:15   ` [RFC][v5][PATCH 6/8]: Add target_pids parameter to copy_process() Sukadev Bhattiprolu
2009-09-07 21:16   ` [RFC][v5][PATCH 7/8]: Define do_fork_with_pids() Sukadev Bhattiprolu
2009-09-07 21:17   ` [RFC][v5][PATCH 8/8]: Define clone_with_pids() syscall Sukadev Bhattiprolu
     [not found] ` <20090907211700.GH6685@us.ibm.com>
     [not found]   ` <20090907211700.GH6685-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-08 18:19     ` Nathan Lynch
     [not found]   ` <m3zl95l2oz.fsf@pobox.com>
     [not found]     ` <m3zl95l2oz.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-09-09 12:19       ` Arnd Bergmann
     [not found]         ` <200909091419.50496.arnd-r2nGTMty4D4@public.gmane.org>
2009-09-09 15:51           ` H. Peter Anvin [this message]
     [not found]             ` <4AA7CF1F.3020408-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2009-09-09 18:03               ` Sukadev Bhattiprolu
     [not found]             ` <20090909180303.GA21048@us.ibm.com>
     [not found]               ` <20090909180303.GA21048-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-09 18:01                 ` H. Peter Anvin
2009-09-09 18:34                 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AA7CF1F.3020408@zytor.com \
    --to=hpa-ymnouzjc4hwavxtiumwx3w@public.gmane.org \
    --cc=adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mingo-X9Un+BFzKDI@public.gmane.org \
    --cc=ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org \
    --cc=sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    --cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox