Linux Container Development
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org
Subject: Re: [PATCH] cr_test: include unistd.h for syscall numbers
Date: Wed, 16 Sep 2009 14:49:33 -0500	[thread overview]
Message-ID: <20090916194933.GA16025@us.ibm.com> (raw)
In-Reply-To: <1253091924-15309-1-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>

Quoting Nathan Lynch (ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org):
> Instead of duplicating the checkpoint/restart/clone_with_pids system
> call numbers for powerpc in cr.h, just #include asm/unistd.h and
> remove the #error; the build will fail intelligibly if those constants
> are undefined.
> 
> (also add guards to prevent multiple inclusion)
> 
> Signed-off-by: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>

Applied.

thanks,
-serge

> ---
>  cr.h |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/cr.h b/cr.h
> index f24b7b0..a7dce6a 100644
> --- a/cr.h
> +++ b/cr.h
> @@ -1,6 +1,9 @@
>  /* AUTOMATICALLY GENERATED by rewrite-cr-header.sh */
> 
> +#ifndef _LINUX_CHECKPOINT_H_ 
>  #define _LINUX_CHECKPOINT_H_ 
> +
> +#include <asm/unistd.h>
>  /*
>   *  Generic checkpoint-restart
>   *
> @@ -90,6 +93,6 @@
>  /* x86_64 unsupported. */
>  /* x86_64 unsupported. */
>  /* xtensa unsupported. */
> -#else
> -#error "Architecture does not have definitons for __NR_(checkpoint|restart)"
> +#endif
> +
>  #endif
> -- 
> 1.6.0.6

      parent reply	other threads:[~2009-09-16 19:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-16  9:05 [PATCH] cr_test: include unistd.h for syscall numbers Nathan Lynch
     [not found] ` <1253091924-15309-1-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-09-16 19:49   ` Serge E. Hallyn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090916194933.GA16025@us.ibm.com \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox