Linux Container Development
 help / color / mirror / Atom feed
* [PATCH] cr_test: include unistd.h for syscall numbers
@ 2009-09-16  9:05 Nathan Lynch
       [not found] ` <1253091924-15309-1-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Nathan Lynch @ 2009-09-16  9:05 UTC (permalink / raw)
  To: Serge E. Hallyn; +Cc: containers-qjLDD68F18O7TbgM5vRIOg

Instead of duplicating the checkpoint/restart/clone_with_pids system
call numbers for powerpc in cr.h, just #include asm/unistd.h and
remove the #error; the build will fail intelligibly if those constants
are undefined.

(also add guards to prevent multiple inclusion)

Signed-off-by: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
---
 cr.h |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/cr.h b/cr.h
index f24b7b0..a7dce6a 100644
--- a/cr.h
+++ b/cr.h
@@ -1,6 +1,9 @@
 /* AUTOMATICALLY GENERATED by rewrite-cr-header.sh */
 
+#ifndef _LINUX_CHECKPOINT_H_ 
 #define _LINUX_CHECKPOINT_H_ 
+
+#include <asm/unistd.h>
 /*
  *  Generic checkpoint-restart
  *
@@ -90,6 +93,6 @@
 /* x86_64 unsupported. */
 /* x86_64 unsupported. */
 /* xtensa unsupported. */
-#else
-#error "Architecture does not have definitons for __NR_(checkpoint|restart)"
+#endif
+
 #endif
-- 
1.6.0.6

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] cr_test: include unistd.h for syscall numbers
       [not found] ` <1253091924-15309-1-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
@ 2009-09-16 19:49   ` Serge E. Hallyn
  0 siblings, 0 replies; 2+ messages in thread
From: Serge E. Hallyn @ 2009-09-16 19:49 UTC (permalink / raw)
  To: Nathan Lynch; +Cc: containers-qjLDD68F18O7TbgM5vRIOg

Quoting Nathan Lynch (ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org):
> Instead of duplicating the checkpoint/restart/clone_with_pids system
> call numbers for powerpc in cr.h, just #include asm/unistd.h and
> remove the #error; the build will fail intelligibly if those constants
> are undefined.
> 
> (also add guards to prevent multiple inclusion)
> 
> Signed-off-by: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>

Applied.

thanks,
-serge

> ---
>  cr.h |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/cr.h b/cr.h
> index f24b7b0..a7dce6a 100644
> --- a/cr.h
> +++ b/cr.h
> @@ -1,6 +1,9 @@
>  /* AUTOMATICALLY GENERATED by rewrite-cr-header.sh */
> 
> +#ifndef _LINUX_CHECKPOINT_H_ 
>  #define _LINUX_CHECKPOINT_H_ 
> +
> +#include <asm/unistd.h>
>  /*
>   *  Generic checkpoint-restart
>   *
> @@ -90,6 +93,6 @@
>  /* x86_64 unsupported. */
>  /* x86_64 unsupported. */
>  /* xtensa unsupported. */
> -#else
> -#error "Architecture does not have definitons for __NR_(checkpoint|restart)"
> +#endif
> +
>  #endif
> -- 
> 1.6.0.6

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-09-16 19:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-16  9:05 [PATCH] cr_test: include unistd.h for syscall numbers Nathan Lynch
     [not found] ` <1253091924-15309-1-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-09-16 19:49   ` Serge E. Hallyn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox