Linux Container Development
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH 2/2] user-cr: s390: Detect s390x arch too
Date: Thu, 24 Sep 2009 08:45:44 -0500	[thread overview]
Message-ID: <20090924134544.GA22163@us.ibm.com> (raw)
In-Reply-To: <1253743418-10091-2-git-send-email-matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

Quoting Matt Helsley (matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org):
> Signed-off-by: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

We don't actually support s390, but if/when we do it seems reasonable
to assume it'll be handled the same as s390x, so

Acked-by: Serge Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

(Certainly the original code, checking only defined(__s390)) wasn't right)

> ---
>  ckptinfo.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ckptinfo.c b/ckptinfo.c
> index b2101e6..6859742 100644
> --- a/ckptinfo.c
> +++ b/ckptinfo.c
> @@ -63,7 +63,7 @@ static int image_parse_error(struct ckpt_hdr *h, int fd, struct args *args);
>  #define __HAVE_image_parse_cpu
>  #define image_parse_cpu   image_parse_cpu_X86
>  static int image_parse_cpu_X86(struct ckpt_hdr *h, int fd, struct args *args);
> -#elif defined(__s390__)
> +#elif defined(__s390__) || defined(__s390x__)
>  #define __HAVE_image_parse_cpu
>  #define image_parse_cpu   image_parse_cpu_s390
>  static int image_parse_cpu_s390(struct ckpt_hdr *h, int fd, struct args *args);
> @@ -301,7 +301,7 @@ static int image_parse_cpu_X86(struct ckpt_hdr *h, int fd, struct args *args)
>  }
>  #endif
> 
> -#ifdef __s390__
> +#if defined(__s390__) || defined(__s390x__)
>  static int image_parse_cpu_s390(struct ckpt_hdr *h, int fd, struct args *args)
>  {
>  	struct ckpt_hdr_cpu *hh = (struct ckpt_hdr_cpu *) h;
> -- 
> 1.5.6.3
> 
> _______________________________________________
> Containers mailing list
> Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
> https://lists.linux-foundation.org/mailman/listinfo/containers

      parent reply	other threads:[~2009-09-24 13:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-23 22:03 [PATCH 2/2] user-cr: s390: Detect s390x arch too Matt Helsley
     [not found] ` <1253743418-10091-2-git-send-email-matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-24 13:45   ` Serge E. Hallyn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090924134544.GA22163@us.ibm.com \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox