Linux Container Development
 help / color / mirror / Atom feed
* [PATCH 2/2] user-cr: s390: Detect s390x arch too
@ 2009-09-23 22:03 Matt Helsley
       [not found] ` <1253743418-10091-2-git-send-email-matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Matt Helsley @ 2009-09-23 22:03 UTC (permalink / raw)
  To: Oren Laadan; +Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA

Signed-off-by: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
 ckptinfo.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ckptinfo.c b/ckptinfo.c
index b2101e6..6859742 100644
--- a/ckptinfo.c
+++ b/ckptinfo.c
@@ -63,7 +63,7 @@ static int image_parse_error(struct ckpt_hdr *h, int fd, struct args *args);
 #define __HAVE_image_parse_cpu
 #define image_parse_cpu   image_parse_cpu_X86
 static int image_parse_cpu_X86(struct ckpt_hdr *h, int fd, struct args *args);
-#elif defined(__s390__)
+#elif defined(__s390__) || defined(__s390x__)
 #define __HAVE_image_parse_cpu
 #define image_parse_cpu   image_parse_cpu_s390
 static int image_parse_cpu_s390(struct ckpt_hdr *h, int fd, struct args *args);
@@ -301,7 +301,7 @@ static int image_parse_cpu_X86(struct ckpt_hdr *h, int fd, struct args *args)
 }
 #endif
 
-#ifdef __s390__
+#if defined(__s390__) || defined(__s390x__)
 static int image_parse_cpu_s390(struct ckpt_hdr *h, int fd, struct args *args)
 {
 	struct ckpt_hdr_cpu *hh = (struct ckpt_hdr_cpu *) h;
-- 
1.5.6.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/2] user-cr: s390: Detect s390x arch too
       [not found] ` <1253743418-10091-2-git-send-email-matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
@ 2009-09-24 13:45   ` Serge E. Hallyn
  0 siblings, 0 replies; 2+ messages in thread
From: Serge E. Hallyn @ 2009-09-24 13:45 UTC (permalink / raw)
  To: Matt Helsley; +Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA

Quoting Matt Helsley (matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org):
> Signed-off-by: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

We don't actually support s390, but if/when we do it seems reasonable
to assume it'll be handled the same as s390x, so

Acked-by: Serge Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

(Certainly the original code, checking only defined(__s390)) wasn't right)

> ---
>  ckptinfo.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ckptinfo.c b/ckptinfo.c
> index b2101e6..6859742 100644
> --- a/ckptinfo.c
> +++ b/ckptinfo.c
> @@ -63,7 +63,7 @@ static int image_parse_error(struct ckpt_hdr *h, int fd, struct args *args);
>  #define __HAVE_image_parse_cpu
>  #define image_parse_cpu   image_parse_cpu_X86
>  static int image_parse_cpu_X86(struct ckpt_hdr *h, int fd, struct args *args);
> -#elif defined(__s390__)
> +#elif defined(__s390__) || defined(__s390x__)
>  #define __HAVE_image_parse_cpu
>  #define image_parse_cpu   image_parse_cpu_s390
>  static int image_parse_cpu_s390(struct ckpt_hdr *h, int fd, struct args *args);
> @@ -301,7 +301,7 @@ static int image_parse_cpu_X86(struct ckpt_hdr *h, int fd, struct args *args)
>  }
>  #endif
> 
> -#ifdef __s390__
> +#if defined(__s390__) || defined(__s390x__)
>  static int image_parse_cpu_s390(struct ckpt_hdr *h, int fd, struct args *args)
>  {
>  	struct ckpt_hdr_cpu *hh = (struct ckpt_hdr_cpu *) h;
> -- 
> 1.5.6.3
> 
> _______________________________________________
> Containers mailing list
> Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
> https://lists.linux-foundation.org/mailman/listinfo/containers

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-09-24 13:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-23 22:03 [PATCH 2/2] user-cr: s390: Detect s390x arch too Matt Helsley
     [not found] ` <1253743418-10091-2-git-send-email-matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-24 13:45   ` Serge E. Hallyn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox