Linux Container Development
 help / color / mirror / Atom feed
* [PATCH cr-tests] file locks: don't report failed checkpoint as failure
@ 2010-02-15 16:52 Serge E. Hallyn
  0 siblings, 0 replies; only message in thread
From: Serge E. Hallyn @ 2010-02-15 16:52 UTC (permalink / raw)
  To: Linux Containers

And report failure if checkpoint succeeds, bc it should not.

Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
 fileio/run-fcntltests.sh |   10 +++++++++-
 fileio/runtests.sh       |    3 +++
 2 files changed, 12 insertions(+), 1 deletions(-)

diff --git a/fileio/run-fcntltests.sh b/fileio/run-fcntltests.sh
index 35be131..2a5f628 100755
--- a/fileio/run-fcntltests.sh
+++ b/fileio/run-fcntltests.sh
@@ -51,8 +51,16 @@ checkpoint()
 	$ECHO "\t- Checkpoint: $CHECKPOINT $pid \> $CHECKPOINT_FILE"
 	$CHECKPOINT $pid > $CHECKPOINT_FILE
 	ret=$?
+	# At the moment we expect failure because checkpoint
+	# of file locks is not supported
 	if [ $ret -ne 0 ]; then
-		$ECHO "***** FAIL: Checkpoint of $pid failed"
+		$ECHO "***** PASS: Checkpoint of $pid failed"
+		ps -efL |grep $TEST_CMD >> $SCRIPT_LOG
+		killall -9 `basename $TEST_CMD`
+		thaw
+		exit 0;
+	else
+		$ECHO "***** FAIL: Checkpoint of $pid did not fail"
 		ps -efL |grep $TEST_CMD >> $SCRIPT_LOG
 		killall -9 `basename $TEST_CMD`
 		thaw
diff --git a/fileio/runtests.sh b/fileio/runtests.sh
index b808927..cb633fb 100755
--- a/fileio/runtests.sh
+++ b/fileio/runtests.sh
@@ -7,15 +7,18 @@ echo
 
 echo
 echo "****** $0: Running test: filelock1"
+echo "****** (expect FAIL)"
 echo
 ./run-fcntltests.sh filelock1
 
 echo
 echo "****** $0: Running test: filelease1"
+echo "****** (expect FAIL)"
 echo
 ./run-fcntltests.sh filelease1
 
 echo
 echo "****** $0: Running test: fsetown1"
+echo "****** (expect FAIL)"
 echo
 ./run-fcntltests.sh fsetown1
-- 
1.6.3.3

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-02-15 16:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-15 16:52 [PATCH cr-tests] file locks: don't report failed checkpoint as failure Serge E. Hallyn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox