From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org,
dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org,
clg-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org
Cc: Containers
<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: [PATCH 1/2][LXC] Rename --directory option to --statefile
Date: Wed, 24 Feb 2010 00:41:08 -0800 [thread overview]
Message-ID: <20100224084108.GG18758@us.ibm.com> (raw)
----
From 94fe79c36ac3aed69c8d97f8e4d17c9b02961b97 Mon Sep 17 00:00:00 2001
From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Date: Tue, 23 Feb 2010 17:47:51 -0800
Subject: [PATCH 1/2] Rename --directory option to --statefile
[See following mail for an intro to this patch set
https://lists.linux-foundation.org/pipermail/containers/2010-February/023048.html]
The --directory is misleading since the option seems to expect
an checkpoint image file.
Signed-off-by: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
---
src/lxc/lxc_restart.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/lxc/lxc_restart.c b/src/lxc/lxc_restart.c
index 7db1d85..83d3d7b 100644
--- a/src/lxc/lxc_restart.c
+++ b/src/lxc/lxc_restart.c
@@ -52,7 +52,7 @@ static int my_checker(const struct lxc_arguments* args)
static int my_parser(struct lxc_arguments* args, int c, char* arg)
{
switch (c) {
- case 'd': args->statefile = arg; break;
+ case 'i': args->statefile = arg; break;
case 'f': args->rcfile = arg; break;
case 'p': args->flags = LXC_FLAG_PAUSE; break;
case 's': return lxc_config_define_add(&defines, arg);
@@ -62,7 +62,7 @@ static int my_parser(struct lxc_arguments* args, int c, char* arg)
}
static const struct option my_longopts[] = {
- {"directory", required_argument, 0, 'd'},
+ {"statefile", required_argument, 0, 'i'},
{"rcfile", required_argument, 0, 'f'},
{"pause", no_argument, 0, 'p'},
{"define", required_argument, 0, 's'},
@@ -72,14 +72,14 @@ static const struct option my_longopts[] = {
static struct lxc_arguments my_args = {
.progname = "lxc-restart",
.help = "\
---name=NAME --directory STATEFILE\n\
+--name=NAME --statefile STATEFILE\n\
\n\
-lxc-restart restarts from STATEFILE the NAME container\n\
+lxc-restart restarts from checkpoint image STATEFILE the NAME container\n\
\n\
Options :\n\
-n, --name=NAME NAME for name of the container\n\
-p, --pause do not release the container after the restart\n\
- -d, --directory=STATEFILE for name of statefile\n\
+ -i, --statefile=STATEFILE for name of statefile\n\
-f, --rcfile=FILE Load configuration file FILE\n\
-s, --define KEY=VAL Assign VAL to configuration variable KEY\n",
.options = my_longopts,
--
1.6.6.1
next reply other threads:[~2010-02-24 8:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 8:41 Sukadev Bhattiprolu [this message]
[not found] ` <20100224084108.GG18758-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-02-24 8:41 ` [PATCH 2/2][LXC] Have lxc_restart call app_restart() Sukadev Bhattiprolu
[not found] ` <20100224084156.GH18758-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-02-24 8:45 ` Cedric Le Goater
2010-02-24 8:49 ` [PATCH 1/2][LXC] Rename --directory option to --statefile Cedric Le Goater
[not found] ` <4B84E80A.7060208-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2010-02-24 8:54 ` Daniel Lezcano
[not found] ` <4B84E94E.3000406-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2010-02-24 18:11 ` Sukadev Bhattiprolu
[not found] ` <20100224181150.GA3276-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-02-24 18:11 ` Cedric Le Goater
[not found] ` <4B856BC8.5060000-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2010-02-24 18:30 ` Serge E. Hallyn
[not found] ` <20100224183024.GA22624-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-02-24 18:39 ` Cedric Le Goater
[not found] ` <4B85725C.3010002-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2010-02-24 18:45 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100224084108.GG18758@us.ibm.com \
--to=sukadev-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=clg-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org \
--cc=serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox