From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Daniel Lezcano <dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
Cc: Containers
<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
Cedric Le Goater <clg-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 1/2][LXC] Rename --directory option to --statefile
Date: Wed, 24 Feb 2010 10:11:50 -0800 [thread overview]
Message-ID: <20100224181150.GA3276@us.ibm.com> (raw)
In-Reply-To: <4B84E94E.3000406-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
Daniel Lezcano [dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org] wrote:
> Cedric Le Goater wrote:
>> On 02/24/2010 09:41 AM, Sukadev Bhattiprolu wrote:
>>> [See following mail for an intro to this patch set
>>>
>>> https://lists.linux-foundation.org/pipermail/containers/2010-February/023048.html]
>>>
>>>
>>>
>>> The --directory is misleading since the option seems to expect
>>> an checkpoint image file.
>> sigh.
>>
>> This has some major impact on our side as it is a 9 year old API ...
>> We'll look into it to see how painful it is to change.
Ah, did not realize it caused that much pain.
>
> We can keep --directory and add --statefile.
> For --statefile option we can use a switch for IS_DIR, IS_REG.
>
> --directory becomes deprecated and we switch to the statefile option
> step by step.
>
> Does it make sense ?
Yes, I think it will work.
BTW, what was the rationale for a directory ? Is it meant to be used
with predefined file names in the specified directory ?
>
> -- Daniel
next prev parent reply other threads:[~2010-02-24 18:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 8:41 [PATCH 1/2][LXC] Rename --directory option to --statefile Sukadev Bhattiprolu
[not found] ` <20100224084108.GG18758-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-02-24 8:41 ` [PATCH 2/2][LXC] Have lxc_restart call app_restart() Sukadev Bhattiprolu
[not found] ` <20100224084156.GH18758-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-02-24 8:45 ` Cedric Le Goater
2010-02-24 8:49 ` [PATCH 1/2][LXC] Rename --directory option to --statefile Cedric Le Goater
[not found] ` <4B84E80A.7060208-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2010-02-24 8:54 ` Daniel Lezcano
[not found] ` <4B84E94E.3000406-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2010-02-24 18:11 ` Sukadev Bhattiprolu [this message]
[not found] ` <20100224181150.GA3276-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-02-24 18:11 ` Cedric Le Goater
[not found] ` <4B856BC8.5060000-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2010-02-24 18:30 ` Serge E. Hallyn
[not found] ` <20100224183024.GA22624-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-02-24 18:39 ` Cedric Le Goater
[not found] ` <4B85725C.3010002-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2010-02-24 18:45 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100224181150.GA3276@us.ibm.com \
--to=sukadev-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=clg-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox