Linux Container Development
 help / color / mirror / Atom feed
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>
Cc: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
	"Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
	"Aneesh Kumar K.V"
	<aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
	Arnaldo Carvalho de Melo
	<acme-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	Thomas Graf <tgraf-G/eBtMaohhA@public.gmane.org>,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Paul Turner <pjt-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH REPOST RFC cgroup/for-3.7] cgroup: mark subsystems with broken hierarchy support and whine if cgroups are nested for them
Date: Wed, 12 Sep 2012 09:41:02 -0700	[thread overview]
Message-ID: <20120912164102.GM7677@google.com> (raw)
In-Reply-To: <20120912154745.GV21579-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>

Hello,

On Wed, Sep 12, 2012 at 05:47:45PM +0200, Michal Hocko wrote:
> > If it's absolutely necessary, I think it should be a root-only flag
> > (even if that ends up using the same code path).  Eventually, we
> > really want to kill .use_hierarchy, or at least make it to RO 1.  As
> > it's currently defined, it's just way too confusing.
> 
> Agreed on that, definitely.

The thing is that if we're gonna be headed that way, we're gonna have
to nudge people to .use_hierarchy = 1 everywher first.  If
.use_hierarchy = 0 at root is a valid use case which absolutedly needs
to be maintained (from what I read, I don't think it is), let's move
it to a different root-only flag; otherwise, it should be phased out.
As such, while the user might not be necessarily wrong, we still need
to unify the behavior, I think.

Thanks.

-- 
tejun

  parent reply	other threads:[~2012-09-12 16:41 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120910223125.GC7677@google.com>
     [not found] ` <20120910223125.GC7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-10 22:33   ` [PATCH REPOST RFC cgroup/for-3.7] cgroup: mark subsystems with broken hierarchy support and whine if cgroups are nested for them Tejun Heo
     [not found] ` <20120910223355.GD7677@google.com>
     [not found]   ` <504F30DB.60808@huawei.com>
     [not found]     ` <504F30DB.60808-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2012-09-11 17:08       ` Tejun Heo
2012-09-12  9:34       ` Glauber Costa
     [not found]     ` <20120911170837.GM7677@google.com>
     [not found]       ` <20120911170837.GM7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-11 17:43         ` Tejun Heo
     [not found]           ` <20120911174319.GO7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-12  9:37             ` Glauber Costa
     [not found]               ` <505057D8.4010908-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-12 16:34                 ` Tejun Heo
     [not found]                   ` <20120912163433.GL7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-13  6:48                     ` Li Zefan
     [not found]   ` <20120910223355.GD7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-11 10:04     ` Michal Hocko
     [not found]       ` <20120911100433.GC8058-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-11 17:07         ` Tejun Heo
2012-09-12  9:31         ` Glauber Costa
     [not found]           ` <5050568B.9090601-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-12 15:49             ` Michal Hocko
     [not found]               ` <20120912154907.GW21579-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-12 17:11                 ` Tejun Heo
     [not found]                   ` <20120912171120.GP7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-13 12:01                     ` Glauber Costa
     [not found]                       ` <5051CB24.4010801-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-13 17:21                         ` Tejun Heo
2012-09-13 12:14                     ` Michal Hocko
     [not found]                       ` <20120913121438.GC8055-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-13 17:18                         ` Tejun Heo
     [not found]                           ` <20120913171832.GY7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-13 17:39                             ` Michal Hocko
     [not found]                               ` <20120913173958.GA21381-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-14  8:19                                 ` Glauber Costa
     [not found]                                   ` <5052E87A.1050405-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-14 19:15                                     ` Tejun Heo
     [not found]                                       ` <20120914191509.GN17747-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-17  9:11                                         ` Glauber Costa
     [not found]       ` <20120911170746.GL7677@google.com>
     [not found]         ` <20120911170746.GL7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-12 15:47           ` Michal Hocko
     [not found]         ` <20120912154745.GV21579@dhcp22.suse.cz>
     [not found]           ` <20120912154745.GV21579-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-12 16:41             ` Tejun Heo [this message]
2012-09-11 12:38     ` Li Zefan
2012-09-11 18:23     ` [PATCH UPDATED " Tejun Heo
2012-09-13 12:16     ` [PATCH REPOST " Daniel P. Berrange
     [not found]       ` <20120913121629.GL7767-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-13 17:52         ` Tejun Heo
     [not found]   ` <20120911182356.GR7677@google.com>
     [not found]     ` <20120911182356.GR7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-11 20:50       ` [PATCH UPDATED " Aristeu Rozanski
     [not found]         ` <20120911205027.GA25837-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-11 20:51           ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120912164102.GM7677@google.com \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=acme-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org \
    --cc=aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
    --cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
    --cc=paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
    --cc=pjt-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=tgraf-G/eBtMaohhA@public.gmane.org \
    --cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox