* [PATCH] fix spurious EBUSY on memory cgroup removal
@ 2008-02-01 3:46 YAMAMOTO Takashi
[not found] ` <20080201034624.770651E3C10-Pcsii4f/SVk@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: YAMAMOTO Takashi @ 2008-02-01 3:46 UTC (permalink / raw)
To: balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8
Cc: containers-qjLDD68F18O7TbgM5vRIOg,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg
hi,
the following patch is to fix spurious EBUSY on cgroup removal.
YAMAMOTO Takashi
call mm_free_cgroup earlier.
otherwise a reference due to lazy mm switching can prevent cgroup removal.
Signed-off-by: YAMAMOTO Takashi <yamamoto-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org>
---
--- linux-2.6.24-rc8-mm1/kernel/fork.c.BACKUP 2008-01-23 14:43:29.000000000 +0900
+++ linux-2.6.24-rc8-mm1/kernel/fork.c 2008-01-31 17:26:31.000000000 +0900
@@ -393,7 +393,6 @@ void __mmdrop(struct mm_struct *mm)
{
BUG_ON(mm == &init_mm);
mm_free_pgd(mm);
- mm_free_cgroup(mm);
destroy_context(mm);
free_mm(mm);
}
@@ -415,6 +414,7 @@ void mmput(struct mm_struct *mm)
spin_unlock(&mmlist_lock);
}
put_swap_token(mm);
+ mm_free_cgroup(mm);
mmdrop(mm);
}
}
^ permalink raw reply [flat|nested] 7+ messages in thread[parent not found: <20080201034624.770651E3C10-Pcsii4f/SVk@public.gmane.org>]
* Re: [PATCH] fix spurious EBUSY on memory cgroup removal [not found] ` <20080201034624.770651E3C10-Pcsii4f/SVk@public.gmane.org> @ 2008-02-02 4:10 ` Balbir Singh 0 siblings, 0 replies; 7+ messages in thread From: Balbir Singh @ 2008-02-02 4:10 UTC (permalink / raw) To: YAMAMOTO Takashi Cc: containers-qjLDD68F18O7TbgM5vRIOg, linux-mm-Bw31MaZKKs3YtjvyW6yDsg YAMAMOTO Takashi wrote: > hi, > > the following patch is to fix spurious EBUSY on cgroup removal. > > YAMAMOTO Takashi > > > call mm_free_cgroup earlier. > otherwise a reference due to lazy mm switching can prevent cgroup removal. > > Signed-off-by: YAMAMOTO Takashi <yamamoto-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org> > --- > > --- linux-2.6.24-rc8-mm1/kernel/fork.c.BACKUP 2008-01-23 14:43:29.000000000 +0900 > +++ linux-2.6.24-rc8-mm1/kernel/fork.c 2008-01-31 17:26:31.000000000 +0900 > @@ -393,7 +393,6 @@ void __mmdrop(struct mm_struct *mm) > { > BUG_ON(mm == &init_mm); > mm_free_pgd(mm); > - mm_free_cgroup(mm); > destroy_context(mm); > free_mm(mm); > } > @@ -415,6 +414,7 @@ void mmput(struct mm_struct *mm) > spin_unlock(&mmlist_lock); > } > put_swap_token(mm); > + mm_free_cgroup(mm); > mmdrop(mm); > } > } The difference I see with the change is that mmput() will now call mm_free_cgroup() when mm->mm_users drop to 0 and __mmdrop() will call it when mm->mm_count drops to 0. I think this change makes sense Acked-by: Balbir Singh <balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] fix spurious EBUSY on memory cgroup removal
@ 2008-03-25 5:47 YAMAMOTO Takashi
[not found] ` <20080325054713.948EF1E92EC-Pcsii4f/SVk@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: YAMAMOTO Takashi @ 2008-03-25 5:47 UTC (permalink / raw)
To: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b
Cc: containers-qjLDD68F18O7TbgM5vRIOg,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg, minoura-jCdQPDEk3idL9jVzuh4AOg,
balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8
[ resending with To: akpm. Andrew, can you include this in -mm tree? ]
hi,
the following patch is to fix spurious EBUSY on cgroup removal.
YAMAMOTO Takashi
call mm_free_cgroup earlier.
otherwise a reference due to lazy mm switching can prevent cgroup removal.
Signed-off-by: YAMAMOTO Takashi <yamamoto-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org>
Acked-by: Balbir Singh <balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
---
--- linux-2.6.24-rc8-mm1/kernel/fork.c.BACKUP 2008-01-23 14:43:29.000000000 +0900
+++ linux-2.6.24-rc8-mm1/kernel/fork.c 2008-01-31 17:26:31.000000000 +0900
@@ -393,7 +393,6 @@ void __mmdrop(struct mm_struct *mm)
{
BUG_ON(mm == &init_mm);
mm_free_pgd(mm);
- mm_free_cgroup(mm);
destroy_context(mm);
free_mm(mm);
}
@@ -415,6 +414,7 @@ void mmput(struct mm_struct *mm)
spin_unlock(&mmlist_lock);
}
put_swap_token(mm);
+ mm_free_cgroup(mm);
mmdrop(mm);
}
}
^ permalink raw reply [flat|nested] 7+ messages in thread[parent not found: <20080325054713.948EF1E92EC-Pcsii4f/SVk@public.gmane.org>]
* Re: [PATCH] fix spurious EBUSY on memory cgroup removal [not found] ` <20080325054713.948EF1E92EC-Pcsii4f/SVk@public.gmane.org> @ 2008-03-25 5:53 ` Andrew Morton [not found] ` <20080324225309.0a1ab8ec.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Andrew Morton @ 2008-03-25 5:53 UTC (permalink / raw) To: YAMAMOTO Takashi Cc: containers-qjLDD68F18O7TbgM5vRIOg, linux-mm-Bw31MaZKKs3YtjvyW6yDsg, minoura-jCdQPDEk3idL9jVzuh4AOg, balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8 On Tue, 25 Mar 2008 14:47:13 +0900 (JST) yamamoto-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org (YAMAMOTO Takashi) wrote: > [ resending with To: akpm. Andrew, can you include this in -mm tree? ] Shouldn't it be in 2.6.25? > hi, > > the following patch is to fix spurious EBUSY on cgroup removal. > > YAMAMOTO Takashi > > > call mm_free_cgroup earlier. > otherwise a reference due to lazy mm switching can prevent cgroup removal. > > Signed-off-by: YAMAMOTO Takashi <yamamoto-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org> > Acked-by: Balbir Singh <balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> > --- > > --- linux-2.6.24-rc8-mm1/kernel/fork.c.BACKUP 2008-01-23 14:43:29.000000000 +0900 > +++ linux-2.6.24-rc8-mm1/kernel/fork.c 2008-01-31 17:26:31.000000000 +0900 > @@ -393,7 +393,6 @@ void __mmdrop(struct mm_struct *mm) > { > BUG_ON(mm == &init_mm); > mm_free_pgd(mm); > - mm_free_cgroup(mm); > destroy_context(mm); > free_mm(mm); > } > @@ -415,6 +414,7 @@ void mmput(struct mm_struct *mm) > spin_unlock(&mmlist_lock); > } > put_swap_token(mm); > + mm_free_cgroup(mm); > mmdrop(mm); > } > } ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20080324225309.0a1ab8ec.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>]
* Re: [PATCH] fix spurious EBUSY on memory cgroup removal [not found] ` <20080324225309.0a1ab8ec.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> @ 2008-03-25 6:28 ` YAMAMOTO Takashi 2008-03-25 6:30 ` KAMEZAWA Hiroyuki 1 sibling, 0 replies; 7+ messages in thread From: YAMAMOTO Takashi @ 2008-03-25 6:28 UTC (permalink / raw) To: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b Cc: containers-qjLDD68F18O7TbgM5vRIOg, linux-mm-Bw31MaZKKs3YtjvyW6yDsg, balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8, minoura-jCdQPDEk3idL9jVzuh4AOg > On Tue, 25 Mar 2008 14:47:13 +0900 (JST) yamamoto-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org (YAMAMOTO Takashi) wrote: > > > [ resending with To: akpm. Andrew, can you include this in -mm tree? ] > > Shouldn't it be in 2.6.25? yes, probably. (i'm not sure about linux development model.) YAMAMOTO Takashi > > > hi, > > > > the following patch is to fix spurious EBUSY on cgroup removal. > > > > YAMAMOTO Takashi > > > > > > call mm_free_cgroup earlier. > > otherwise a reference due to lazy mm switching can prevent cgroup removal. > > > > Signed-off-by: YAMAMOTO Takashi <yamamoto-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org> > > Acked-by: Balbir Singh <balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> > > --- > > > > --- linux-2.6.24-rc8-mm1/kernel/fork.c.BACKUP 2008-01-23 14:43:29.000000000 +0900 > > +++ linux-2.6.24-rc8-mm1/kernel/fork.c 2008-01-31 17:26:31.000000000 +0900 > > @@ -393,7 +393,6 @@ void __mmdrop(struct mm_struct *mm) > > { > > BUG_ON(mm == &init_mm); > > mm_free_pgd(mm); > > - mm_free_cgroup(mm); > > destroy_context(mm); > > free_mm(mm); > > } > > @@ -415,6 +414,7 @@ void mmput(struct mm_struct *mm) > > spin_unlock(&mmlist_lock); > > } > > put_swap_token(mm); > > + mm_free_cgroup(mm); > > mmdrop(mm); > > } > > } > _______________________________________________ > Containers mailing list > Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org > https://lists.linux-foundation.org/mailman/listinfo/containers ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fix spurious EBUSY on memory cgroup removal [not found] ` <20080324225309.0a1ab8ec.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> 2008-03-25 6:28 ` YAMAMOTO Takashi @ 2008-03-25 6:30 ` KAMEZAWA Hiroyuki [not found] ` <20080325153020.d9179428.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> 1 sibling, 1 reply; 7+ messages in thread From: KAMEZAWA Hiroyuki @ 2008-03-25 6:30 UTC (permalink / raw) To: Andrew Morton Cc: containers-qjLDD68F18O7TbgM5vRIOg, linux-mm-Bw31MaZKKs3YtjvyW6yDsg, YAMAMOTO Takashi, minoura-jCdQPDEk3idL9jVzuh4AOg, balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8 On Mon, 24 Mar 2008 22:53:09 -0700 Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> wrote: > On Tue, 25 Mar 2008 14:47:13 +0900 (JST) yamamoto-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org (YAMAMOTO Takashi) wrote: > > > [ resending with To: akpm. Andrew, can you include this in -mm tree? ] > > Shouldn't it be in 2.6.25? > I think this should be. Thanks, -Kame ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20080325153020.d9179428.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>]
* Re: [PATCH] fix spurious EBUSY on memory cgroup removal [not found] ` <20080325153020.d9179428.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> @ 2008-03-25 6:28 ` Balbir Singh 0 siblings, 0 replies; 7+ messages in thread From: Balbir Singh @ 2008-03-25 6:28 UTC (permalink / raw) To: KAMEZAWA Hiroyuki Cc: containers-qjLDD68F18O7TbgM5vRIOg, linux-mm-Bw31MaZKKs3YtjvyW6yDsg, Andrew Morton, YAMAMOTO Takashi, minoura-jCdQPDEk3idL9jVzuh4AOg KAMEZAWA Hiroyuki wrote: > On Mon, 24 Mar 2008 22:53:09 -0700 > Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> wrote: > >> On Tue, 25 Mar 2008 14:47:13 +0900 (JST) yamamoto-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org (YAMAMOTO Takashi) wrote: >> >>> [ resending with To: akpm. Andrew, can you include this in -mm tree? ] >> Shouldn't it be in 2.6.25? >> > I think this should be. > > Thanks, > -Kame Me too -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-03-25 6:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-01 3:46 [PATCH] fix spurious EBUSY on memory cgroup removal YAMAMOTO Takashi
[not found] ` <20080201034624.770651E3C10-Pcsii4f/SVk@public.gmane.org>
2008-02-02 4:10 ` Balbir Singh
-- strict thread matches above, loose matches on Subject: below --
2008-03-25 5:47 YAMAMOTO Takashi
[not found] ` <20080325054713.948EF1E92EC-Pcsii4f/SVk@public.gmane.org>
2008-03-25 5:53 ` Andrew Morton
[not found] ` <20080324225309.0a1ab8ec.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-03-25 6:28 ` YAMAMOTO Takashi
2008-03-25 6:30 ` KAMEZAWA Hiroyuki
[not found] ` <20080325153020.d9179428.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-03-25 6:28 ` Balbir Singh
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox