* Re: [PATCH -mmotm] res_counter: fix building failure [not found] ` <486B1D3D.5070805-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> @ 2008-07-02 6:45 ` Paul Menage 0 siblings, 0 replies; 5+ messages in thread From: Paul Menage @ 2008-07-02 6:45 UTC (permalink / raw) To: Li Zefan Cc: Linux Containers, LKML, Andrew Morton, Balbir Singh, Pavel Emelianov On Tue, Jul 1, 2008 at 11:16 PM, Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> wrote: > kernel/res_counter.c: In function 'res_counter_memparse_write_strategy': > kernel/res_counter.c:115: error: implicit declaration of function 'PAGE_ALIGN' > > Signed-off-by: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> Acked-by: Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Thanks - what architecture did it break on? Paul > --- > > should follow cgroup-files-convert-res_counter_write-to-be-a-cgroups-write_string-handler.patch > > --- linux-mm/kernel/res_counter.c.bak 2008-07-02 14:05:37.000000000 +0800 > +++ linux-mm/kernel/res_counter.c 2008-07-02 14:07:36.000000000 +0800 > @@ -13,6 +13,7 @@ > #include <linux/slab.h> > #include <linux/res_counter.h> > #include <linux/uaccess.h> > +#include <linux/mm.h> > > void res_counter_init(struct res_counter *counter) > { > ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <6599ad830807012345r4f02f9acq3c8e9be633e109e8@mail.gmail.com>]
[parent not found: <6599ad830807012345r4f02f9acq3c8e9be633e109e8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH -mmotm] res_counter: fix building failure [not found] ` <6599ad830807012345r4f02f9acq3c8e9be633e109e8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2008-07-02 6:49 ` Li Zefan [not found] ` <486B250D.3090605-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Li Zefan @ 2008-07-02 6:49 UTC (permalink / raw) To: Paul Menage Cc: Linux Containers, LKML, Andrew Morton, Balbir Singh, Pavel Emelianov Paul Menage wrote: > On Tue, Jul 1, 2008 at 11:16 PM, Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> wrote: >> kernel/res_counter.c: In function 'res_counter_memparse_write_strategy': >> kernel/res_counter.c:115: error: implicit declaration of function 'PAGE_ALIGN' >> >> Signed-off-by: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> > > Acked-by: Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> > > Thanks - what architecture did it break on? > On my x86_32. I guess this break has something to do with: http://marc.info/?l=linux-mm&m=121389282702302&w=2 ([PATCH -mm] PAGE_ALIGN(): correctly handle 64-bit values on 32-bit) You tested the patch before that patch was accepted by Andrew. > Paul > >> --- >> >> should follow cgroup-files-convert-res_counter_write-to-be-a-cgroups-write_string-handler.patch >> >> --- linux-mm/kernel/res_counter.c.bak 2008-07-02 14:05:37.000000000 +0800 >> +++ linux-mm/kernel/res_counter.c 2008-07-02 14:07:36.000000000 +0800 >> @@ -13,6 +13,7 @@ >> #include <linux/slab.h> >> #include <linux/res_counter.h> >> #include <linux/uaccess.h> >> +#include <linux/mm.h> >> >> void res_counter_init(struct res_counter *counter) >> { >> > > ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <486B250D.3090605-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>]
* Re: [PATCH -mmotm] res_counter: fix building failure [not found] ` <486B250D.3090605-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> @ 2008-07-03 9:09 ` Balbir Singh 2008-07-03 10:17 ` Andrea Righi 1 sibling, 0 replies; 5+ messages in thread From: Balbir Singh @ 2008-07-03 9:09 UTC (permalink / raw) To: Li Zefan Cc: Linux Containers, LKML, Paul Menage, Pavel Emelianov, Andrew Morton, Andrea Righi Li Zefan wrote: > Paul Menage wrote: >> On Tue, Jul 1, 2008 at 11:16 PM, Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> wrote: >>> kernel/res_counter.c: In function 'res_counter_memparse_write_strategy': >>> kernel/res_counter.c:115: error: implicit declaration of function 'PAGE_ALIGN' >>> >>> Signed-off-by: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> >> Acked-by: Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> >> >> Thanks - what architecture did it break on? Acked-by: Balbir Singh <balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> CC'ing Andre as well -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -mmotm] res_counter: fix building failure [not found] ` <486B250D.3090605-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> 2008-07-03 9:09 ` Balbir Singh @ 2008-07-03 10:17 ` Andrea Righi 1 sibling, 0 replies; 5+ messages in thread From: Andrea Righi @ 2008-07-03 10:17 UTC (permalink / raw) To: Li Zefan Cc: Linux Containers, LKML, Paul Menage, Balbir Singh, Andrew Morton, Pavel Emelianov Li Zefan wrote: > Paul Menage wrote: >> On Tue, Jul 1, 2008 at 11:16 PM, Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> wrote: >>> kernel/res_counter.c: In function 'res_counter_memparse_write_strategy': >>> kernel/res_counter.c:115: error: implicit declaration of function 'PAGE_ALIGN' >>> >>> Signed-off-by: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> >> Acked-by: Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> >> >> Thanks - what architecture did it break on? >> > > On my x86_32. > > I guess this break has something to do with: > > http://marc.info/?l=linux-mm&m=121389282702302&w=2 > ([PATCH -mm] PAGE_ALIGN(): correctly handle 64-bit values on 32-bit) Exactly, your fix sounds good to me. Thanks. -Andrea > > You tested the patch before that patch was accepted by Andrew. > >> Paul >> >>> --- >>> >>> should follow cgroup-files-convert-res_counter_write-to-be-a-cgroups-write_string-handler.patch >>> >>> --- linux-mm/kernel/res_counter.c.bak 2008-07-02 14:05:37.000000000 +0800 >>> +++ linux-mm/kernel/res_counter.c 2008-07-02 14:07:36.000000000 +0800 >>> @@ -13,6 +13,7 @@ >>> #include <linux/slab.h> >>> #include <linux/res_counter.h> >>> #include <linux/uaccess.h> >>> +#include <linux/mm.h> >>> >>> void res_counter_init(struct res_counter *counter) >>> { >>> ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH -mmotm] res_counter: fix building failure
@ 2008-07-02 6:16 Li Zefan
0 siblings, 0 replies; 5+ messages in thread
From: Li Zefan @ 2008-07-02 6:16 UTC (permalink / raw)
To: Andrew Morton
Cc: Linux Containers, LKML, Paul Menage, Balbir Singh,
Pavel Emelianov
kernel/res_counter.c: In function 'res_counter_memparse_write_strategy':
kernel/res_counter.c:115: error: implicit declaration of function 'PAGE_ALIGN'
Signed-off-by: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
should follow cgroup-files-convert-res_counter_write-to-be-a-cgroups-write_string-handler.patch
--- linux-mm/kernel/res_counter.c.bak 2008-07-02 14:05:37.000000000 +0800
+++ linux-mm/kernel/res_counter.c 2008-07-02 14:07:36.000000000 +0800
@@ -13,6 +13,7 @@
#include <linux/slab.h>
#include <linux/res_counter.h>
#include <linux/uaccess.h>
+#include <linux/mm.h>
void res_counter_init(struct res_counter *counter)
{
^ permalink raw reply [flat|nested] 5+ messages in threadend of thread, other threads:[~2008-07-03 10:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <486B1D3D.5070805@cn.fujitsu.com>
[not found] ` <486B1D3D.5070805-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2008-07-02 6:45 ` [PATCH -mmotm] res_counter: fix building failure Paul Menage
[not found] ` <6599ad830807012345r4f02f9acq3c8e9be633e109e8@mail.gmail.com>
[not found] ` <6599ad830807012345r4f02f9acq3c8e9be633e109e8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-07-02 6:49 ` Li Zefan
[not found] ` <486B250D.3090605-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2008-07-03 9:09 ` Balbir Singh
2008-07-03 10:17 ` Andrea Righi
2008-07-02 6:16 Li Zefan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox