Linux Container Development
 help / color / mirror / Atom feed
From: Oren Laadan <orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
To: Sukadev Bhattiprolu
	<sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: Containers
	<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: Re: [PATCH][user-cr]: Fix typo in -lpthread
Date: Wed, 22 Jul 2009 20:58:34 -0400	[thread overview]
Message-ID: <4A67B5BA.2010609@librato.com> (raw)
In-Reply-To: <20090722202837.GA18639-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>



Sukadev Bhattiprolu wrote:
> From 55cb828036ff604fc9cdf686b51afb35247c8f57 Mon Sep 17 00:00:00 2001
> From: Sukadev Bhattiprolu <suka@suka.(none)>
> Date: Wed, 22 Jul 2009 13:22:38 -0700
> Subject: [PATCH] Fix typo in -lpthread
> 
> Signed-off-by: Sukadev Bhattiprolu <sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> ---
>  Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 53e3a46..3dbc63d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -44,7 +44,7 @@ all: $(PROGS)
>  
>  ckptinfo: ckptinfo_types.o
>  
> -mktree:	CFLAGS += -D__REENTRANT -pthreads
> +mktree:	CFLAGS += -D__REENTRANT -lpthread

Hmmm .. I actually meant '-pthread' which is a gcc option. I thought
it is better to use it than '-lpthread' directly. For instance, see:
http://stackoverflow.com/questions/875789/gcc-do-i-need-dreentrant-with-pthreads

(seems like '-pthreads' is a synonym, at least on x86).

Does it break on your system ?

Oren.

>  
>  ckptinfo_types.o: ckptinfo_types.c
>  	@echo $(CC) -c $(CFLAGS) $<

  parent reply	other threads:[~2009-07-23  0:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-22 20:28 [PATCH][user-cr]: Fix typo in -lpthread Sukadev Bhattiprolu
     [not found] ` <20090722202837.GA18639-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-07-23  0:58   ` Oren Laadan [this message]
     [not found]     ` <4A67B5BA.2010609-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-07-23  1:17       ` Sukadev Bhattiprolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A67B5BA.2010609@librato.com \
    --to=orenl-rdfvbdnroixbdgjk7y7tuq@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox