[PATCH][user-cr]: Fix typo in -lpthread

[PATCH][user-cr]: Fix typo in -lpthread

[Sukadev Bhattiprolu]

From 55cb828036ff604fc9cdf686b51afb35247c8f57 Mon Sep 17 00:00:00 2001
From: Sukadev Bhattiprolu <suka@suka.(none)>
Date: Wed, 22 Jul 2009 13:22:38 -0700
Subject: [PATCH] Fix typo in -lpthread

Signed-off-by: Sukadev Bhattiprolu <sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index 53e3a46..3dbc63d 100644
--- a/Makefile
+++ b/Makefile
@@ -44,7 +44,7 @@ all: $(PROGS)
 
 ckptinfo: ckptinfo_types.o
 
-mktree:	CFLAGS += -D__REENTRANT -pthreads
+mktree:	CFLAGS += -D__REENTRANT -lpthread
 
 ckptinfo_types.o: ckptinfo_types.c
 	@echo $(CC) -c $(CFLAGS) $<
-- 
1.6.0.4

Re: [PATCH][user-cr]: Fix typo in -lpthread

[Oren Laadan]

Sukadev Bhattiprolu wrote:
> From 55cb828036ff604fc9cdf686b51afb35247c8f57 Mon Sep 17 00:00:00 2001
> From: Sukadev Bhattiprolu <suka@suka.(none)>
> Date: Wed, 22 Jul 2009 13:22:38 -0700
> Subject: [PATCH] Fix typo in -lpthread
> 
> Signed-off-by: Sukadev Bhattiprolu <sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> ---
>  Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 53e3a46..3dbc63d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -44,7 +44,7 @@ all: $(PROGS)
>  
>  ckptinfo: ckptinfo_types.o
>  
> -mktree:	CFLAGS += -D__REENTRANT -pthreads
> +mktree:	CFLAGS += -D__REENTRANT -lpthread

Hmmm .. I actually meant '-pthread' which is a gcc option. I thought
it is better to use it than '-lpthread' directly. For instance, see:
http://stackoverflow.com/questions/875789/gcc-do-i-need-dreentrant-with-pthreads

(seems like '-pthreads' is a synonym, at least on x86).

Does it break on your system ?

Oren.

>  
>  ckptinfo_types.o: ckptinfo_types.c
>  	@echo $(CC) -c $(CFLAGS) $<

Re: [PATCH][user-cr]: Fix typo in -lpthread

[Sukadev Bhattiprolu]

Oren Laadan [orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org] wrote:
| > -mktree:	CFLAGS += -D__REENTRANT -pthreads
| > +mktree:	CFLAGS += -D__REENTRANT -lpthread
| 
| Hmmm .. I actually meant '-pthread' which is a gcc option.

Ok. I get "unrecognized option '-pthreads'" on x86 for following gcc versions 

	- gcc (Ubuntu 4.3.3-5ubuntu4)
	- gcc (GCC) 4.1.2 20071124 (Red Hat 4.1.2-42)

But '-pthread' works.