From: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
To: Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: bblum-OM76b2Iv3yLQjUSlxSEPGw@public.gmane.org,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/8] Revert commit 8827c288feb7810185aa7c2e37537202fc709869
Date: Thu, 20 Aug 2009 10:34:23 +0800 [thread overview]
Message-ID: <4A8CB62F.8030504@cn.fujitsu.com> (raw)
In-Reply-To: <20090818235812.22531.76212.stgit-u3IScbYxn0zHt/MElyovVYaSKrA+ACpX0E9HWUfgJXw@public.gmane.org>
Paul Menage wrote:
> Revert commit 8827c288feb7810185aa7c2e37537202fc709869
>
> This is in preparation for some clashing cgroups changes that subsume
> the original commit's functionaliy.
>
> Signed-off-by: Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
>
> --
>
> The original commit fixed a pid namespace bug which Ben Blum fixed
> independently (in the same way, but with different code) as part of a
> series of patches. I played around with trying to reconcile Ben's
> patch series with Li's patch, but concluded that it was simpler to
> just revert Li's, given that Ben's patch series contained essentially
> the same fix.
>
It's sure that reverting this commit makes things easier, but
rebasing this patchset shouldn't be hard. And this doesn't
sound a good reason to revert an innocent commit.
next prev parent reply other threads:[~2009-08-20 2:34 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 23:58 [PATCH 0/8] CGroups: cgroup memberlist enhancements/fixes Paul Menage
[not found] ` <20090818235059.22531.42618.stgit-u3IScbYxn0zHt/MElyovVYaSKrA+ACpX0E9HWUfgJXw@public.gmane.org>
2009-08-18 23:58 ` [PATCH 1/8] Revert commit 8827c288feb7810185aa7c2e37537202fc709869 Paul Menage
[not found] ` <20090818235812.22531.76212.stgit-u3IScbYxn0zHt/MElyovVYaSKrA+ACpX0E9HWUfgJXw@public.gmane.org>
2009-08-20 2:34 ` Li Zefan [this message]
[not found] ` <4A8CB62F.8030504-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-08-20 2:41 ` Paul Menage
[not found] ` <6599ad830908191941x6ee47d58x295c29f80f8c624c@mail.gmail.com>
[not found] ` <6599ad830908191941x6ee47d58x295c29f80f8c624c-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-08-20 3:11 ` Li Zefan
[not found] ` <4A8CBEDC.6010709@cn.fujitsu.com>
[not found] ` <4A8CBEDC.6010709-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-08-20 3:13 ` Paul Menage
[not found] ` <6599ad830908192013p328a2256o8c807a160e25a9a3@mail.gmail.com>
[not found] ` <6599ad830908192013p328a2256o8c807a160e25a9a3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-08-20 3:17 ` Li Zefan
2009-08-20 4:40 ` Matt Helsley
[not found] ` <20090820044059.GE29801@count0.beaverton.ibm.com>
[not found] ` <20090820044059.GE29801-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2009-08-20 4:49 ` Paul Menage
2009-08-20 21:13 ` Andrew Morton
2009-08-18 23:58 ` [PATCH 2/8] Adds a read-only "procs" file similar to "tasks" that shows only unique tgids Paul Menage
[not found] ` <20090818235817.22531.23434.stgit-u3IScbYxn0zHt/MElyovVYaSKrA+ACpX0E9HWUfgJXw@public.gmane.org>
2009-08-20 2:34 ` Li Zefan
2009-08-18 23:58 ` [PATCH 3/8] Ensures correct concurrent opening/reading of pidlists across pid namespaces Paul Menage
2009-08-18 23:58 ` [PATCH 4/8] Use vmalloc for large cgroups pidlist allocations Paul Menage
[not found] ` <4A8CB6F0.1020308@cn.fujitsu.com>
[not found] ` <4A8CB6F0.1020308-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-08-20 2:41 ` Paul Menage
[not found] ` <6599ad830908191941g77db4e69ve46bc8623f77d97f@mail.gmail.com>
[not found] ` <6599ad830908191941g77db4e69ve46bc8623f77d97f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-08-20 2:54 ` Li Zefan
[not found] ` <4A8CBAE1.9010408@cn.fujitsu.com>
[not found] ` <4A8CBAE1.9010408-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-08-20 3:04 ` Paul Menage
[not found] ` <20090818235827.22531.60306.stgit-u3IScbYxn0zHt/MElyovVYaSKrA+ACpX0E9HWUfgJXw@public.gmane.org>
2009-08-20 2:37 ` Li Zefan
2009-08-20 21:14 ` Andrew Morton
[not found] ` <20090820141400.f6d3d5a6.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-08-20 22:35 ` Jonathan Corbet
[not found] ` <20090820163510.27942b62@bike.lwn.net>
[not found] ` <20090820163510.27942b62-vw3g6Xz/EtPk1uMJSBkQmQ@public.gmane.org>
2009-08-20 22:56 ` David Rientjes
[not found] ` <alpine.DEB.2.00.0908201542440.29906@chino.kir.corp.google.com>
[not found] ` <alpine.DEB.2.00.0908201542440.29906-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2009-08-21 0:53 ` Li Zefan
2009-08-18 23:58 ` [PATCH 5/8] Changes css_set freeing mechanism to be under RCU Paul Menage
[not found] ` <20090818235832.22531.96610.stgit-u3IScbYxn0zHt/MElyovVYaSKrA+ACpX0E9HWUfgJXw@public.gmane.org>
2009-08-20 2:38 ` Li Zefan
2009-08-18 23:58 ` [PATCH 6/8] Lets ss->can_attach and ss->attach do whole threadgroups at a time Paul Menage
[not found] ` <20090818235837.22531.86001.stgit-u3IScbYxn0zHt/MElyovVYaSKrA+ACpX0E9HWUfgJXw@public.gmane.org>
2009-08-20 3:06 ` Li Zefan
2009-08-20 4:38 ` Matt Helsley
2009-08-18 23:58 ` [PATCH 7/8] Adds functionality to read/write lock CLONE_THREAD fork()ing per-threadgroup Paul Menage
[not found] ` <20090818235843.22531.57310.stgit-u3IScbYxn0zHt/MElyovVYaSKrA+ACpX0E9HWUfgJXw@public.gmane.org>
2009-08-20 2:39 ` Li Zefan
[not found] ` <4A8CB750.7040509@cn.fujitsu.com>
[not found] ` <4A8CB750.7040509-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-08-20 2:45 ` Paul Menage
[not found] ` <6599ad830908191945k7c5f86b6j3ea4194f0dffa9ce@mail.gmail.com>
[not found] ` <6599ad830908191945k7c5f86b6j3ea4194f0dffa9ce-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-08-20 21:13 ` Andrew Morton
[not found] ` <20090820141356.1bec84ed.akpm@linux-foundation.org>
[not found] ` <20090820141356.1bec84ed.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-08-20 21:16 ` Paul Menage
2009-08-21 4:24 ` Ben Blum
[not found] ` <20090821042403.GA25865-OM76b2Iv3yLQjUSlxSEPGw@public.gmane.org>
2009-08-21 4:50 ` Andrew Morton
[not found] ` <20090820215007.0e774abb.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-08-21 4:58 ` Paul Menage
2009-08-18 23:58 ` [PATCH 8/8] Adds ability to move all threads in a process to a new cgroup atomically Paul Menage
[not found] ` <20090818235848.22531.152.stgit-u3IScbYxn0zHt/MElyovVYaSKrA+ACpX0E9HWUfgJXw@public.gmane.org>
2009-08-20 3:00 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8CB62F.8030504@cn.fujitsu.com \
--to=lizf-bthxqxjhjhxqfuhtdcdx3a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=bblum-OM76b2Iv3yLQjUSlxSEPGw@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox