From: Oren Laadan <orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
To: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH 2/2] Add checkpoint/restart support for epoll files.
Date: Tue, 29 Sep 2009 19:31:15 -0400 [thread overview]
Message-ID: <4AC298C3.2030203@librato.com> (raw)
In-Reply-To: <4AC29086.8080407-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
Oren Laadan wrote:
>
> Matt Helsley wrote:
>> Save/restore epoll items during checkpoint/restart respectively.
>> kmalloc failures should be dealt with more kindly than just error-out
>> because epoll is made to poll many thousands of file descriptors.
>> Subsequent patches will change epoll c/r to "chunk" its output/input
>> respectively.
>
> [...]
>
>>
>> @@ -311,9 +313,11 @@ static int do_checkpoint_file_table(struct ckpt_ctx *ctx,
>> }
>>
>> ret = deferqueue_run(ctx->files_deferq);
>> - ckpt_debug("files_deferq ran %d entries\n", ret);
>> - if (ret > 0)
>> + if (ret > 0) {
>> + ckpt_debug("file checkpoint deferred %d work items\n", ret);
>> ret = 0;
>> + }
>> +
>
> With your permission, I'll do this hunk as a separate patch (and
> the restore counterpart too). So you can remove from your patch.
I take that back. I prefer the previous debug, that give info
whether the call succeeded or not...
Oren.
next prev parent reply other threads:[~2009-09-29 23:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 19:01 [PATCH 2/2] Add checkpoint/restart support for epoll files Matt Helsley
[not found] ` <1254164482-2193-2-git-send-email-matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-29 20:33 ` Serge E. Hallyn
2009-09-29 22:56 ` Oren Laadan
[not found] ` <4AC29086.8080407-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-09-29 23:31 ` Oren Laadan [this message]
2009-10-02 9:30 ` Matt Helsley
[not found] ` <20091002093050.GA4189-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2009-10-02 18:22 ` Oren Laadan
[not found] ` <4AC644C8.2070905-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-10-02 19:38 ` Oren Laadan
[not found] ` <4AC656A8.8070103-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-10-02 20:36 ` Matt Helsley
[not found] ` <20091002203609.GD4189-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2009-10-02 21:18 ` Oren Laadan
2009-10-02 20:27 ` Matt Helsley
[not found] ` <20091002202726.GC4189-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2009-10-02 21:22 ` Oren Laadan
[not found] ` <4AC66F08.6050405-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-10-02 21:35 ` Matt Helsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC298C3.2030203@librato.com \
--to=orenl-rdfvbdnroixbdgjk7y7tuq@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox