From: Oren Laadan <orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
To: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH 2/2] Add checkpoint/restart support for epoll files.
Date: Fri, 02 Oct 2009 15:38:16 -0400 [thread overview]
Message-ID: <4AC656A8.8070103@librato.com> (raw)
In-Reply-To: <4AC644C8.2070905-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
>>> I should probably change the code elsewhere too, but this test
>>> is unnecessary because ckpt_obj_fetch() will complain anyway.
>> I don't think it will complain since I don't see anything in the read or hash
>> code that checks for negative objrefs. However moving this into
>
> What is "this" that you want to move ?
>
>> ckpt_obj_fetch() would get rid of alot of code much like passing NULL into
>> kfree() does, so I'll remove this test.
>
> ckpt_obj_fetch() won't complain about a negative value a-priori, but
> the search is certain to fail. Nevertheless, I'll tighten the restart
> related calls in objhash to ensure that.
I take it back: ckpt_obj_fetch() returns -EINVAL when an objref isn't
found, not that the original value was invalid.
Oren
next prev parent reply other threads:[~2009-10-02 19:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 19:01 [PATCH 2/2] Add checkpoint/restart support for epoll files Matt Helsley
[not found] ` <1254164482-2193-2-git-send-email-matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-29 20:33 ` Serge E. Hallyn
2009-09-29 22:56 ` Oren Laadan
[not found] ` <4AC29086.8080407-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-09-29 23:31 ` Oren Laadan
2009-10-02 9:30 ` Matt Helsley
[not found] ` <20091002093050.GA4189-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2009-10-02 18:22 ` Oren Laadan
[not found] ` <4AC644C8.2070905-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-10-02 19:38 ` Oren Laadan [this message]
[not found] ` <4AC656A8.8070103-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-10-02 20:36 ` Matt Helsley
[not found] ` <20091002203609.GD4189-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2009-10-02 21:18 ` Oren Laadan
2009-10-02 20:27 ` Matt Helsley
[not found] ` <20091002202726.GC4189-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2009-10-02 21:22 ` Oren Laadan
[not found] ` <4AC66F08.6050405-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-10-02 21:35 ` Matt Helsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC656A8.8070103@librato.com \
--to=orenl-rdfvbdnroixbdgjk7y7tuq@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox