Linux Container Development
 help / color / mirror / Atom feed
From: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
To: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: Linux-Containers
	<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] user-cr: Makefile: Use standard variables
Date: Mon, 01 Mar 2010 13:25:19 -0500	[thread overview]
Message-ID: <4B8C068F.80602@cs.columbia.edu> (raw)
In-Reply-To: <92a207e405307fe1dc528f59e08782985830d5e9.1267213393.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>


Applied, thanks.

Matt Helsley wrote:
> [Based on the previous series of Makefile patches]
> 
> These are standard variables which many cross compiler systems will setup.
> I believe they are also variables Make sets up with default values.
> Make also sets $(MAKE) so you don't accidentally mix make binaries in the
> same build -- let's use that too.
> 
> Signed-off-by: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> ---
>  Makefile |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index a4a1a8a..60ddccd 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -34,10 +34,10 @@ LDLIBS = -lm
>  .PHONY: all distclean clean headers install
>  
>  all: $(PROGS)
> -	@make -C test
> +	@$(MAKE) -C test
>  
>  $(LIB_ECLONE):
> -	ar ruv $(LIB_ECLONE) $^
> +	$(AR) ruv $(LIB_ECLONE) $^
>  
>  # restart needs to be thread-safe
>  restart: CFLAGS += -D__REENTRANT -pthread
> @@ -82,4 +82,4 @@ distclean: clean
>  
>  clean:
>  	@rm -f $(PROGS) $(LIB_ECLONE) $(OTHER) *~ *.o headers.h
> -	@make -C test clean
> +	@$(MAKE) -C test clean

  parent reply	other threads:[~2010-03-01 18:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-26 18:56 [PATCH 0/4] user-cr: Makefile cleanups Matt Helsley
     [not found] ` <1267210602-11444-1-git-send-email-matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-02-26 18:56   ` [PATCH 1/4] user-cr: Add install prefix Matt Helsley
     [not found]   ` <eef3af1ee39b3146facf08eac6230be041e6263d.1267210517.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-02-26 18:56     ` [PATCH 2/4] user-cr: Make directories during install Matt Helsley
2010-02-26 18:56     ` [PATCH 3/4] user-cr: Fix install rule dependencies Matt Helsley
2010-02-26 18:56     ` [PATCH 4/4] user-cr: Remove pointless echo lines and @-prefixed lines Matt Helsley
2010-02-26 19:09   ` [PATCH 0/4] user-cr: Makefile cleanups Nathan Lynch
2010-02-26 19:44   ` [PATCH] user-cr: Makefile: Use standard variables Matt Helsley
     [not found]     ` <92a207e405307fe1dc528f59e08782985830d5e9.1267213393.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-03-01 18:25       ` Oren Laadan [this message]
2010-03-01 18:24   ` [PATCH 0/4] user-cr: Makefile cleanups Oren Laadan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B8C068F.80602@cs.columbia.edu \
    --to=orenl-eqauephvms7envbuuze7ea@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox