From: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
To: "Serge E. Hallyn" <serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Eric W. Biederman"
<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Subject: Re: [PATCH 2/3] cgroup : make the mount options parsing more accurate
Date: Tue, 03 Aug 2010 16:30:58 +0800 [thread overview]
Message-ID: <4C57D3C2.6040805@cn.fujitsu.com> (raw)
In-Reply-To: <20100729195736.GA19015-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
Cc: Andrew
Serge E. Hallyn wrote:
> The actual code does not detect 'all' with one subsystem name, which
> is IMHO mutually exclusive and when an option is specified even if it
> is not a subsystem name, we have to specify the 'all' option with the
> other option.
> eg:
> not detected : mount -t cgroup -o all,freezer cgroup /cgroup
> not flexible : mount -t cgroup -o noprefix,all cgroup /cgroup
>
> This patch fix this and makes the code a bit more clear by replacing
> 'else if' indentation by 'continue' blocks in the loop.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano-GANU6spQydw@public.gmane.org>
> Signed-off-by: Serge E. Hallyn <serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
> Cc: Eric W. Biederman <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
> Cc: Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Reviewed-by: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
next prev parent reply other threads:[~2010-08-03 8:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100729195629.GA13378@hallyn.com>
[not found] ` <20100729195629.GA13378-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
2010-07-29 19:57 ` [PATCH 2/3] cgroup : make the mount options parsing more accurate Serge E. Hallyn
2010-07-29 19:58 ` [PATCH 3/3] cgroup : remove the ns_cgroup Serge E. Hallyn
2010-08-03 8:30 ` [PATCH 1/3] cgroup : add clone_children control file Li Zefan
[not found] ` <20100729195812.GB19015@hallyn.com>
[not found] ` <20100729195812.GB19015-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
2010-07-29 21:40 ` [PATCH 3/3] cgroup : remove the ns_cgroup Matt Helsley
2010-07-29 21:46 ` Paul Menage
2010-08-03 8:31 ` Li Zefan
[not found] ` <20100729214008.GA2785@count0.beaverton.ibm.com>
[not found] ` <20100729214008.GA2785-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2010-07-29 22:39 ` Serge E. Hallyn
[not found] ` <20100729223957.GA12387@hallyn.com>
[not found] ` <20100729223957.GA12387-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
2010-07-29 23:00 ` Remaining work for userns (WAS Re: [PATCH 3/3] cgroup : remove the ns_cgroup) Matt Helsley
[not found] ` <20100729230052.GB2785@count0.beaverton.ibm.com>
[not found] ` <20100729230052.GB2785-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2010-07-29 23:23 ` Serge E. Hallyn
[not found] ` <20100729232352.GC13902@hallyn.com>
[not found] ` <20100729232352.GC13902-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
2010-07-31 0:23 ` Remaining work for userns Eric W. Biederman
[not found] ` <20100729195736.GA19015@hallyn.com>
[not found] ` <20100729195736.GA19015-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
2010-08-03 8:30 ` Li Zefan [this message]
2010-09-04 7:31 [PATCH 1/3] cgroup : add clone_children control file Daniel Lezcano
[not found] ` <1283585466-30265-1-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2010-09-04 7:31 ` [PATCH 2/3] cgroup : make the mount options parsing more accurate Daniel Lezcano
[not found] ` <1283585466-30265-2-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2010-09-07 19:38 ` Paul Menage
[not found] ` <AANLkTi=2qWKXGBsqmbZjUs_H2VSDykheAABha079puT3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-09-07 20:24 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C57D3C2.6040805@cn.fujitsu.com \
--to=lizf-bthxqxjhjhxqfuhtdcdx3a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox